Merge branch 'pl-rubocop-todo-raise-args' into 'master'

Resolves rubocop offense Style/RaiseArgs [RUN AS-IF-FOSS]

See merge request gitlab-org/gitlab!58009

.rubocop_todo.yml

@@ -820,14 +820,6 @@ Style/NumericLiteralPrefix:
 Style/PercentLiteralDelimiters:
   Enabled: false
 
-# Offense count: 247
-# Cop supports --auto-correct.
-# Configuration parameters: .
-# SupportedStyles: compact, exploded
-Style/RaiseArgs:
-  Enabled: false
-  EnforcedStyle: exploded
-
 # Offense count: 26
 # Cop supports --auto-correct.
 # Configuration parameters: SafeForConstants.

app/controllers/concerns/page_limiter.rb

@@ -46,7 +46,7 @@ module PageLimiter
 
     if params[:page].present? && params[:page].to_i > max_page_number
       record_page_limit_interception
-      raise PageOutOfBoundsError.new(max_page_number)
+      raise PageOutOfBoundsError, max_page_number
     end
   end
 

app/finders/packages/go/version_finder.rb

@@ -37,7 +37,7 @@ module Packages
           @mod.version_by(commit: target)
 
         else
-          raise ArgumentError.new 'not a valid target'
+          raise ArgumentError, 'not a valid target'
         end
       end
     end

app/helpers/time_zone_helper.rb

@@ -18,7 +18,7 @@ module TimeZoneHelper
   def timezone_data(format: :short)
     attrs = TIME_ZONE_FORMAT_ATTRS.fetch(format) do
       valid_formats = TIME_ZONE_FORMAT_ATTRS.keys.map { |k| ":#{k}"}.join(", ")
-      raise ArgumentError.new("Invalid format :#{format}. Valid formats are #{valid_formats}.")
+      raise ArgumentError, "Invalid format :#{format}. Valid formats are #{valid_formats}."
     end
 
     ActiveSupport::TimeZone.all.map do |timezone|

app/models/bulk_imports/tracker.rb

@@ -35,7 +35,7 @@ class BulkImports::Tracker < ApplicationRecord
 
   def pipeline_class
     unless BulkImports::Stage.pipeline_exists?(pipeline_name)
-      raise NameError.new("'#{pipeline_name}' is not a valid BulkImport Pipeline")
+      raise NameError, "'#{pipeline_name}' is not a valid BulkImport Pipeline"
     end
 
     pipeline_name.constantize

app/models/concerns/cache_markdown_field.rb

@@ -26,7 +26,7 @@ module CacheMarkdownField
 
   # Returns the default Banzai render context for the cached markdown field.
   def banzai_render_context(field)
-    raise ArgumentError.new("Unknown field: #{field.inspect}") unless
+    raise ArgumentError, "Unknown field: #{field.inspect}" unless
       cached_markdown_fields.markdown_fields.include?(field)
 
     # Always include a project key, or Banzai complains
@@ -99,7 +99,7 @@ module CacheMarkdownField
   end
 
   def cached_html_for(markdown_field)
-    raise ArgumentError.new("Unknown field: #{markdown_field}") unless
+    raise ArgumentError, "Unknown field: #{markdown_field}" unless
       cached_markdown_fields.markdown_fields.include?(markdown_field)
 
     __send__(cached_markdown_fields.html_field(markdown_field)) # rubocop:disable GitlabSecurity/PublicSend

app/models/concerns/group_descendant.rb

@@ -22,7 +22,7 @@ module GroupDescendant
     return [] if descendants.empty?
 
     unless descendants.all? { |hierarchy| hierarchy.is_a?(GroupDescendant) }
-      raise ArgumentError.new(_('element is not a hierarchy'))
+      raise ArgumentError, _('element is not a hierarchy')
     end
 
     all_hierarchies = descendants.map do |descendant|
@@ -56,7 +56,7 @@ module GroupDescendant
     end
 
     if parent.nil? && hierarchy_top.present?
-      raise ArgumentError.new(_('specified top is not part of the tree'))
+      raise ArgumentError, _('specified top is not part of the tree')
     end
 
     if parent && parent != hierarchy_top

app/models/concerns/has_wiki_page_meta_attributes.rb

@@ -59,7 +59,7 @@ module HasWikiPageMetaAttributes
 
       if conflict.present?
         meta.errors.add(:canonical_slug, 'Duplicate value found')
-        raise CanonicalSlugConflictError.new(meta)
+        raise CanonicalSlugConflictError, meta
       end
 
       meta

app/models/concerns/reactive_caching.rb

@@ -168,7 +168,7 @@ module ReactiveCaching
 
       data_deep_size = Gitlab::Utils::DeepSize.new(data, max_size: self.class.reactive_cache_hard_limit)
 
-      raise ExceededReactiveCacheLimit.new unless data_deep_size.valid?
+      raise ExceededReactiveCacheLimit unless data_deep_size.valid?
     end
   end
 end

app/models/concerns/sha256_attribute.rb

@@ -31,7 +31,7 @@ module Sha256Attribute
       end
 
       unless column.type == :binary
-        raise ArgumentError.new("sha256_attribute #{name.inspect} is invalid since the column type is not :binary")
+        raise ArgumentError, "sha256_attribute #{name.inspect} is invalid since the column type is not :binary"
       end
     rescue StandardError => error
       Gitlab::AppLogger.error "Sha256Attribute initialization: #{error.message}"

app/models/concerns/sha_attribute.rb

@@ -24,7 +24,7 @@ module ShaAttribute
       return unless column
 
       unless column.type == :binary
-        raise ArgumentError.new("sha_attribute #{name.inspect} is invalid since the column type is not :binary")
+        raise ArgumentError, "sha_attribute #{name.inspect} is invalid since the column type is not :binary"
       end
     rescue StandardError => error
       Gitlab::AppLogger.error "ShaAttribute initialization: #{error.message}"

app/models/concerns/storage/legacy_namespace.rb

@@ -10,7 +10,7 @@ module Storage
       proj_with_tags = first_project_with_container_registry_tags
 
       if proj_with_tags
-        raise Gitlab::UpdatePathError.new("Namespace #{name} (#{id}) cannot be moved because at least one project (e.g. #{proj_with_tags.name} (#{proj_with_tags.id})) has tags in container registry")
+        raise Gitlab::UpdatePathError, "Namespace #{name} (#{id}) cannot be moved because at least one project (e.g. #{proj_with_tags.name} (#{proj_with_tags.id})) has tags in container registry"
       end
 
       parent_was = if saved_change_to_parent? && parent_id_before_last_save.present?
@@ -83,7 +83,7 @@ module Storage
 
             # if we cannot move namespace directory we should rollback
             # db changes in order to prevent out of sync between db and fs
-            raise Gitlab::UpdatePathError.new('namespace directory cannot be moved')
+            raise Gitlab::UpdatePathError, 'namespace directory cannot be moved'
           end
         end
       end

app/models/concerns/token_authenticatable.rb

@@ -12,7 +12,7 @@ module TokenAuthenticatable
 
     def add_authentication_token_field(token_field, options = {})
       if token_authenticatable_fields.include?(token_field)
-        raise ArgumentError.new("#{token_field} already configured via add_authentication_token_field")
+        raise ArgumentError, "#{token_field} already configured via add_authentication_token_field"
       end
 
       token_authenticatable_fields.push(token_field)

app/models/concerns/x509_serial_number_attribute.rb

@@ -31,7 +31,7 @@ module X509SerialNumberAttribute
       end
 
       unless column.type == :binary
-        raise ArgumentError.new("x509_serial_number_attribute #{name.inspect} is invalid since the column type is not :binary")
+        raise ArgumentError, "x509_serial_number_attribute #{name.inspect} is invalid since the column type is not :binary"
       end
     rescue StandardError => error
       Gitlab::AppLogger.error "X509SerialNumberAttribute initialization: #{error.message}"

app/models/namespace/traversal_hierarchy.rb

@@ -20,7 +20,7 @@ class Namespace
     end
 
     def initialize(root)
-      raise StandardError.new('Must specify a root node') if root.parent_id
+      raise StandardError, 'Must specify a root node' if root.parent_id
 
       @root = root
     end

app/models/namespaces/traversal/linear.rb

@@ -85,7 +85,7 @@ module Namespaces
 
       # Search this namespace's lineage. Bound inclusively by top node.
       def lineage(top)
-        raise UnboundedSearch.new('Must bound search by a top') unless top
+        raise UnboundedSearch, 'Must bound search by a top' unless top
 
         without_sti_condition
           .traversal_ids_contains("{#{top.id}}")

app/models/packages/go/module.rb

@@ -18,8 +18,8 @@ module Packages
       end
 
       def version_by(ref: nil, commit: nil)
-        raise ArgumentError.new 'no filter specified' unless ref || commit
-        raise ArgumentError.new 'ref and commit are mutually exclusive' if ref && commit
+        raise ArgumentError, 'no filter specified' unless ref || commit
+        raise ArgumentError, 'ref and commit are mutually exclusive' if ref && commit
 
         if commit
           return version_by_sha(commit) if commit.is_a? String

app/models/packages/go/module_version.rb

@@ -17,15 +17,15 @@ module Packages
       delegate :build, to: :@semver, allow_nil: true
 
       def initialize(mod, type, commit, name: nil, semver: nil, ref: nil)
-        raise ArgumentError.new("invalid type '#{type}'") unless VALID_TYPES.include? type
-        raise ArgumentError.new("mod is required") unless mod
-        raise ArgumentError.new("commit is required") unless commit
+        raise ArgumentError, "invalid type '#{type}'" unless VALID_TYPES.include? type
+        raise ArgumentError, "mod is required" unless mod
+        raise ArgumentError, "commit is required" unless commit
 
         if type == :ref
-          raise ArgumentError.new("ref is required") unless ref
+          raise ArgumentError, "ref is required" unless ref
         elsif type == :pseudo
-          raise ArgumentError.new("name is required") unless name
-          raise ArgumentError.new("semver is required") unless semver
+          raise ArgumentError, "name is required" unless name
+          raise ArgumentError, "semver is required" unless semver
         end
 
         @mod = mod

app/models/project.rb

@@ -1004,7 +1004,7 @@ class Project < ApplicationRecord
   end
 
   def latest_successful_build_for_ref!(job_name, ref = default_branch)
-    latest_successful_build_for_ref(job_name, ref) || raise(ActiveRecord::RecordNotFound.new("Couldn't find job #{job_name}"))
+    latest_successful_build_for_ref(job_name, ref) || raise(ActiveRecord::RecordNotFound, "Couldn't find job #{job_name}")
   end
 
   def latest_pipeline(ref = default_branch, sha = nil)

app/models/ssh_host_key.rb

@@ -128,10 +128,10 @@ class SshHostKey
 
   def normalize_url(url)
     full_url = ::Addressable::URI.parse(url)
-    raise ArgumentError.new("Invalid URL") unless full_url&.scheme == 'ssh'
+    raise ArgumentError, "Invalid URL" unless full_url&.scheme == 'ssh'
 
     Addressable::URI.parse("ssh://#{full_url.host}:#{full_url.inferred_port}")
   rescue Addressable::URI::InvalidURIError
-    raise ArgumentError.new("Invalid URL")
+    raise ArgumentError, "Invalid URL"
   end
 end

app/services/clusters/aws/fetch_credentials_service.rb

@@ -14,7 +14,7 @@ module Clusters
       end
 
       def execute
-        raise MissingRoleError.new('AWS provisioning role not configured') unless provision_role.present?
+        raise MissingRoleError, 'AWS provisioning role not configured' unless provision_role.present?
 
         ::Aws::AssumeRoleCredentials.new(
           client: client,

app/services/groups/import_export/export_service.rb

@@ -96,7 +96,7 @@ module Groups
       def notify_error!
         notify_error
 
-        raise Gitlab::ImportExport::Error.new(shared.errors.to_sentence)
+        raise Gitlab::ImportExport::Error, shared.errors.to_sentence
       end
 
       def notify_success

app/services/groups/import_export/import_service.rb

@@ -114,7 +114,7 @@ module Groups
       def notify_error!
         notify_error
 
-        raise Gitlab::ImportExport::Error.new(shared.errors.to_sentence)
+        raise Gitlab::ImportExport::Error, shared.errors.to_sentence
       end
 
       def remove_base_tmp_dir

app/services/metrics/dashboard/grafana_metric_embed_service.rb

@@ -80,7 +80,7 @@ module Metrics
 
       def fetch_dashboard
         uid = GrafanaUidParser.new(grafana_url, project).parse
-        raise DashboardProcessingError.new(_('Dashboard uid not found')) unless uid
+        raise DashboardProcessingError, _('Dashboard uid not found') unless uid
 
         response = client.get_dashboard(uid: uid)
 
@@ -89,7 +89,7 @@ module Metrics
 
       def fetch_datasource(dashboard)
         name = DatasourceNameParser.new(grafana_url, dashboard).parse
-        raise DashboardProcessingError.new(_('Datasource name not found')) unless name
+        raise DashboardProcessingError, _('Datasource name not found') unless name
 
         response = client.get_datasource(name: name)
 
@@ -115,7 +115,7 @@ module Metrics
       def parse_json(json)
         Gitlab::Json.parse(json, symbolize_names: true)
       rescue JSON::ParserError
-        raise DashboardProcessingError.new(_('Grafana response contains invalid json'))
+        raise DashboardProcessingError, _('Grafana response contains invalid json')
       end
     end
 

app/services/metrics/dashboard/transient_embed_service.rb

@@ -39,7 +39,7 @@ module Metrics
       end
 
       def invalid_embed_json!(message)
-        raise DashboardProcessingError.new(_("Parsing error for param :embed_json. %{message}") % { message: message })
+        raise DashboardProcessingError, _("Parsing error for param :embed_json. %{message}") % { message: message }
       end
     end
   end

app/services/namespaces/statistics_refresher_service.rb

@@ -9,7 +9,7 @@ module Namespaces
 
       root_storage_statistics.recalculate!
     rescue ActiveRecord::ActiveRecordError => e
-      raise RefresherError.new(e.message)
+      raise RefresherError, e.message
     end
 
     private

app/services/packages/debian/extract_changes_metadata_service.rb

@@ -20,7 +20,7 @@ module Packages
           files: files
         }
       rescue ActiveModel::ValidationError => e
-        raise ExtractionError.new(e.message)
+        raise ExtractionError, e.message
       end
 
       private
@@ -41,10 +41,10 @@ module Packages
 
       def files
         strong_memoize(:files) do
-          raise ExtractionError.new("is not a changes file") unless file_type == :changes
-          raise ExtractionError.new("Files field is missing") if fields['Files'].blank?
-          raise ExtractionError.new("Checksums-Sha1 field is missing") if fields['Checksums-Sha1'].blank?
-          raise ExtractionError.new("Checksums-Sha256 field is missing") if fields['Checksums-Sha256'].blank?
+          raise ExtractionError, "is not a changes file" unless file_type == :changes
+          raise ExtractionError, "Files field is missing" if fields['Files'].blank?
+          raise ExtractionError, "Checksums-Sha1 field is missing" if fields['Checksums-Sha1'].blank?
+          raise ExtractionError, "Checksums-Sha256 field is missing" if fields['Checksums-Sha256'].blank?
 
           init_entries_from_files
           entries_from_checksums_sha1
@@ -73,8 +73,8 @@ module Packages
         each_lines_for('Checksums-Sha1') do |line|
           sha1sum, size, filename = line.split
           entry = @entries[filename]
-          raise ExtractionError.new("#{filename} is listed in Checksums-Sha1 but not in Files") unless entry
-          raise ExtractionError.new("Size for #{filename} in Files and Checksums-Sha1 differ") unless entry.size == size.to_i
+          raise ExtractionError, "#{filename} is listed in Checksums-Sha1 but not in Files" unless entry
+          raise ExtractionError, "Size for #{filename} in Files and Checksums-Sha1 differ" unless entry.size == size.to_i
 
           entry.sha1sum = sha1sum
         end
@@ -84,8 +84,8 @@ module Packages
         each_lines_for('Checksums-Sha256') do |line|
           sha256sum, size, filename = line.split
           entry = @entries[filename]
-          raise ExtractionError.new("#{filename} is listed in Checksums-Sha256 but not in Files") unless entry
-          raise ExtractionError.new("Size for #{filename} in Files and Checksums-Sha256 differ") unless entry.size == size.to_i
+          raise ExtractionError, "#{filename} is listed in Checksums-Sha256 but not in Files" unless entry
+          raise ExtractionError, "Size for #{filename} in Files and Checksums-Sha256 differ" unless entry.size == size.to_i
 
           entry.sha256sum = sha256sum
         end
@@ -104,7 +104,7 @@ module Packages
           entry.package_file = ::Packages::PackageFileFinder.new(@package_file.package, filename).execute!
           entry.validate!
         rescue ActiveRecord::RecordNotFound
-          raise ExtractionError.new("#{filename} is listed in Files but was not uploaded")
+          raise ExtractionError, "#{filename} is listed in Files but was not uploaded"
         end
       end
     end

app/services/packages/debian/extract_metadata_service.rb

@@ -12,7 +12,7 @@ module Packages
       end
 
       def execute
-        raise ExtractionError.new('invalid package file') unless valid_package_file?
+        raise ExtractionError, 'invalid package file' unless valid_package_file?
 
         extract_metadata
       end

app/services/packages/nuget/metadata_extraction_service.rb

@@ -26,7 +26,7 @@ module Packages
       end
 
       def execute
-        raise ExtractionError.new('invalid package file') unless valid_package_file?
+        raise ExtractionError, 'invalid package file' unless valid_package_file?
 
         extract_metadata(nuspec_file)
       end
@@ -94,8 +94,8 @@ module Packages
           Zip::File.open(file_path) do |zip_file|
             entry = zip_file.glob('*.nuspec').first
 
-            raise ExtractionError.new('nuspec file not found') unless entry
-            raise ExtractionError.new('nuspec file too big') if entry.size > MAX_FILE_SIZE
+            raise ExtractionError, 'nuspec file not found' unless entry
+            raise ExtractionError, 'nuspec file too big' if entry.size > MAX_FILE_SIZE
 
             entry.get_input_stream.read
           end

app/services/packages/nuget/update_package_from_metadata_service.rb

@@ -16,7 +16,7 @@ module Packages
       end
 
       def execute
-        raise InvalidMetadataError.new('package name and/or package version not found in metadata') unless valid_metadata?
+        raise InvalidMetadataError, 'package name and/or package version not found in metadata' unless valid_metadata?
 
         try_obtain_lease do
           @package_file.transaction do
@@ -33,7 +33,7 @@ module Packages
           end
         end
       rescue ActiveRecord::RecordInvalid => e
-        raise InvalidMetadataError.new(e.message)
+        raise InvalidMetadataError, e.message
       end
 
       private

app/services/packages/pypi/create_package_service.rb

@@ -13,7 +13,7 @@ module Packages
           )
 
           unless meta.valid?
-            raise ActiveRecord::RecordInvalid.new(meta)
+            raise ActiveRecord::RecordInvalid, meta
           end
 
           Packages::Pypi::Metadatum.upsert(meta.attributes)

app/services/packages/rubygems/process_gem_service.rb

@@ -107,7 +107,7 @@ module Packages
           Gem::Package.new(File.open(file_path))
         end
       rescue StandardError
-        raise ExtractionError.new('Unable to read gem file')
+        raise ExtractionError, 'Unable to read gem file'
       end
 
       # used by ExclusiveLeaseGuard

app/services/projects/after_rename_service.rb

@@ -49,10 +49,8 @@ module Projects
     def first_ensure_no_registry_tags_are_present
       return unless project.has_container_registry_tags?
 
-      raise RenameFailedError.new(
-        "Project #{full_path_before} cannot be renamed because images are " \
+      raise RenameFailedError, "Project #{full_path_before} cannot be renamed because images are " \
           "present in its container registry"
-      )
     end
 
     def expire_caches_before_rename
@@ -144,7 +142,7 @@ module Projects
 
       Gitlab::AppLogger.error(error)
 
-      raise RenameFailedError.new(error)
+      raise RenameFailedError, error
     end
   end
 end

app/services/projects/destroy_service.rb

@@ -174,7 +174,7 @@ module Projects
     end
 
     def raise_error(message)
-      raise DestroyError.new(message)
+      raise DestroyError, message
     end
 
     def flush_caches(project)

app/services/projects/import_export/export_service.rb

@@ -112,7 +112,7 @@ module Projects
       def notify_error!
         notify_error
 
-        raise Gitlab::ImportExport::Error.new(shared.errors.to_sentence)
+        raise Gitlab::ImportExport::Error, shared.errors.to_sentence
       end
 
       def notify_success

app/services/projects/transfer_service.rb

@@ -47,16 +47,16 @@ module Projects
       @old_namespace = project.namespace
 
       if Project.where(namespace_id: @new_namespace.try(:id)).where('path = ? or name = ?', project.path, project.name).exists?
-        raise TransferError.new(s_("TransferProject|Project with same name or path in target namespace already exists"))
+        raise TransferError, s_("TransferProject|Project with same name or path in target namespace already exists")
       end
 
       if project.has_container_registry_tags?
         # We currently don't support renaming repository if it contains tags in container registry
-        raise TransferError.new(s_('TransferProject|Project cannot be transferred, because tags are present in its container registry'))
+        raise TransferError, s_('TransferProject|Project cannot be transferred, because tags are present in its container registry')
       end
 
       if project.has_packages?(:npm) && !new_namespace_has_same_root?(project)
-        raise TransferError.new(s_("TransferProject|Root namespace can't be updated if project has NPM packages"))
+        raise TransferError, s_("TransferProject|Root namespace can't be updated if project has NPM packages")
       end
 
       proceed_to_transfer
@@ -170,7 +170,7 @@ module Projects
 
       # Move main repository
       unless move_repo_folder(@old_path, @new_path)
-        raise TransferError.new(s_("TransferProject|Cannot move project"))
+        raise TransferError, s_("TransferProject|Cannot move project")
       end
 
       # Disk path is changed; we need to ensure we reload it

app/services/projects/update_service.rb

@@ -49,11 +49,11 @@ module Projects
 
     def validate!
       unless valid_visibility_level_change?(project, params[:visibility_level])
-        raise ValidationError.new(s_('UpdateProject|New visibility level not allowed!'))
+        raise ValidationError, s_('UpdateProject|New visibility level not allowed!')
       end
 
       if renaming_project_with_container_registry_tags?
-        raise ValidationError.new(s_('UpdateProject|Cannot rename project because it contains container registry tags!'))
+        raise ValidationError, s_('UpdateProject|Cannot rename project because it contains container registry tags!')
       end
 
       validate_default_branch_change
@@ -67,7 +67,7 @@ module Projects
       if project.change_head(params[:default_branch])
         after_default_branch_change(previous_default_branch)
       else
-        raise ValidationError.new(s_("UpdateProject|Could not set the default branch"))
+        raise ValidationError, s_("UpdateProject|Could not set the default branch")
       end
     end
 

app/services/static_site_editor/config_service.rb

@@ -67,7 +67,7 @@ module StaticSiteEditor
 
     def check_for_duplicate_keys!(generated_data, file_data)
       duplicate_keys = generated_data.keys & file_data.keys
-      raise ValidationError.new("Duplicate key(s) '#{duplicate_keys}' found.") if duplicate_keys.present?
+      raise ValidationError, "Duplicate key(s) '#{duplicate_keys}' found." if duplicate_keys.present?
     end
 
     def merged_data(generated_data, file_data)

app/services/submit_usage_ping_service.rb

@@ -22,7 +22,7 @@ class SubmitUsagePingService
 
     usage_data = Gitlab::UsageData.data(force_refresh: true)
 
-    raise SubmissionError.new('Usage data is blank') if usage_data.blank?
+    raise SubmissionError, 'Usage data is blank' if usage_data.blank?
 
     raw_usage_data = save_raw_usage_data(usage_data)
 
@@ -33,12 +33,12 @@ class SubmitUsagePingService
       headers: { 'Content-type' => 'application/json' }
     )
 
-    raise SubmissionError.new("Unsuccessful response code: #{response.code}") unless response.success?
+    raise SubmissionError, "Unsuccessful response code: #{response.code}" unless response.success?
 
     version_usage_data_id = response.dig('conv_index', 'usage_data_id') || response.dig('dev_ops_score', 'usage_data_id')
 
     unless version_usage_data_id.is_a?(Integer) && version_usage_data_id > 0
-      raise SubmissionError.new("Invalid usage_data_id in response: #{version_usage_data_id}")
+      raise SubmissionError, "Invalid usage_data_id in response: #{version_usage_data_id}"
     end
 
     raw_usage_data.update_version_metadata!(usage_data_id: version_usage_data_id)

app/services/terraform/remote_state_handler.rb

@@ -94,7 +94,7 @@ module Terraform
     end
 
     def find_state!(find_params)
-      find_state(find_params) || raise(ActiveRecord::RecordNotFound.new("Couldn't find state"))
+      find_state(find_params) || raise(ActiveRecord::RecordNotFound, "Couldn't find state")
     end
   end
 end

app/services/todos/destroy/entity_leave_service.rb

@@ -9,7 +9,7 @@ module Todos
 
       def initialize(user_id, entity_id, entity_type)
         unless %w(Group Project).include?(entity_type)
-          raise ArgumentError.new("#{entity_type} is not an entity user can leave")
+          raise ArgumentError, "#{entity_type} is not an entity user can leave"
         end
 
         @user = UserFinder.new(user_id).find_by_id

app/services/users/update_assigned_open_issue_count_service.rb

@@ -8,7 +8,7 @@ module Users
     def initialize(target_user:)
       @target_user = target_user
 
-      raise ArgumentError.new("Please provide a target user") unless target_user.is_a?(User)
+      raise ArgumentError, "Please provide a target user" unless target_user.is_a?(User)
     end
 
     def execute

app/services/users/update_canonical_email_service.rb

@@ -7,7 +7,7 @@ module Users
     INCLUDED_DOMAINS_PATTERN = [/gmail.com/].freeze
 
     def initialize(user:)
-      raise ArgumentError.new("Please provide a user") unless user.is_a?(User)
+      raise ArgumentError, "Please provide a user" unless user.is_a?(User)
 
       @user = user
     end

app/services/users/update_service.rb

@@ -34,7 +34,7 @@ module Users
     def execute!(*args, &block)
       result = execute(*args, &block)
 
-      raise ActiveRecord::RecordInvalid.new(@user) unless result[:status] == :success
+      raise ActiveRecord::RecordInvalid, @user unless result[:status] == :success
 
       true
     end

app/uploaders/object_storage.rb

@@ -451,7 +451,7 @@ module ObjectStorage
     def with_exclusive_lease
       lease_key = exclusive_lease_key
       uuid = Gitlab::ExclusiveLease.new(lease_key, timeout: 1.hour.to_i).try_obtain
-      raise ExclusiveLeaseTaken.new(lease_key) unless uuid
+      raise ExclusiveLeaseTaken, lease_key unless uuid
 
       yield uuid
     ensure

app/validators/cron_validator.rb

@@ -10,7 +10,7 @@ class CronValidator < ActiveModel::EachValidator
       cron_parser = Gitlab::Ci::CronParser.new(record.public_send(attribute), record.cron_timezone) # rubocop:disable GitlabSecurity/PublicSend
       record.errors.add(attribute, " is invalid syntax") unless cron_parser.cron_valid?
     else
-      raise NonWhitelistedAttributeError.new "Non-whitelisted attribute"
+      raise NonWhitelistedAttributeError, "Non-whitelisted attribute"
     end
   end
 end

app/workers/concerns/git_garbage_collect_methods.rb

@@ -97,10 +97,10 @@ module GitGarbageCollectMethods
     end
   rescue GRPC::NotFound => e
     Gitlab::GitLogger.error("#{__method__} failed:\nRepository not found")
-    raise Gitlab::Git::Repository::NoRepository.new(e)
+    raise Gitlab::Git::Repository::NoRepository, e
   rescue GRPC::BadStatus => e
     Gitlab::GitLogger.error("#{__method__} failed:\n#{e}")
-    raise Gitlab::Git::CommandError.new(e)
+    raise Gitlab::Git::CommandError, e
   end
 
   def get_gitaly_client(task, repository)

app/workers/object_storage/migrate_uploads_worker.rb

@@ -50,7 +50,7 @@ module ObjectStorage
         Gitlab::AppLogger.info header(success, failures)
         Gitlab::AppLogger.warn failures(failures)
 
-        raise MigrationFailures.new(failures.map(&:error)) if failures.any?
+        raise MigrationFailures, failures.map(&:error) if failures.any?
       end
 
       def header(success, failures)

app/workers/packages/maven/metadata/sync_worker.rb

@@ -33,10 +33,10 @@ module Packages
           if result.success?
             log_extra_metadata_on_done(:message, result.message)
           else
-            raise SyncError.new(result.message)
+            raise SyncError, result.message
           end
 
-          raise SyncError.new(result.message) unless result.success?
+          raise SyncError, result.message unless result.success?
         end
 
         private

app/workers/users/update_open_issue_count_worker.rb

@@ -11,10 +11,10 @@ module Users
     def perform(target_user_ids)
       target_user_ids = Array.wrap(target_user_ids)
 
-      raise ArgumentError.new('No target user ID provided') if target_user_ids.empty?
+      raise ArgumentError, 'No target user ID provided' if target_user_ids.empty?
 
       target_users = User.id_in(target_user_ids)
-      raise ArgumentError.new('No valid target user ID provided') if target_users.empty?
+      raise ArgumentError, 'No valid target user ID provided' if target_users.empty?
 
       target_users.each do |user|
         Users::UpdateAssignedOpenIssueCountService.new(target_user: user).execute

changelogs/unreleased/pl-rubocop-todo-raise-args.yml

+---
+title: Resolves offenses Style/RaiseArgs
+merge_request: 58009
+author: Shubham Kumar @imskr
+type: fixed

db/migrate/20190402150158_backport_enterprise_schema.rb

@@ -914,7 +914,7 @@ class BackportEnterpriseSchema < ActiveRecord::Migration[5.0]
         MSG
       end
 
-    raise StandardError.new(message)
+    raise StandardError, message
   end
 
   def create_missing_tables

ee/app/models/concerns/ee/vulnerability_finding_signature_helpers.rb

@@ -17,7 +17,7 @@ module EE
 
     class_methods do
       def priority(algorithm_type)
-        raise ArgumentError.new("No priority for #{algorithm_type.inspect}") unless PRIORITIES.key?(algorithm_type)
+        raise ArgumentError, "No priority for #{algorithm_type.inspect}" unless PRIORITIES.key?(algorithm_type)
 
         PRIORITIES[algorithm_type]
       end

ee/app/models/geo/tracking_base.rb

@@ -23,13 +23,13 @@ module Geo
       unless ::Gitlab::Geo.geo_database_configured?
         message = NOT_CONFIGURED_MSG
         message = "#{message}\nIn the GDK root, try running `make geo-setup`" if Rails.env.development?
-        raise SecondaryNotConfigured.new(message)
+        raise SecondaryNotConfigured, message
       end
 
       # Don't call super because LoadBalancing::ActiveRecordProxy will intercept it
       retrieve_connection
     rescue ActiveRecord::NoDatabaseError
-      raise SecondaryNotConfigured.new(NOT_CONFIGURED_MSG)
+      raise SecondaryNotConfigured, NOT_CONFIGURED_MSG
     end
   end
 end

ee/app/models/vulnerabilities/feedback.rb

@@ -58,11 +58,11 @@ module Vulnerabilities
     def self.validate_enums(feedback_params)
       unless feedback_types.include?(feedback_params[:feedback_type])
 
-        raise ArgumentError.new("'#{feedback_params[:feedback_type]}' is not a valid feedback_type")
+        raise ArgumentError, "'#{feedback_params[:feedback_type]}' is not a valid feedback_type"
       end
 
       unless categories.include?(feedback_params[:category])
-        raise ArgumentError.new("'#{feedback_params[:category]}' is not a valid category")
+        raise ArgumentError, "'#{feedback_params[:category]}' is not a valid category"
       end
     end
 

ee/app/services/ci/minutes/batch_reset_service.rb

@@ -32,7 +32,7 @@ module Ci
           reset_ci_minutes!(namespaces)
         end
 
-        raise BatchNotResetError.new(@failed_batches) if @failed_batches.any?
+        raise BatchNotResetError, @failed_batches if @failed_batches.any?
       end
 
       private

ee/app/services/dast_site_validations/validate_service.rb

@@ -6,7 +6,7 @@ module DastSiteValidations
     TokenNotFound = Class.new(StandardError)
 
     def execute!
-      raise PermissionsError.new('Insufficient permissions') unless allowed?
+      raise PermissionsError, 'Insufficient permissions' unless allowed?
 
       return if dast_site_validation.passed?
 
@@ -49,7 +49,7 @@ module DastSiteValidations
     end
 
     def validate!(response)
-      raise TokenNotFound.new('Could not find token') unless token_found?(response)
+      raise TokenNotFound, 'Could not find token' unless token_found?(response)
 
       dast_site_validation.pass
     end

ee/app/services/dast_sites/find_or_create_service.rb

@@ -5,7 +5,7 @@ module DastSites
     PermissionsError = Class.new(StandardError)
 
     def execute!(url:)
-      raise PermissionsError.new('Insufficient permissions') unless allowed?
+      raise PermissionsError, 'Insufficient permissions' unless allowed?
 
       find_or_create_by!(url)
     end

ee/app/services/licenses/destroy_service.rb

@@ -10,7 +10,7 @@ module Licenses
     def execute
       raise ActiveRecord::RecordNotFound unless license
       raise Gitlab::Access::AccessDeniedError unless can?(user, :destroy_licenses)
-      raise DestroyCloudLicenseError.new(_('Cloud licenses can not be removed.')) if license.cloud_license?
+      raise DestroyCloudLicenseError, _('Cloud licenses can not be removed.') if license.cloud_license?
 
       license.destroy
     end

ee/db/fixtures/development/32_compliance_dashboard_merge_requests.rb

@@ -67,7 +67,7 @@ class Gitlab::Seeder::ComplianceDashboardMergeRequests
       merge_request
     end
   rescue ::Gitlab::Access::AccessDeniedError
-    raise ::Gitlab::Access::AccessDeniedError.new("If you are re-creating your GitLab database, you should also delete your old repositories located at $GDK/repositories/@hashed")
+    raise ::Gitlab::Access::AccessDeniedError, "If you are re-creating your GitLab database, you should also delete your old repositories located at $GDK/repositories/@hashed"
   end
 
   def create_pipeline!(project, ref, commit, status)

ee/lib/ee/container_registry/client.rb

@@ -16,7 +16,7 @@ module EE
 
         response = faraday.put(url, payload, headers)
 
-        raise Error.new("Push Blob error: #{response.body}") unless response.success?
+        raise Error, "Push Blob error: #{response.body}" unless response.success?
 
         true
       end
@@ -24,7 +24,7 @@ module EE
       def push_manifest(name, tag, manifest, manifest_type)
         response = faraday.put("v2/#{name}/manifests/#{tag}", manifest, { 'Content-Type' => manifest_type })
 
-        raise Error.new("Push manifest error: #{response.body}") unless response.success?
+        raise Error, "Push manifest error: #{response.body}" unless response.success?
 
         true
       end
@@ -60,7 +60,7 @@ module EE
           file.write(chunk)
         end
 
-        raise Error.new("Could not download the blob: #{digest}") unless response.status.success?
+        raise Error, "Could not download the blob: #{digest}" unless response.status.success?
 
         file
       ensure
@@ -76,7 +76,7 @@ module EE
       def get_upload_url(name, digest)
         response = faraday.post("/v2/#{name}/blobs/uploads/")
 
-        raise Error.new("Get upload URL error: #{response.body}") unless response.success?
+        raise Error, "Get upload URL error: #{response.body}" unless response.success?
 
         upload_url = URI(response.headers['location'])
         upload_url.query = "#{upload_url.query}&#{URI.encode_www_form(digest: digest)}"

ee/lib/ee/gitlab/checks/push_rules/branch_check.rb

@@ -14,7 +14,7 @@ module EE
             logger.log_timed(LOG_MESSAGE) do
               unless branch_name_allowed_by_push_rule?
                 message = ERROR_MESSAGE % { branch_name_regex: push_rule.branch_name_regex }
-                raise ::Gitlab::GitAccess::ForbiddenError.new(message)
+                raise ::Gitlab::GitAccess::ForbiddenError, message
               end
             end
 

ee/lib/gitlab/analytics/cycle_analytics/summary/group/base.rb

@@ -14,11 +14,11 @@ module Gitlab
             end
 
             def title
-              raise NotImplementedError.new("Expected #{self.name} to implement title")
+              raise NotImplementedError, "Expected #{self.name} to implement title"
             end
 
             def value
-              raise NotImplementedError.new("Expected #{self.name} to implement value")
+              raise NotImplementedError, "Expected #{self.name} to implement value"
             end
           end
         end

ee/lib/gitlab/analytics/cycle_analytics/summary/group/base_time.rb

@@ -21,11 +21,11 @@ module Gitlab
             end
 
             def start_event_identifier
-              raise NotImplementedError.new("Expected #{self.name} to implement start_event_identifier")
+              raise NotImplementedError, "Expected #{self.name} to implement start_event_identifier"
             end
 
             def end_event_identifier
-              raise NotImplementedError.new("Expected #{self.name} to implement end_event_identifier")
+              raise NotImplementedError, "Expected #{self.name} to implement end_event_identifier"
             end
 
             private

ee/lib/gitlab/elastic/document_reference.rb

@@ -58,7 +58,7 @@ module Gitlab
           when Array
             serialize_array(anything)
           else
-            raise InvalidError.new("Don't know how to serialize #{anything.class}")
+            raise InvalidError, "Don't know how to serialize #{anything.class}"
           end
         end
 
@@ -85,7 +85,7 @@ module Gitlab
         private
 
         def test_array!(array)
-          raise InvalidError.new("Bad array representation: #{array.inspect}") unless
+          raise InvalidError, "Bad array representation: #{array.inspect}" unless
             (3..4).cover?(array.size)
         end
       end

ee/lib/gitlab/geo/jwt_request_decoder.rb

@@ -59,7 +59,7 @@ module Gitlab
         rescue OpenSSL::Cipher::CipherError
           message = 'Error decrypting the Geo secret from the database. Check that the primary and secondary have the same db_key_base.'
           log_error(message)
-          raise InvalidDecryptionKeyError.new(message)
+          raise InvalidDecryptionKeyError, message
         end
 
         return unless data.present?
@@ -81,7 +81,7 @@ module Gitlab
         rescue JWT::ImmatureSignature, JWT::ExpiredSignature
           message = "Signature not within leeway of #{IAT_LEEWAY} seconds. Check your system clocks!"
           log_error(message)
-          raise InvalidSignatureTimeError.new(message)
+          raise InvalidSignatureTimeError, message
         rescue JWT::DecodeError => e
           log_error("Error decoding Geo request: #{e}")
           nil

ee/lib/gitlab/graphql/aggregations/epics/lazy_epic_aggregate.rb

@@ -19,7 +19,7 @@ module Gitlab
 
             error = validate_facet(aggregate_facet)
             if error
-              raise ArgumentError.new("#{error}. Please specify either #{COUNT} or #{WEIGHT_SUM}")
+              raise ArgumentError, "#{error}. Please specify either #{COUNT} or #{WEIGHT_SUM}"
             end
 
             @facet = aggregate_facet.to_sym

ee/lib/gitlab/graphql/loaders/bulk_epic_aggregate_loader.rb

@@ -26,14 +26,14 @@ module Gitlab
           # limit (~200), then postgres uses a slow query plan and first does
           # left join of epic_issues with issues which times out
           epic_ids = ::Epic.ids_for_base_and_decendants(target_epic_ids)
-          raise ArgumentError.new("There are too many epics to load. Please select fewer epics or contact your administrator.") if epic_ids.count >= MAXIMUM_LOADABLE
+          raise ArgumentError, "There are too many epics to load. Please select fewer epics or contact your administrator." if epic_ids.count >= MAXIMUM_LOADABLE
 
           # We do a left outer join in order to capture epics with no issues
           # This is so we can aggregate the epic counts for every epic
           raw_results = []
           epic_ids.in_groups_of(EPIC_BATCH_SIZE).each do |epic_batch_ids|
             raw_results += ::Epic.issue_metadata_for_epics(epic_ids: epic_ids, limit: MAXIMUM_LOADABLE)
-            raise ArgumentError.new("There are too many records to load. Please select fewer epics or contact your administrator.") if raw_results.count >= MAXIMUM_LOADABLE
+            raise ArgumentError, "There are too many records to load. Please select fewer epics or contact your administrator." if raw_results.count >= MAXIMUM_LOADABLE
           end
 
           @results = raw_results.group_by { |record| record[:id] }

ee/spec/lib/gitlab/database/load_balancing/host_spec.rb

@@ -17,7 +17,7 @@ RSpec.describe Gitlab::Database::LoadBalancing::Host do
   def raise_and_wrap(wrapper, original)
     raise original
   rescue original.class
-    raise wrapper.new('boom')
+    raise wrapper, 'boom'
   end
 
   def wrapped_exception(wrapper, original)

ee/spec/lib/gitlab/database/load_balancing/load_balancer_spec.rb

@@ -21,7 +21,7 @@ RSpec.describe Gitlab::Database::LoadBalancing::LoadBalancer, :request_store do
   def raise_and_wrap(wrapper, original)
     raise original
   rescue original.class
-    raise wrapper.new('boop')
+    raise wrapper, 'boop'
   end
 
   def wrapped_exception(wrapper, original)
@@ -94,7 +94,7 @@ RSpec.describe Gitlab::Database::LoadBalancing::LoadBalancer, :request_store do
       returned = lb.read do
         unless raised
           raised = true
-          raise conflict_error.new
+          raise conflict_error
         end
 
         10
@@ -107,7 +107,7 @@ RSpec.describe Gitlab::Database::LoadBalancing::LoadBalancer, :request_store do
       expect(lb).to receive(:release_host).exactly(6).times
       expect(lb).to receive(:read_write)
 
-      lb.read { raise conflict_error.new }
+      lb.read { raise conflict_error }
     end
 
     it 'uses the primary if no secondaries are available' do

ee/spec/services/auto_merge/merge_train_service_spec.rb

@@ -59,7 +59,7 @@ RSpec.describe AutoMerge::MergeTrainService do
 
     context 'when failed to save the record' do
       before do
-        allow(merge_request).to receive(:save!) { raise PG::QueryCanceled.new }
+        allow(merge_request).to receive(:save!) { raise PG::QueryCanceled }
       end
 
       it 'returns result code' do
@@ -69,7 +69,7 @@ RSpec.describe AutoMerge::MergeTrainService do
 
     context 'when statement timeout happened on system note creation' do
       before do
-        allow(SystemNoteService).to receive(:merge_train) { raise PG::QueryCanceled.new }
+        allow(SystemNoteService).to receive(:merge_train) { raise PG::QueryCanceled }
       end
 
       it 'returns failed status' do
@@ -218,7 +218,7 @@ RSpec.describe AutoMerge::MergeTrainService do
 
     context 'when statement timeout happened on system note creation' do
       before do
-        allow(SystemNoteService).to receive(:cancel_merge_train) { raise PG::QueryCanceled.new }
+        allow(SystemNoteService).to receive(:cancel_merge_train) { raise PG::QueryCanceled }
       end
 
       it 'returns error' do
@@ -304,7 +304,7 @@ RSpec.describe AutoMerge::MergeTrainService do
 
     context 'when statement timeout happened on system note creation' do
       before do
-        allow(SystemNoteService).to receive(:abort_merge_train) { raise PG::QueryCanceled.new }
+        allow(SystemNoteService).to receive(:abort_merge_train) { raise PG::QueryCanceled }
       end
 
       it 'returns error' do

ee/spec/services/merge_trains/create_pipeline_service_spec.rb

@@ -141,7 +141,7 @@ RSpec.describe MergeTrains::CreatePipelineService do
           context 'when there is a conflict on merge ref creation' do
             before do
               allow(project.repository).to receive(:merge_to_ref) do
-                raise Gitlab::Git::CommandError.new('Failed to create merge commit')
+                raise Gitlab::Git::CommandError, 'Failed to create merge commit'
               end
             end
 

ee/spec/workers/geo/repository_sync_worker_spec.rb

@@ -29,7 +29,7 @@ RSpec.describe Geo::RepositorySyncWorker, :geo, :clean_gitlab_redis_cache do
       create(:geo_project_registry, :synced, :repository_dirty, project: unhealthy_dirty)
 
       allow(Gitlab::GitalyClient).to receive(:call) do
-        raise GRPC::Unavailable.new('No Gitaly available')
+        raise GRPC::Unavailable, 'No Gitaly available'
       end
 
       expect(repository_worker).not_to receive(:perform_async).with('broken')

ee/spec/workers/geo/repository_verification/primary/batch_worker_spec.rb

@@ -26,7 +26,7 @@ RSpec.describe Geo::RepositoryVerification::Primary::BatchWorker, :clean_gitlab_
       create(:repository_state, :repository_outdated, project: unhealthy_outdated)
 
       allow(Gitlab::GitalyClient).to receive(:call) do
-        raise GRPC::Unavailable.new('No Gitaly available')
+        raise GRPC::Unavailable, 'No Gitaly available'
       end
 
       expect(Geo::RepositoryVerification::Primary::ShardWorker).not_to receive(:perform_async).with('broken')

ee/spec/workers/geo/repository_verification/secondary/scheduler_worker_spec.rb

@@ -23,7 +23,7 @@ RSpec.describe Geo::RepositoryVerification::Secondary::SchedulerWorker, :clean_g
       create(:project, :broken_storage)
 
       allow(Gitlab::GitalyClient).to receive(:call) do
-        raise GRPC::Unavailable.new('No Gitaly available')
+        raise GRPC::Unavailable, 'No Gitaly available'
       end
 
       expect(Geo::RepositoryVerification::Secondary::ShardWorker).not_to receive(:perform_async).with('broken')

lib/api/helpers/headers_helpers.rb

@@ -8,7 +8,7 @@ module API
       def set_http_headers(header_data)
         header_data.each do |key, value|
           if value.is_a?(Enumerable)
-            raise ArgumentError.new("Header value should be a string")
+            raise ArgumentError, "Header value should be a string"
           end
 
           header "X-Gitlab-#{key.to_s.split('_').collect(&:capitalize).join('-')}", value.to_s

lib/api/internal/base.rb

@@ -158,7 +158,7 @@ module API
           status 200
 
           unless actor.key_or_user
-            raise ActiveRecord::RecordNotFound.new('User not found!')
+            raise ActiveRecord::RecordNotFound, 'User not found!'
           end
 
           actor.update_last_used_at!

lib/bulk_imports/clients/http.rb

@@ -63,7 +63,7 @@ module BulkImports
       def with_error_handling
         response = yield
 
-        raise ConnectionError.new("Error #{response.code}") unless response.success?
+        raise ConnectionError, "Error #{response.code}" unless response.success?
 
         response
       rescue *Gitlab::HTTP::HTTP_ERRORS => e

lib/declarative_enum.rb

@@ -64,7 +64,7 @@ module DeclarativeEnum
   end
 
   def define(&block)
-    raise LocalJumpError.new('No block given') unless block
+    raise LocalJumpError, 'No block given' unless block
 
     @definition = Builder.new(definition, block).build
   end

lib/flowdock/git.rb

@@ -17,7 +17,7 @@ module Flowdock
     end
 
     def initialize(ref, from, to, options = {})
-      raise TokenError.new("Flowdock API token not found") unless options[:token]
+      raise TokenError, "Flowdock API token not found" unless options[:token]
 
       @ref = ref
       @from = from

lib/gitlab/auth/auth_finders.rb

@@ -160,7 +160,7 @@ module Gitlab
 
         case AccessTokenValidationService.new(access_token, request: request).validate(scopes: scopes)
         when AccessTokenValidationService::INSUFFICIENT_SCOPE
-          raise InsufficientScopeError.new(scopes)
+          raise InsufficientScopeError, scopes
         when AccessTokenValidationService::EXPIRED
           raise ExpiredError
         when AccessTokenValidationService::REVOKED

lib/gitlab/auth/ldap/config.rb

@@ -59,7 +59,7 @@ module Gitlab
         end
 
         def self.invalid_provider(provider)
-          raise InvalidProvider.new("Unknown provider (#{provider}). Available providers: #{providers}")
+          raise InvalidProvider, "Unknown provider (#{provider}). Available providers: #{providers}"
         end
 
         def self.encrypted_secrets

lib/gitlab/bare_repository_import/importer.rb

@@ -13,7 +13,7 @@ module Gitlab
         repos_to_import = Dir.glob(import_path + '**/*.git')
 
         unless user = User.admins.order_id_asc.first
-          raise NoAdminError.new('No admin user found to import repositories')
+          raise NoAdminError, 'No admin user found to import repositories'
         end
 
         repos_to_import.each do |repo_path|

lib/gitlab/changelog/committer.rb

@@ -55,7 +55,7 @@ module Gitlab
 
           result = service.execute
 
-          raise Error.new(result[:message]) if result[:status] != :success
+          raise Error, result[:message] if result[:status] != :success
         end
       end
 

lib/gitlab/changelog/parser.rb

@@ -169,7 +169,7 @@ module Gitlab
         # We raise a custom error so it's easier to catch different changelog
         # related errors. In addition, this ensures the caller of this method
         # doesn't depend on a Parslet specific error class.
-        raise Error.new("Failed to parse the template: #{ex.message}")
+        raise Error, "Failed to parse the template: #{ex.message}"
       end
     end
   end

lib/gitlab/ci/parsers/test/junit.rb

@@ -31,7 +31,7 @@ module Gitlab
           def ensure_test_cases_limited!(total_parsed, limit)
             return unless limit > 0 && total_parsed > limit
 
-            raise JunitParserError.new("number of test cases exceeded the limit of #{limit}")
+            raise JunitParserError, "number of test cases exceeded the limit of #{limit}"
           end
 
           def all_cases(root, parent = nil, &blk)

lib/gitlab/ci/yaml_processor.rb

@@ -141,7 +141,7 @@ module Gitlab
       end
 
       def error!(message)
-        raise ValidationError.new(message)
+        raise ValidationError, message
       end
     end
   end

lib/gitlab/cycle_analytics/summary/base.rb

@@ -11,11 +11,11 @@ module Gitlab
         end
 
         def title
-          raise NotImplementedError.new("Expected #{self.name} to implement title")
+          raise NotImplementedError, "Expected #{self.name} to implement title"
         end
 
         def value
-          raise NotImplementedError.new("Expected #{self.name} to implement value")
+          raise NotImplementedError, "Expected #{self.name} to implement value"
         end
       end
     end

lib/gitlab/database/loose_index_scan_distinct_count.rb

@@ -94,7 +94,7 @@ module Gitlab
         elsif column.is_a?(Arel::Attributes::Attribute)
           column
         else
-          raise ColumnConfigurationError.new("Cannot transform the column: #{column.inspect}, please provide the column name as string")
+          raise ColumnConfigurationError, "Cannot transform the column: #{column.inspect}, please provide the column name as string"
         end
       end
     end

lib/gitlab/encrypted_configuration.rb

@@ -65,7 +65,7 @@ module Gitlab
 
       contents = deserialize(read)
 
-      raise InvalidConfigError.new unless contents.is_a?(Hash)
+      raise InvalidConfigError unless contents.is_a?(Hash)
 
       @config = contents.deep_symbolize_keys
     end
@@ -115,7 +115,7 @@ module Gitlab
     end
 
     def handle_missing_key!
-      raise MissingKeyError.new if @key.nil?
+      raise MissingKeyError if @key.nil?
     end
   end
 end

lib/gitlab/experimentation.rb

@@ -150,7 +150,7 @@ module Gitlab
         elsif subject.respond_to?(:to_s)
           subject.to_s
         else
-          raise ArgumentError.new('Subject must respond to `to_global_id` or `to_s`')
+          raise ArgumentError, 'Subject must respond to `to_global_id` or `to_s`'
         end
       end
     end

lib/gitlab/external_authorization/client.rb

@@ -24,7 +24,7 @@ module Gitlab
         )
         ::Gitlab::ExternalAuthorization::Response.new(response)
       rescue *Gitlab::HTTP::HTTP_ERRORS => e
-        raise ::Gitlab::ExternalAuthorization::RequestFailed.new(e)
+        raise ::Gitlab::ExternalAuthorization::RequestFailed, e
       end
 
       private

lib/gitlab/git/conflict/resolver.rb

@@ -20,9 +20,9 @@ module Gitlab
             gitaly_conflicts_client(@target_repository).list_conflict_files.to_a
           end
         rescue GRPC::FailedPrecondition => e
-          raise Gitlab::Git::Conflict::Resolver::ConflictSideMissing.new(e.message)
+          raise Gitlab::Git::Conflict::Resolver::ConflictSideMissing, e.message
         rescue GRPC::BadStatus => e
-          raise Gitlab::Git::CommandError.new(e)
+          raise Gitlab::Git::CommandError, e
         end
 
         def resolve_conflicts(source_repository, resolution, source_branch:, target_branch:)

lib/gitlab/git/repository.rb

@@ -89,9 +89,9 @@ module Gitlab
       def root_ref
         gitaly_ref_client.default_branch_name
       rescue GRPC::NotFound => e
-        raise NoRepository.new(e.message)
+        raise NoRepository, e.message
       rescue GRPC::Unknown => e
-        raise Gitlab::Git::CommandError.new(e.message)
+        raise Gitlab::Git::CommandError, e.message
       end
 
       def exists?
@@ -348,7 +348,7 @@ module Gitlab
 
         limit = options[:limit]
         if limit == 0 || !limit.is_a?(Integer)
-          raise ArgumentError.new("invalid Repository#log limit: #{limit.inspect}")
+          raise ArgumentError, "invalid Repository#log limit: #{limit.inspect}"
         end
 
         wrapped_gitaly_errors do
@@ -414,7 +414,7 @@ module Gitlab
             end
           end
       rescue ArgumentError => e
-        raise Gitlab::Git::Repository::GitError.new(e)
+        raise Gitlab::Git::Repository::GitError, e
       end
 
       # Returns the SHA of the most recent common ancestor of +from+ and +to+
@@ -836,7 +836,7 @@ module Gitlab
       def fsck
         msg, status = gitaly_repository_client.fsck
 
-        raise GitError.new("Could not fsck repository: #{msg}") unless status == 0
+        raise GitError, "Could not fsck repository: #{msg}" unless status == 0
       end
 
       def create_from_bundle(bundle_path)

lib/gitlab/git/rugged_impl/repository.rb

@@ -31,7 +31,7 @@ module Gitlab
         def rugged
           @rugged ||= ::Rugged::Repository.new(path, alternates: alternate_object_directories)
         rescue ::Rugged::RepositoryError, ::Rugged::OSError
-          raise ::Gitlab::Git::Repository::NoRepository.new('no repository for such path')
+          raise ::Gitlab::Git::Repository::NoRepository, 'no repository for such path'
         end
 
         def cleanup

lib/gitlab/git/wraps_gitaly_errors.rb

@@ -6,13 +6,13 @@ module Gitlab
       def wrapped_gitaly_errors(&block)
         yield block
       rescue GRPC::NotFound => e
-        raise Gitlab::Git::Repository::NoRepository.new(e)
+        raise Gitlab::Git::Repository::NoRepository, e
       rescue GRPC::InvalidArgument => e
-        raise ArgumentError.new(e)
+        raise ArgumentError, e
       rescue GRPC::DeadlineExceeded => e
-        raise Gitlab::Git::CommandTimedOut.new(e)
+        raise Gitlab::Git::CommandTimedOut, e
       rescue GRPC::BadStatus => e
-        raise Gitlab::Git::CommandError.new(e)
+        raise Gitlab::Git::CommandError, e
       end
     end
   end

lib/gitlab/gitaly_client/operation_service.rb

@@ -59,7 +59,7 @@ module Gitlab
                                      :user_create_branch, request, timeout: GitalyClient.long_timeout)
 
         if response.pre_receive_error.present?
-          raise Gitlab::Git::PreReceiveError.new(response.pre_receive_error)
+          raise Gitlab::Git::PreReceiveError, response.pre_receive_error
         end
 
         branch = response.branch
@@ -159,7 +159,7 @@ module Gitlab
 
         branch_update = second_response.branch_update
         return if branch_update.nil?
-        raise Gitlab::Git::CommitError.new('failed to apply merge to branch') unless branch_update.commit_id.present?
+        raise Gitlab::Git::CommitError, 'failed to apply merge to branch' unless branch_update.commit_id.present?
 
         Gitlab::Git::OperationService::BranchUpdate.from_gitaly(branch_update)
       ensure

lib/gitlab/gitaly_client/ref_service.rb

@@ -292,7 +292,7 @@ module Gitlab
       end
 
       def invalid_ref!(message)
-        raise Gitlab::Git::Repository::InvalidRef.new(message)
+        raise Gitlab::Git::Repository::InvalidRef, message
       end
     end
   end

lib/gitlab/gitaly_client/repository_service.rb

@@ -319,7 +319,7 @@ module Gitlab
         response = GitalyClient.call(@storage, :repository_service, :calculate_checksum, request, timeout: GitalyClient.fast_timeout)
         response.checksum.presence
       rescue GRPC::DataLoss => e
-        raise Gitlab::Git::Repository::InvalidRepository.new(e)
+        raise Gitlab::Git::Repository::InvalidRepository, e
       end
 
       def raw_changes_between(from, to)

lib/gitlab/golang.rb

@@ -69,13 +69,13 @@ module Gitlab
       # Error messages are based on the responses of proxy.golang.org
 
       # Verify that the SHA fragment references a commit
-      raise ArgumentError.new 'invalid pseudo-version: unknown commit' unless commit
+      raise ArgumentError, 'invalid pseudo-version: unknown commit' unless commit
 
       # Require the SHA fragment to be 12 characters long
-      raise ArgumentError.new 'invalid pseudo-version: revision is shorter than canonical' unless version.commit_id.length == 12
+      raise ArgumentError, 'invalid pseudo-version: revision is shorter than canonical' unless version.commit_id.length == 12
 
       # Require the timestamp to match that of the commit
-      raise ArgumentError.new 'invalid pseudo-version: does not match version-control timestamp' unless commit.committed_date.strftime('%Y%m%d%H%M%S') == version.timestamp
+      raise ArgumentError, 'invalid pseudo-version: does not match version-control timestamp' unless commit.committed_date.strftime('%Y%m%d%H%M%S') == version.timestamp
 
       commit
     end