Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
d4bfc024
Commit
d4bfc024
authored
Jul 12, 2019
by
Etienne Baqué
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Returning more accurate value in AuditDetails when a custom message is provided
parent
9de0692a
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
1 addition
and
13 deletions
+1
-13
ee/lib/audit/details.rb
ee/lib/audit/details.rb
+1
-1
ee/spec/helpers/audit_events_helper_spec.rb
ee/spec/helpers/audit_events_helper_spec.rb
+0
-12
No files found.
ee/lib/audit/details.rb
View file @
d4bfc024
...
...
@@ -33,7 +33,7 @@ module Audit
when
:failed_login
"Failed to login with
#{
oath_label
}
authentication"
when
:custom_message
target_
detail_value
detail_value
else
text_for_change
(
target_detail_value
)
end
...
...
ee/spec/helpers/audit_events_helper_spec.rb
View file @
d4bfc024
...
...
@@ -39,18 +39,6 @@ describe AuditEventsHelper do
is_expected
.
to
eq
(
custom_message
)
end
end
context
'when the target_type is not Operations::FeatureFlag'
do
let
(
:target_type
)
{
'User'
}
context
'when custom message contains "_"'
do
let
(
:custom_message
)
{
"message_with_spaces"
}
it
'replaces them with spaces'
do
expect
(
subject
).
to
eq
(
"message with spaces"
)
end
end
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment