Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
d60db108
Commit
d60db108
authored
Jul 21, 2020
by
Marcel van Remmerden
Committed by
Paul Slaughter
Jul 21, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove designs hover border
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/37375
parent
60a08fe7
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
7 additions
and
12 deletions
+7
-12
app/assets/javascripts/design_management_new/pages/index.vue
app/assets/javascripts/design_management_new/pages/index.vue
+0
-1
app/assets/stylesheets/components/design_management/design_list_item.scss
...sheets/components/design_management/design_list_item.scss
+0
-9
changelogs/unreleased/mvanremmerden-remove-designs-hover-border.yml
.../unreleased/mvanremmerden-remove-designs-hover-border.yml
+5
-0
spec/frontend/design_management_new/pages/__snapshots__/index_spec.js.snap
...ign_management_new/pages/__snapshots__/index_spec.js.snap
+2
-2
No files found.
app/assets/javascripts/design_management_new/pages/index.vue
View file @
d60db108
...
@@ -267,7 +267,6 @@ export default {
...
@@ -267,7 +267,6 @@ export default {
<div
<div
data-testid=
"designs-root"
data-testid=
"designs-root"
class=
"gl-mt-5"
class=
"gl-mt-5"
:class=
"
{ 'designs-root': !isDesignListEmpty }"
@
mouseenter=
"toggleOnPasteListener"
@
mouseenter=
"toggleOnPasteListener"
@
mouseleave=
"toggleOffPasteListener"
@
mouseleave=
"toggleOffPasteListener"
>
>
...
...
app/assets/stylesheets/components/design_management/design_list_item.scss
View file @
d60db108
.designs-root
{
border
:
2px
dashed
transparent
;
transition
:
border
$gl-transition-duration-medium
$general-hover-transition-curve
;
&
:hover
{
border-color
:
$gray-100
;
}
}
.design-list-item
{
.design-list-item
{
height
:
280px
;
height
:
280px
;
text-decoration
:
none
;
text-decoration
:
none
;
...
...
changelogs/unreleased/mvanremmerden-remove-designs-hover-border.yml
0 → 100644
View file @
d60db108
---
title
:
Remove dashed border on designs hover
merge_request
:
37375
author
:
type
:
fixed
spec/frontend/design_management_new/pages/__snapshots__/index_spec.js.snap
View file @
d60db108
...
@@ -2,7 +2,7 @@
...
@@ -2,7 +2,7 @@
exports[`Design management index page designs does not render toolbar when there is no permission 1`] = `
exports[`Design management index page designs does not render toolbar when there is no permission 1`] = `
<div
<div
class="gl-mt-5
designs-root
"
class="gl-mt-5"
data-testid="designs-root"
data-testid="designs-root"
>
>
<!---->
<!---->
...
@@ -87,7 +87,7 @@ exports[`Design management index page designs does not render toolbar when there
...
@@ -87,7 +87,7 @@ exports[`Design management index page designs does not render toolbar when there
exports[`Design management index page designs renders designs list and header with upload button 1`] = `
exports[`Design management index page designs renders designs list and header with upload button 1`] = `
<div
<div
class="gl-mt-5
designs-root
"
class="gl-mt-5"
data-testid="designs-root"
data-testid="designs-root"
>
>
<header
<header
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment