Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
d673373a
Commit
d673373a
authored
Feb 21, 2022
by
Sam Goldstein
Committed by
Alex Ives
Mar 08, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Draft DB review guidelines for data volume and access patterns
parent
0cc6a229
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
5 additions
and
0 deletions
+5
-0
doc/development/database_review.md
doc/development/database_review.md
+5
-0
No files found.
doc/development/database_review.md
View file @
d673373a
...
...
@@ -261,3 +261,8 @@ Include in the MR description:
to queries (changing the query, schema or adding indexes and similar)
-
General guideline is for queries to come in below
[
100ms execution time
](
query_performance.md#timing-guidelines-for-queries
)
-
Avoid N+1 problems and minimize the
[
query count
](
merge_request_performance_guidelines.md#query-counts
)
.
-
Review anticipated data volume and access patterns
-
If new tables or columns are being added:
-
What is the growth for these tables? What is this assumption based on?
-
What is the anticipated access pattern for these tables? Are they read-heavy or write-heavy?
-
Based on the anticipated data volume and access patterns, does the new table pose an availability risk to GitLab.com or self-managed instances?
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment