Upgrade GitLab UI

- Upgraded GitLab UI to v9.16.0
- Migrated GlPagination usage to account for the built-in chevron icon
- Updated snapshots affected by changes in GlLoadingIcon
- Updated snapshots and tests affected by changes in GlButton

app/assets/javascripts/vue_shared/components/pagination/constants.js

@@ -3,8 +3,8 @@ import { s__ } from '~/locale';
 export const PAGINATION_UI_BUTTON_LIMIT = 4;
 export const UI_LIMIT = 6;
 export const SPREAD = '...';
-export const PREV = s__('Pagination|‹ Prev');
-export const NEXT = s__('Pagination|Next ›');
+export const PREV = s__('Pagination|Prev');
+export const NEXT = s__('Pagination|Next');
 export const FIRST = s__('Pagination|« First');
 export const LAST = s__('Pagination|Last »');
 export const LABEL_FIRST_PAGE = s__('Pagination|Go to first page');

changelogs/unreleased/upgrade-gitlab-ui.yml

+---
+title: Remove special chars from previous and next items in pagination
+merge_request: 25891
+author:
+type: other

ee/spec/frontend/analytics/cycle_analytics/components/__snapshots__/custom_stage_form_spec.js.snap

 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
 exports[`CustomStageForm Editing a custom stage isSavingCustomStage=true displays a loading icon 1`] = `
-"<button disabled=\\"disabled\\" type=\\"button\\" class=\\"js-save-stage btn btn-success\\"><span class=\\"gl-spinner-container\\"><span aria-label=\\"Loading\\" aria-hidden=\\"true\\" class=\\"gl-spinner gl-spinner-orange gl-spinner-sm\\"></span></span>
+"<button disabled=\\"disabled\\" type=\\"button\\" class=\\"js-save-stage btn btn-success\\"><span class=\\"gl-spinner-container\\"><span aria-label=\\"Loading\\" aria-hidden=\\"true\\" class=\\"align-text-bottom gl-spinner gl-spinner-orange gl-spinner-sm\\"></span></span>
   Update stage
 </button>"
 `;
@@ -53,7 +53,7 @@ exports[`CustomStageForm Start event with events selects events with canBeStartE
 `;
 
 exports[`CustomStageForm isSavingCustomStage=true displays a loading icon 1`] = `
-"<button disabled=\\"disabled\\" type=\\"button\\" class=\\"js-save-stage btn btn-success\\"><span class=\\"gl-spinner-container\\"><span aria-label=\\"Loading\\" aria-hidden=\\"true\\" class=\\"gl-spinner gl-spinner-orange gl-spinner-sm\\"></span></span>
+"<button disabled=\\"disabled\\" type=\\"button\\" class=\\"js-save-stage btn btn-success\\"><span class=\\"gl-spinner-container\\"><span aria-label=\\"Loading\\" aria-hidden=\\"true\\" class=\\"align-text-bottom gl-spinner gl-spinner-orange gl-spinner-sm\\"></span></span>
   Add stage
 </button>"
 `;

ee/spec/frontend/clusters/components/environments_spec.js

@@ -29,7 +29,7 @@ describe('Environments', () => {
   it('renders an empty state if no deployments are found', () => {
     const emptyState = wrapper.find(GlEmptyState);
     const emptyStateText =
-      'No deployments found Ensure your environment is part of the deploy stage of your CI pipeline to track deployments to your cluster. Learn more about deploying to a cluster';
+      'No deployments found Ensure your environment is part of the deploy stage of your CI pipeline to track deployments to your cluster.  Learn more about deploying to a cluster';
 
     expect(emptyState.exists()).toBe(true);
     expect(emptyState.text()).toEqual(emptyStateText);

ee/spec/frontend/packages/details/components/__snapshots__/code_instruction_spec.js.snap

@@ -30,6 +30,8 @@ exports[`Package code instruction single line to match the default snapshot 1`]
       title="Copy npm install command"
       type="button"
     >
+      <!---->
+       
       <svg
         class="gl-icon s16"
       >

locale/gitlab.pot

@@ -13655,18 +13655,12 @@ msgstr ""
 msgid "Pagination|Next"
 msgstr ""
 
-msgid "Pagination|Next ›"
-msgstr ""
-
 msgid "Pagination|Prev"
 msgstr ""
 
 msgid "Pagination|« First"
 msgstr ""
 
-msgid "Pagination|‹ Prev"
-msgstr ""
-
 msgid "Parameter"
 msgstr ""
 

package.json

@@ -40,8 +40,8 @@
     "@babel/plugin-syntax-import-meta": "^7.2.0",
     "@babel/preset-env": "^7.6.2",
     "@gitlab/at.js": "^1.5.5",
-    "@gitlab/svgs": "^1.99.0",
-    "@gitlab/ui": "^9.11.2",
+    "@gitlab/svgs": "^1.101.0",
+    "@gitlab/ui": "^9.16.0",
     "@gitlab/visual-review-tools": "1.5.1",
     "@sentry/browser": "^5.10.2",
     "@sourcegraph/code-host-integration": "0.0.30",

spec/frontend/registry/list/components/__snapshots__/project_empty_state_spec.js.snap

@@ -89,6 +89,8 @@ exports[`Registry Project Empty state to match the default snapshot 1`] = `
               title="Copy login command"
               type="button"
             >
+              <!---->
+               
               <svg
                 class="gl-icon s16"
               >
@@ -126,6 +128,8 @@ exports[`Registry Project Empty state to match the default snapshot 1`] = `
               title="Copy build command"
               type="button"
             >
+              <!---->
+               
               <svg
                 class="gl-icon s16"
               >
@@ -155,6 +159,8 @@ exports[`Registry Project Empty state to match the default snapshot 1`] = `
               title="Copy push command"
               type="button"
             >
+              <!---->
+               
               <svg
                 class="gl-icon s16"
               >

spec/frontend/vue_shared/components/__snapshots__/expand_button_spec.js.snap

@@ -8,6 +8,8 @@ exports[`Expand button on click when short text is provided renders button after
     style="display: none;"
     type="button"
   >
+    <!---->
+     
     <svg
       aria-hidden="true"
       class="s12 ic-ellipsis_h"
@@ -32,6 +34,8 @@ exports[`Expand button on click when short text is provided renders button after
     style=""
     type="button"
   >
+    <!---->
+     
     <svg
       aria-hidden="true"
       class="s12 ic-ellipsis_h"
@@ -51,6 +55,8 @@ exports[`Expand button when short text is provided renders button before text 1`
     class="btn js-text-expander-prepend text-expander btn-blank btn-secondary btn-md"
     type="button"
   >
+    <!---->
+     
     <svg
       aria-hidden="true"
       class="s12 ic-ellipsis_h"
@@ -75,6 +81,8 @@ exports[`Expand button when short text is provided renders button before text 1`
     style="display: none;"
     type="button"
   >
+    <!---->
+     
     <svg
       aria-hidden="true"
       class="s12 ic-ellipsis_h"

yarn.lock

@@ -740,15 +740,15 @@
   dependencies:
     vue-eslint-parser "^7.0.0"
 
-"@gitlab/svgs@^1.99.0":
-  version "1.99.0"
-  resolved "https://registry.yarnpkg.com/@gitlab/svgs/-/svgs-1.99.0.tgz#bcf971c3a14920218e86da71ca115244b23a4a3f"
-  integrity sha512-bxYFxnmuoWPBU9isL3/CYFlr+k2YWU47Pq0vfmSmL7uLnb/vYymfZZF5p3erlZ62WGwuT3kp4GnuoZBMfmannA==
-
-"@gitlab/ui@^9.11.2":
-  version "9.11.2"
-  resolved "https://registry.yarnpkg.com/@gitlab/ui/-/ui-9.11.2.tgz#ffb58bb10c6a8cd503a622946ed78512e9c18c6d"
-  integrity sha512-9acsjQ9+hSaAIGpiARNF4XfQUhulWiausns9JUTrN9XEQpa1o/EsDYqwP0HfSOMZ8JhnjSI2NGYVf+LIH5oudg==
+"@gitlab/svgs@^1.101.0":
+  version "1.101.0"
+  resolved "https://registry.yarnpkg.com/@gitlab/svgs/-/svgs-1.101.0.tgz#5440ada1774758e42fd67212d495a29523dd0d5e"
+  integrity sha512-GE6wRn0UqA5f0pmX5wL/vTgUnAgZEdTIDam+OTMuMxf5a1jfxc1KlSLudgZbS3O/W79jN4uMkTdZ7X8gEzAChw==
+
+"@gitlab/ui@^9.16.0":
+  version "9.16.0"
+  resolved "https://registry.yarnpkg.com/@gitlab/ui/-/ui-9.16.0.tgz#ac66b55cffdfd9ac2df2abddb11445edc3494732"
+  integrity sha512-9PbFgqNxIAGn1LyIcnlqQuNGAiBT/fqTx8vPdaDQkdScFZksZOBwiIhpxnRk9UFABC3h+0TNeHgVigD7TKGqJw==
   dependencies:
     "@babel/standalone" "^7.0.0"
     "@gitlab/vue-toasted" "^1.3.0"