Commit d8f3c344 authored by Jonathan Schafer's avatar Jonathan Schafer

Fixes from code review

parent 9a892ebd
...@@ -45,7 +45,7 @@ class Projects::VulnerabilityFeedbackController < Projects::ApplicationControlle ...@@ -45,7 +45,7 @@ class Projects::VulnerabilityFeedbackController < Projects::ApplicationControlle
end end
def update def update
service = VulnerabilityFeedbackModule::UpdateService.new(project, current_user, vulnerability_feedback_params ) service = VulnerabilityFeedbackModule::UpdateService.new(project, current_user, vulnerability_feedback_params)
result = service.execute(vulnerability_feedback) result = service.execute(vulnerability_feedback)
if result[:status] == :success if result[:status] == :success
......
...@@ -176,7 +176,7 @@ RSpec.describe Projects::VulnerabilityFeedbackController do ...@@ -176,7 +176,7 @@ RSpec.describe Projects::VulnerabilityFeedbackController do
stub_licensed_features(security_dashboard: true) stub_licensed_features(security_dashboard: true)
end end
context 'when id of a vunlnerability is provided' do context 'when id of a vulnerability is provided' do
let!(:vulnerability) { create(:vulnerability, :with_findings, project: project) } let!(:vulnerability) { create(:vulnerability, :with_findings, project: project) }
subject { create_feedback user: user, project: project, params: create_params.deep_merge(feedback_type: 'issue', vulnerability_data: { vulnerability_id: vulnerability.id }) } subject { create_feedback user: user, project: project, params: create_params.deep_merge(feedback_type: 'issue', vulnerability_data: { vulnerability_id: vulnerability.id }) }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment