Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
d8f3c344
Commit
d8f3c344
authored
Dec 11, 2020
by
Jonathan Schafer
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixes from code review
parent
9a892ebd
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
2 deletions
+2
-2
ee/app/controllers/projects/vulnerability_feedback_controller.rb
...controllers/projects/vulnerability_feedback_controller.rb
+1
-1
ee/spec/controllers/projects/vulnerability_feedback_controller_spec.rb
...ollers/projects/vulnerability_feedback_controller_spec.rb
+1
-1
No files found.
ee/app/controllers/projects/vulnerability_feedback_controller.rb
View file @
d8f3c344
...
@@ -45,7 +45,7 @@ class Projects::VulnerabilityFeedbackController < Projects::ApplicationControlle
...
@@ -45,7 +45,7 @@ class Projects::VulnerabilityFeedbackController < Projects::ApplicationControlle
end
end
def
update
def
update
service
=
VulnerabilityFeedbackModule
::
UpdateService
.
new
(
project
,
current_user
,
vulnerability_feedback_params
)
service
=
VulnerabilityFeedbackModule
::
UpdateService
.
new
(
project
,
current_user
,
vulnerability_feedback_params
)
result
=
service
.
execute
(
vulnerability_feedback
)
result
=
service
.
execute
(
vulnerability_feedback
)
if
result
[
:status
]
==
:success
if
result
[
:status
]
==
:success
...
...
ee/spec/controllers/projects/vulnerability_feedback_controller_spec.rb
View file @
d8f3c344
...
@@ -176,7 +176,7 @@ RSpec.describe Projects::VulnerabilityFeedbackController do
...
@@ -176,7 +176,7 @@ RSpec.describe Projects::VulnerabilityFeedbackController do
stub_licensed_features
(
security_dashboard:
true
)
stub_licensed_features
(
security_dashboard:
true
)
end
end
context
'when id of a vu
n
lnerability is provided'
do
context
'when id of a vulnerability is provided'
do
let!
(
:vulnerability
)
{
create
(
:vulnerability
,
:with_findings
,
project:
project
)
}
let!
(
:vulnerability
)
{
create
(
:vulnerability
,
:with_findings
,
project:
project
)
}
subject
{
create_feedback
user:
user
,
project:
project
,
params:
create_params
.
deep_merge
(
feedback_type:
'issue'
,
vulnerability_data:
{
vulnerability_id:
vulnerability
.
id
})
}
subject
{
create_feedback
user:
user
,
project:
project
,
params:
create_params
.
deep_merge
(
feedback_type:
'issue'
,
vulnerability_data:
{
vulnerability_id:
vulnerability
.
id
})
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment