Merge branch 'aa-record-conversion-for-3-experiment' into 'master'

Improve Tracking for 4 experiments in onboarding flow

See merge request gitlab-org/gitlab!53583

ee/app/controllers/registrations/groups_controller.rb

@@ -30,6 +30,11 @@ module Registrations
         record_experiment_user(:remove_known_trial_form_fields, namespace_id: @group.id)
         record_experiment_user(:trimmed_skip_trial_copy, namespace_id: @group.id)
         record_experiment_user(:trial_registration_with_social_signin, namespace_id: @group.id)
+        record_experiment_user(:trial_onboarding_issues, namespace_id: @group.id)
+        record_experiment_conversion_event(:remove_known_trial_form_fields)
+        record_experiment_conversion_event(:trimmed_skip_trial_copy)
+        record_experiment_conversion_event(:trial_registration_with_social_signin)
+        record_experiment_conversion_event(:trial_onboarding_issues)
 
         url_params[:trial_onboarding_flow] = true
       else

ee/app/controllers/registrations/projects_controller.rb

@@ -27,6 +27,7 @@ module Registrations
           }
 
           record_experiment_user(:trial_onboarding_issues, trial_onboarding_context)
+          record_experiment_conversion_event(:trial_onboarding_issues)
           redirect_to trial_getting_started_users_sign_up_welcome_path(learn_gitlab_project_id: learn_gitlab_project.id)
         else
           redirect_to users_sign_up_experience_level_path(namespace_path: @project.namespace, trial_onboarding_flow: params[:trial_onboarding_flow])

ee/app/controllers/trials_controller.rb

@@ -44,9 +44,11 @@ class TrialsController < ApplicationController
       record_experiment_user(:remove_known_trial_form_fields, namespace_id: @namespace.id)
       record_experiment_user(:trimmed_skip_trial_copy, namespace_id: @namespace.id)
       record_experiment_user(:trial_registration_with_social_signin, namespace_id: @namespace.id)
+      record_experiment_user(:trial_onboarding_issues, namespace_id: @namespace.id)
       record_experiment_conversion_event(:remove_known_trial_form_fields)
       record_experiment_conversion_event(:trimmed_skip_trial_copy)
       record_experiment_conversion_event(:trial_registration_with_social_signin)
+      record_experiment_conversion_event(:trial_onboarding_issues)
 
       redirect_to group_url(@namespace, { trial: true })
     else

ee/spec/controllers/registrations/groups_controller_spec.rb

@@ -236,6 +236,11 @@ RSpec.describe Registrations::GroupsController do
           expect(controller).to receive(:record_experiment_user).with(:remove_known_trial_form_fields, namespace_id: group.id)
           expect(controller).to receive(:record_experiment_user).with(:trimmed_skip_trial_copy, namespace_id: group.id)
           expect(controller).to receive(:record_experiment_user).with(:trial_registration_with_social_signin, namespace_id: group.id)
+          expect(controller).to receive(:record_experiment_user).with(:trial_onboarding_issues, namespace_id: group.id)
+          expect(controller).to receive(:record_experiment_conversion_event).with(:remove_known_trial_form_fields)
+          expect(controller).to receive(:record_experiment_conversion_event).with(:trimmed_skip_trial_copy)
+          expect(controller).to receive(:record_experiment_conversion_event).with(:trial_registration_with_social_signin)
+          expect(controller).to receive(:record_experiment_conversion_event).with(:trial_onboarding_issues)
 
           is_expected.to redirect_to(new_users_sign_up_project_path(namespace_id: group.id, trial: false, trial_onboarding_flow: true))
         end

ee/spec/controllers/registrations/projects_controller_spec.rb

@@ -99,6 +99,7 @@ RSpec.describe Registrations::ProjectsController do
             expect(service).to receive(:execute).and_return(project)
           end
           expect(controller).to receive(:record_experiment_user).with(:trial_onboarding_issues, trial_onboarding_context)
+          expect(controller).to receive(:record_experiment_conversion_event).with(:trial_onboarding_issues)
           expect(subject).to redirect_to(trial_getting_started_users_sign_up_welcome_path(learn_gitlab_project_id: project.id))
         end
       end

ee/spec/controllers/trials_controller_spec.rb

@@ -111,6 +111,7 @@ RSpec.describe TrialsController do
 
           it 'records trial_onboarding_issues experiment users and redirects to onboarding' do
             expect(controller).to receive(:record_experiment_user).with(:trial_onboarding_issues)
+
             is_expected.to redirect_to(new_users_sign_up_group_path(glm_source: 'about.gitlab.com', trial_onboarding_flow: true))
           end
         end
@@ -229,9 +230,11 @@ RSpec.describe TrialsController do
         expect(controller).to receive(:record_experiment_user).with(:remove_known_trial_form_fields, namespace_id: namespace.id)
         expect(controller).to receive(:record_experiment_user).with(:trimmed_skip_trial_copy, namespace_id: namespace.id)
         expect(controller).to receive(:record_experiment_user).with(:trial_registration_with_social_signin, namespace_id: namespace.id)
+        expect(controller).to receive(:record_experiment_user).with(:trial_onboarding_issues, namespace_id: namespace.id)
         expect(controller).to receive(:record_experiment_conversion_event).with(:remove_known_trial_form_fields)
         expect(controller).to receive(:record_experiment_conversion_event).with(:trimmed_skip_trial_copy)
         expect(controller).to receive(:record_experiment_conversion_event).with(:trial_registration_with_social_signin)
+        expect(controller).to receive(:record_experiment_conversion_event).with(:trial_onboarding_issues)
 
         subject
       end