Merge branch 'minor-improvements-on-manage-e2e-tests' into 'master'

Minor improvements on e2e tests from the DevOps Manage stage

See merge request gitlab-org/gitlab!25898

qa/qa/specs/features/browser_ui/1_manage/project/view_project_activity_spec.rb

@@ -6,12 +6,11 @@ module QA
       it 'user creates an event in the activity page upon Git push' do
         Flow::Login.sign_in
 
-        project_push = Resource::Repository::ProjectPush.fabricate! do |push|
+        Resource::Repository::ProjectPush.fabricate! do |push|
           push.file_name = 'README.md'
           push.file_content = '# This is a test project'
           push.commit_message = 'Add README.md'
-        end
-        project_push.project.visit!
+        end.project.visit!
 
         Page::Project::Menu.perform(&:click_activity)
         Page::Project::Activity.perform(&:click_push_events)

qa/qa/specs/features/ee/browser_ui/1_manage/insights/default_insights_spec.rb

@@ -20,8 +20,7 @@ module QA
       before do
         Flow::Login.sign_in
 
-        group = Resource::Group.fabricate_via_api!
-        group.visit!
+        Resource::Group.fabricate_via_api!.visit!
 
         Page::Group::Menu.perform(&:click_group_insights_link)
       end

qa/qa/specs/features/ee/browser_ui/1_manage/project/project_templates_spec.rb

@@ -81,8 +81,7 @@ module QA
             expect(templates.current_custom_project_template).to include @template_container_group_name
           end
 
-          group = Resource::Group.fabricate_via_api!
-          group.visit!
+          Resource::Group.fabricate_via_api!.visit!
 
           Page::Group::Show.perform(&:go_to_new_project)