Merge branch '243445-remove-stale-packages-_legacy_package_list-html-haml' into 'master'

Remove stale packages/_legacy_package_list.html.haml

Closes #243445

See merge request gitlab-org/gitlab!40947

app/assets/javascripts/packages/shared/components/package_list_row.vue

@@ -61,7 +61,7 @@ export default {
 </script>
 
 <template>
-  <list-item data-qa-selector="packages-row">
+  <list-item data-qa-selector="package_row">
     <template #left-primary>
       <div class="gl-display-flex gl-align-items-center gl-mr-3">
         <gl-link :href="packageLink" class="gl-text-body" data-qa-selector="package_link">

app/views/projects/packages/packages/_legacy_package_list.html.haml

-- sort_value = @sort
-- sort_title = packages_sort_option_title(sort_value)
-
-- if @packages.any?
-  .d-flex.justify-content-end
-    .dropdown.inline.gl-mt-3.gl-mb-3.package-sort-dropdown
-      .btn-group{ role: 'group' }
-        .btn-group{ role: 'group' }
-          %button.dropdown-menu-toggle{ type: 'button', data: { toggle: 'dropdown', display: 'static' }, class: 'btn btn-default' }
-            = sort_title
-            = icon('chevron-down')
-          %ul.dropdown-menu.dropdown-menu-right.dropdown-menu-selectable.dropdown-menu-sort
-            %li
-              = sortable_item(sort_title_created_date,      package_sort_path(sort: sort_value_recently_created),  sort_title)
-              = sortable_item(sort_title_name,              package_sort_path(sort: sort_value_name_desc),         sort_title)
-              = sortable_item(sort_title_version,           package_sort_path(sort: sort_value_version_desc),      sort_title)
-              = sortable_item(sort_title_type,              package_sort_path(sort: sort_value_type_desc),         sort_title)
-        = packages_sort_direction_button(sort_value)
-
-  .table-holder
-    .gl-responsive-table-row.table-row-header.bg-secondary-50.px-2.border-top{ role: 'row' }
-      .table-section.section-30{ role: 'rowheader' }
-        = _('Name')
-      .table-section.section-20{ role: 'rowheader' }
-        = _('Version')
-      .table-section.section-20{ role: 'rowheader' }
-        = _('Type')
-      .table-section.section-20{ role: 'rowheader' }
-        = _('Created')
-      .table-section.section-10{ role: 'rowheader' }
-    - @packages.each do |package|
-      .gl-responsive-table-row.package-row.px-2{ data: { qa_selector: "package_row" } }
-        .table-section.section-30
-          .table-mobile-header{ role: "rowheader" }= _("Name")
-          .table-mobile-content.flex-truncate-parent
-            = link_to package.name, project_package_path(@project, package), class: 'flex-truncate-child', data: { qa_selector: "package_link" }
-        .table-section.section-20
-          .table-mobile-header{ role: "rowheader" }= _("Version")
-          .table-mobile-content
-            = package.version
-        .table-section.section-20
-          .table-mobile-header{ role: "rowheader" }= _("Type")
-          .table-mobile-content
-            = package.package_type
-        .table-section.section-20
-          .table-mobile-header{ role: "rowheader" }= _("Created")
-          .table-mobile-content
-            = time_ago_with_tooltip(package.created_at)
-        .table-section.section-10
-          .table-mobile-header{ role: "rowheader" }
-          .table-mobile-content
-            - if can_destroy_package
-              .float-right
-                = link_to project_package_path(@project, package), method: :delete, data: { confirm: _("Are you sure?") }, class: "btn btn-grouped btn-remove", title: _('Delete Package') do
-                  = sprite_icon('remove')
-    = paginate @packages, theme: "gitlab"
-- else
-  .row.empty-state
-    .col-12
-      = render 'shared/packages/no_packages'

locale/gitlab.pot

@@ -8040,9 +8040,6 @@ msgstr ""
 msgid "Delete Comment"
 msgstr ""
 
-msgid "Delete Package"
-msgstr ""
-
 msgid "Delete Snippet"
 msgstr ""
 

qa/qa/page/project/packages/index.rb

@@ -5,7 +5,7 @@ module QA
     module Project
       module Packages
         class Index < QA::Page::Base
-          view 'app/views/projects/packages/packages/_legacy_package_list.html.haml' do
+          view 'app/assets/javascripts/packages/shared/components/package_list_row.vue' do
             element :package_row
             element :package_link
           end

spec/frontend/packages/shared/components/__snapshots__/package_list_row_spec.js.snap

@@ -3,7 +3,7 @@
 exports[`packages_list_row renders 1`] = `
 <div
   class="gl-display-flex gl-flex-direction-column gl-border-b-solid gl-border-t-solid gl-border-t-1 gl-border-b-1 gl-border-t-transparent gl-border-b-gray-100"
-  data-qa-selector="packages-row"
+  data-qa-selector="package_row"
 >
   <div
     class="gl-display-flex gl-align-items-center gl-py-5"

spec/support/shared_examples/features/packages_shared_examples.rb

@@ -14,7 +14,7 @@ RSpec.shared_examples 'packages list' do |check_project_name: false|
   end
 
   def package_table_row(index)
-    page.all("#{packages_table_selector} > [data-qa-selector=\"packages-row\"]")[index].text
+    page.all("#{packages_table_selector} > [data-qa-selector=\"package_row\"]")[index].text
   end
 end