Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
dc2454e3
Commit
dc2454e3
authored
Oct 08, 2019
by
Alper Akgun
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Snowplow backend tracking self describing events
parent
e8a6ad80
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
85 additions
and
27 deletions
+85
-27
lib/gitlab/tracking.rb
lib/gitlab/tracking.rb
+11
-0
spec/lib/gitlab/tracking_spec.rb
spec/lib/gitlab/tracking_spec.rb
+74
-27
No files found.
lib/gitlab/tracking.rb
View file @
dc2454e3
...
...
@@ -15,6 +15,10 @@ module Gitlab
category
=
args
.
delete
(
:category
)
||
self
.
class
.
name
Gitlab
::
Tracking
.
event
(
category
,
action
.
to_s
,
**
args
)
end
def
track_self_describing_event
(
schema_url
,
event_data_json
,
**
args
)
Gitlab
::
Tracking
.
self_describing_event
(
schema_url
,
event_data_json
,
**
args
)
end
end
class
<<
self
...
...
@@ -28,6 +32,13 @@ module Gitlab
snowplow
.
track_struct_event
(
category
,
action
,
label
,
property
,
value
,
context
,
Time
.
now
.
to_i
)
end
def
self_describing_event
(
schema_url
,
event_data_json
,
context:
nil
)
return
unless
enabled?
event_json
=
SnowplowTracker
::
SelfDescribingJson
.
new
(
schema_url
,
event_data_json
)
snowplow
.
track_self_describing_event
(
event_json
,
context
,
Time
.
now
.
to_i
)
end
def
snowplow_options
(
group
)
additional_features
=
Feature
.
enabled?
(
:additional_snowplow_tracking
,
group
)
{
...
...
spec/lib/gitlab/tracking_spec.rb
View file @
dc2454e3
...
...
@@ -12,10 +12,8 @@ describe Gitlab::Tracking do
end
describe
'.snowplow_options'
do
subject
(
&
method
(
:described_class
))
it
'returns useful client options'
do
expect
(
subject
.
snowplow_options
(
nil
)).
to
eq
(
expect
(
described_class
.
snowplow_options
(
nil
)).
to
eq
(
namespace:
'gl'
,
hostname:
'gitfoo.com'
,
cookieDomain:
'.gitfoo.com'
,
...
...
@@ -32,23 +30,35 @@ describe Gitlab::Tracking do
'_group_'
).
and_return
(
false
)
expect
(
subject
.
snowplow_options
(
'_group_'
)).
to
include
(
expect
(
described_class
.
snowplow_options
(
'_group_'
)).
to
include
(
formTracking:
false
,
linkClickTracking:
false
)
end
end
describe
'.event'
do
subject
(
&
method
(
:described_class
))
describe
'tracking events'
do
shared_examples
'events not tracked'
do
it
'does not track events'
do
stub_application_setting
(
snowplow_enabled:
false
)
expect
(
SnowplowTracker
::
AsyncEmitter
).
not_to
receive
(
:new
)
expect
(
SnowplowTracker
::
Tracker
).
not_to
receive
(
:new
)
track_event
end
end
around
do
|
example
|
Timecop
.
freeze
(
timestamp
)
{
example
.
run
}
end
it
'can track events'
do
tracker
=
double
before
do
described_class
.
instance_variable_set
(
"@snowplow"
,
nil
)
end
let
(
:tracker
)
{
double
}
def
receive_events
expect
(
SnowplowTracker
::
AsyncEmitter
).
to
receive
(
:new
).
with
(
'gitfoo.com'
,
{
protocol:
'https'
}
).
and_return
(
'_emitter_'
)
...
...
@@ -59,30 +69,67 @@ describe Gitlab::Tracking do
'gl'
,
'_abc123_'
).
and_return
(
tracker
)
end
expect
(
tracker
).
to
receive
(
:track_struct_event
).
with
(
'category'
,
'action'
,
'_label_'
,
'_property_'
,
'_value_'
,
'_context_'
,
timestamp
.
to_i
)
describe
'.event'
do
let
(
:track_event
)
do
described_class
.
event
(
'category'
,
'action'
,
label:
'_label_'
,
property:
'_property_'
,
value:
'_value_'
,
context:
nil
)
end
subject
.
event
(
'category'
,
'action'
,
label:
'_label_'
,
property:
'_property_'
,
value:
'_value_'
,
context:
'_context_'
)
it_behaves_like
'events not tracked'
it
'can track events'
do
receive_events
expect
(
tracker
).
to
receive
(
:track_struct_event
).
with
(
'category'
,
'action'
,
'_label_'
,
'_property_'
,
'_value_'
,
nil
,
timestamp
.
to_i
)
track_event
end
end
it
'does not track when not enabled'
do
stub_application_setting
(
snowplow_enabled:
false
)
expect
(
SnowplowTracker
::
Tracker
).
not_to
receive
(
:new
)
describe
'.self_describing_event'
do
let
(
:track_event
)
do
described_class
.
self_describing_event
(
'iglu:com.gitlab/example/jsonschema/1-0-2'
,
{
foo:
'bar'
,
foo_count:
42
},
context:
nil
)
end
it_behaves_like
'events not tracked'
it
'can track self describing events'
do
receive_events
expect
(
SnowplowTracker
::
SelfDescribingJson
).
to
receive
(
:new
).
with
(
'iglu:com.gitlab/example/jsonschema/1-0-2'
,
{
foo:
'bar'
,
foo_count:
42
}
).
and_return
(
'_event_json_'
)
expect
(
tracker
).
to
receive
(
:track_self_describing_event
).
with
(
'_event_json_'
,
nil
,
timestamp
.
to_i
)
subject
.
event
(
'epics'
,
'action'
,
property:
'what'
,
value:
'doit'
)
track_event
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment