Commit dc5dc34d authored by Andrejs Cunskis's avatar Andrejs Cunskis

Fix headless setting

parent 7e8235a3
...@@ -71,7 +71,9 @@ module QA ...@@ -71,7 +71,9 @@ module QA
ActiveSupport::Deprecation.warn("CHROME_HEADLESS is deprecated. Use WEBDRIVER_HEADLESS instead.") ActiveSupport::Deprecation.warn("CHROME_HEADLESS is deprecated. Use WEBDRIVER_HEADLESS instead.")
end end
enabled?(ENV['WEBDRIVER_HEADLESS']) || enabled?(ENV['CHROME_HEADLESS']) return enabled?(ENV['WEBDRIVER_HEADLESS']) unless ENV['WEBDRIVER_HEADLESS'].nil?
enabled?(ENV['CHROME_HEADLESS'])
end end
# set to 'true' to have Chrome use a fixed profile directory # set to 'true' to have Chrome use a fixed profile directory
...@@ -336,7 +338,7 @@ module QA ...@@ -336,7 +338,7 @@ module QA
# the feature is supported in the environment under test. # the feature is supported in the environment under test.
# All features are supported by default. # All features are supported by default.
def can_test?(feature) def can_test?(feature)
raise ArgumentError, %Q(Unknown feature "#{feature}") unless SUPPORTED_FEATURES.include? feature raise ArgumentError, %(Unknown feature "#{feature}") unless SUPPORTED_FEATURES.include? feature
enabled?(ENV[SUPPORTED_FEATURES[feature]], default: true) enabled?(ENV[SUPPORTED_FEATURES[feature]], default: true)
end end
...@@ -398,7 +400,9 @@ module QA ...@@ -398,7 +400,9 @@ module QA
def remote_grid_credentials def remote_grid_credentials
if remote_grid_username if remote_grid_username
raise ArgumentError, %Q(Please provide an access key for user "#{remote_grid_username}") unless remote_grid_access_key unless remote_grid_access_key
raise ArgumentError, %(Please provide an access key for user "#{remote_grid_username}")
end
return "#{remote_grid_username}:#{remote_grid_access_key}@" return "#{remote_grid_username}:#{remote_grid_access_key}@"
end end
......
...@@ -55,11 +55,6 @@ RSpec.describe QA::Runtime::Env do ...@@ -55,11 +55,6 @@ RSpec.describe QA::Runtime::Env do
end end
describe '.webdriver_headless?' do describe '.webdriver_headless?' do
before do
# We need to set this because we have a fallback for CHROME_HEADLESS
stub_env('CHROME_HEADLESS', 'false')
end
it_behaves_like 'boolean method', it_behaves_like 'boolean method',
method: :webdriver_headless?, method: :webdriver_headless?,
env_key: 'WEBDRIVER_HEADLESS', env_key: 'WEBDRIVER_HEADLESS',
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment