Rename PublishIncidentService to PublishService

Also rename PublishIncidentWorker to PublishService
for consistency.

config/sidekiq_queues.yml

@@ -234,7 +234,7 @@
   - 2
 - - service_desk_email_receiver
   - 1
-- - status_page_publish_incident
+- - status_page_publish
   - 1
 - - sync_seat_link_request
   - 1

ee/app/services/status_page/publish_details_service.rb

@@ -4,9 +4,9 @@ module StatusPage
   # Render an issue as incident details and publish them to CDN.
   #
   # This is an internal service which is part of
-  # +StatusPage::PublishIncidentService+ and is not meant to be called directly.
+  # +StatusPage::PublishService+ and is not meant to be called directly.
   #
-  # Consider calling +StatusPage::PublishIncidentService+ instead.
+  # Consider calling +StatusPage::PublishService+ instead.
   class PublishDetailsService < PublishBaseService
     private
 

ee/app/services/status_page/publish_list_service.rb

@@ -4,9 +4,9 @@ module StatusPage
   # Render a list of issues as incidents and publish them to CDN.
   #
   # This is an internal service which is part of
-  # +StatusPage::PublishIncidentService+ and is not meant to be called directly.
+  # +StatusPage::PublishService+ and is not meant to be called directly.
   #
-  # Consider calling +StatusPage::PublishIncidentService+ instead.
+  # Consider calling +StatusPage::PublishService+ instead.
   class PublishListService < PublishBaseService
     private
 

ee/app/services/status_page/publish_incident_service.rb → ee/app/services/status_page/publish_service.rb

@@ -11,7 +11,7 @@ module StatusPage
   # * StatusPage::PublishDetailsService
   # * StatusPage::UnpublishDetailsService
   # * StatusPage::PublishListService
-  class PublishIncidentService
+  class PublishService
     include Gitlab::Utils::StrongMemoize
 
     def initialize(user:, project:, issue_id:)

ee/app/services/status_page/trigger_publish_service.rb

@@ -15,8 +15,7 @@ module StatusPage
       return unless can_publish?
       return unless status_page_enabled?
 
-      StatusPage::PublishIncidentWorker
-        .perform_async(user.id, project.id, issue_id)
+      StatusPage::PublishWorker.perform_async(user.id, project.id, issue_id)
     end
 
     private

ee/app/services/status_page/unpublish_details_service.rb

@@ -6,9 +6,9 @@ module StatusPage
   # Example: An issue becomes confidential so it must be removed from CDN.
   #
   # This is an internal service which is part of
-  # +StatusPage::PublishIncidentService+ and is not meant to be called directly.
+  # +StatusPage::PublishService+ and is not meant to be called directly.
   #
-  # Consider calling +StatusPage::PublishIncidentService+ instead.
+  # Consider calling +StatusPage::PublishService+ instead.
   class UnpublishDetailsService < PublishBaseService
     private
 

ee/app/workers/all_queues.yml

@@ -33,7 +33,7 @@
   :idempotent: true
 - :name: cronjob:elastic_metrics_update
   :feature_category: :global_search
-  :has_external_dependencies:
+  :has_external_dependencies: 
   :urgency: :low
   :resource_boundary: :unknown
   :weight: 1
@@ -577,7 +577,7 @@
   :resource_boundary: :unknown
   :weight: 1
   :idempotent: 
-- :name: status_page_publish_incident
+- :name: status_page_publish
   :feature_category: :status_page
   :has_external_dependencies: true
   :urgency: :low

ee/app/workers/status_page/publish_incident_worker.rb → ee/app/workers/status_page/publish_worker.rb

 # frozen_string_literal: true
 
 module StatusPage
-  class PublishIncidentWorker
+  class PublishWorker
     include ApplicationWorker
     include Gitlab::Utils::StrongMemoize
 
@@ -26,7 +26,7 @@ module StatusPage
     attr_reader :user_id, :project_id, :issue_id
 
     def publish
-      result = PublishIncidentService
+      result = PublishService
         .new(user: user, project: project, issue_id: issue_id)
         .execute
 

ee/spec/services/status_page/publish_incident_service_spec.rb → ee/spec/services/status_page/publish_service_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe StatusPage::PublishIncidentService do
+describe StatusPage::PublishService do
   let_it_be(:user) { create(:user) }
   let_it_be(:project, refind: true) { create(:project) }
   let_it_be(:issue) { create(:issue, project: project) }

ee/spec/services/status_page/trigger_publish_service_spec.rb

@@ -7,7 +7,7 @@ describe StatusPage::TriggerPublishService do
   let_it_be(:project, refind: true) { create(:project) }
   let_it_be(:issue) { create(:issue, project: project) }
   let(:service) { described_class.new(user: user, project: project) }
-  let(:worker) { StatusPage::PublishIncidentWorker }
+  let(:worker) { StatusPage::PublishWorker }
 
   let_it_be(:status_page_setting) do
     create(:status_page_setting, :enabled, project: project)

ee/spec/workers/status_page/publish_incident_worker_spec.rb → ee/spec/workers/status_page/publish_worker_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe StatusPage::PublishIncidentWorker do
+describe StatusPage::PublishWorker do
   include ExclusiveLeaseHelpers
 
   let_it_be(:user) { create(:user) }
@@ -11,11 +11,11 @@ describe StatusPage::PublishIncidentWorker do
 
   let(:worker) { described_class.new }
   let(:logger) { worker.send(:logger) }
-  let(:service) { instance_double(StatusPage::PublishIncidentService) }
+  let(:service) { instance_double(StatusPage::PublishService) }
   let(:service_result) { ServiceResponse.success }
 
   before do
-    allow(StatusPage::PublishIncidentService)
+    allow(StatusPage::PublishService)
       .to receive(:new).with(user: user, project: project, issue_id: issue.id)
       .and_return(service)
     allow(service).to receive(:execute)
@@ -40,7 +40,7 @@ describe StatusPage::PublishIncidentWorker do
         let(:project) { build(:project) }
 
         it 'does not execute the service' do
-          expect(StatusPage::PublishIncidentService).not_to receive(:execute)
+          expect(StatusPage::PublishService).not_to receive(:execute)
 
           subject
         end