Do not auto-confirm email on Trial registration

This MR prevents email addresses from being confirmed
automatically for Trial registrations.

ee/app/controllers/trial_registrations_controller.rb

@@ -9,7 +9,6 @@ class TrialRegistrationsController < RegistrationsController
 
   before_action :check_if_gl_com
   before_action :set_redirect_url, only: [:new]
-  before_action :skip_confirmation, only: [:create]
 
   def new
   end
@@ -26,10 +25,6 @@ class TrialRegistrationsController < RegistrationsController
     end
   end
 
-  def skip_confirmation
-    params[:user][:skip_confirmation] = true
-  end
-
   override :sign_up_params
   def sign_up_params
     if params[:user]

ee/changelogs/unreleased/security-fix-trial-confirmation.yml

+---
+title: Do not auto-confirm email in Trial registration
+merge_request:
+author:
+type: security

ee/spec/controllers/trial_registrations_controller_spec.rb

@@ -71,10 +71,10 @@ describe TrialRegistrationsController do
         allow(Gitlab).to receive(:com?).and_return(true)
       end
 
-      it 'marks the account as confirmed' do
+      it 'marks the account as unconfirmed' do
         post :create, params: { user: user_params }
 
-        expect(User.last).to be_confirmed
+        expect(User.last).not_to be_confirmed
       end
 
       context 'derivation of name' do