Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
e0442862
Commit
e0442862
authored
Nov 21, 2019
by
Jacques Erasmus
Committed by
Kushal Pandya
Nov 21, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add external link icon
Added an external link icon
parent
f7f91373
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
17 additions
and
7 deletions
+17
-7
app/assets/javascripts/clusters/components/crossplane_provider_stack.vue
...scripts/clusters/components/crossplane_provider_stack.vue
+5
-5
changelogs/unreleased/36455-add-external-link-icon.yml
changelogs/unreleased/36455-add-external-link-icon.yml
+5
-0
spec/frontend/clusters/services/crossplane_provider_stack_spec.js
...ntend/clusters/services/crossplane_provider_stack_spec.js
+7
-2
No files found.
app/assets/javascripts/clusters/components/crossplane_provider_stack.vue
View file @
e0442862
<
script
>
<
script
>
import
{
GlDropdown
,
GlDropdownItem
}
from
'
@gitlab/ui
'
;
import
{
GlDropdown
,
GlDropdownItem
,
GlIcon
}
from
'
@gitlab/ui
'
;
import
Icon
from
'
~/vue_shared/components/icon.vue
'
;
import
{
s__
}
from
'
../../locale
'
;
import
{
s__
}
from
'
../../locale
'
;
export
default
{
export
default
{
...
@@ -8,7 +7,7 @@ export default {
...
@@ -8,7 +7,7 @@ export default {
components
:
{
components
:
{
GlDropdown
,
GlDropdown
,
GlDropdownItem
,
GlDropdownItem
,
Icon
,
Gl
Icon
,
},
},
props
:
{
props
:
{
stacks
:
{
stacks
:
{
...
@@ -86,8 +85,9 @@ export default {
...
@@ -86,8 +85,9 @@ export default {
href=
"https://crossplane.io/docs/master/stacks-guide.html"
href=
"https://crossplane.io/docs/master/stacks-guide.html"
target=
"_blank"
target=
"_blank"
rel=
"noopener noreferrer"
rel=
"noopener noreferrer"
>
{{
__
(
'
Crossplane
'
)
}}
</a
>
{{
__
(
'
Crossplane
'
)
}}
>
<gl-icon
name=
"external-link"
class=
"vertical-align-middle"
/>
</a>
</p>
</p>
</div>
</div>
</
template
>
</
template
>
changelogs/unreleased/36455-add-external-link-icon.yml
0 → 100644
View file @
e0442862
---
title
:
Add missing external-link icon for Crossplane managed app
merge_request
:
20283
author
:
type
:
fixed
spec/frontend/clusters/services/crossplane_provider_stack_spec.js
View file @
e0442862
import
{
shallowMount
}
from
'
@vue/test-utils
'
;
import
{
shallowMount
}
from
'
@vue/test-utils
'
;
import
{
GlDropdownItem
}
from
'
@gitlab/ui
'
;
import
{
GlDropdownItem
,
GlIcon
}
from
'
@gitlab/ui
'
;
import
CrossplaneProviderStack
from
'
~/clusters/components/crossplane_provider_stack.vue
'
;
import
CrossplaneProviderStack
from
'
~/clusters/components/crossplane_provider_stack.vue
'
;
describe
(
'
CrossplaneProviderStack component
'
,
()
=>
{
describe
(
'
CrossplaneProviderStack component
'
,
()
=>
{
...
@@ -72,7 +72,12 @@ describe('CrossplaneProviderStack component', () => {
...
@@ -72,7 +72,12 @@ describe('CrossplaneProviderStack component', () => {
findFirstDropdownElement
().
vm
.
$emit
(
'
click
'
);
findFirstDropdownElement
().
vm
.
$emit
(
'
click
'
);
expect
(
wrapper
.
emitted
().
set
[
0
][
0
].
code
).
toEqual
(
'
gcp
'
);
expect
(
wrapper
.
emitted
().
set
[
0
][
0
].
code
).
toEqual
(
'
gcp
'
);
});
});
it
(
'
it renders the correct dropdown text when no stack is selected
'
,
()
=>
{
it
(
'
renders the correct dropdown text when no stack is selected
'
,
()
=>
{
expect
(
wrapper
.
vm
.
dropdownText
).
toBe
(
'
Select Stack
'
);
expect
(
wrapper
.
vm
.
dropdownText
).
toBe
(
'
Select Stack
'
);
});
});
it
(
'
renders an external link
'
,
()
=>
{
expect
(
wrapper
.
find
(
GlIcon
).
props
(
'
name
'
)).
toBe
(
'
external-link
'
);
});
});
});
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment