Commit e0862c0f authored by Dmitry Gruzd's avatar Dmitry Gruzd

Merge branch '330278-remove-wip-support-from-commits' into 'master'

Remove WIP support from commits

See merge request gitlab-org/gitlab!79695
parents 0ca2cc36 8ddead16
...@@ -513,9 +513,7 @@ class Commit ...@@ -513,9 +513,7 @@ class Commit
# We don't want to do anything for `Commit` model, so this is empty. # We don't want to do anything for `Commit` model, so this is empty.
end end
# WIP is deprecated in favor of Draft. Currently both options are supported DRAFT_REGEX = /\A\s*#{Gitlab::Regex.merge_request_draft}|(fixup!|squash!)\s/.freeze
# https://gitlab.com/gitlab-org/gitlab/-/issues/227426
DRAFT_REGEX = /\A\s*#{Regexp.union(Gitlab::Regex.merge_request_wip, Gitlab::Regex.merge_request_draft)}|(fixup!|squash!)\s/.freeze
def work_in_progress? def work_in_progress?
!!(title =~ DRAFT_REGEX) !!(title =~ DRAFT_REGEX)
......
...@@ -748,29 +748,23 @@ eos ...@@ -748,29 +748,23 @@ eos
describe '#work_in_progress?' do describe '#work_in_progress?' do
[ [
'squash! ', 'fixup! ', 'wip: ', 'WIP: ', '[WIP] ', 'squash! ', 'fixup! ',
'draft: ', '[Draft] ', '(draft) ', 'Draft: ' 'draft: ', '[Draft] ', '(draft) ', 'Draft: '
].each do |wip_prefix| ].each do |draft_prefix|
it "detects the '#{wip_prefix}' prefix" do it "detects the '#{draft_prefix}' prefix" do
commit.message = "#{wip_prefix}#{commit.message}" commit.message = "#{draft_prefix}#{commit.message}"
expect(commit).to be_work_in_progress expect(commit).to be_work_in_progress
end end
end end
it "detects WIP for a commit just saying 'wip'" do
commit.message = "wip"
expect(commit).to be_work_in_progress
end
it "does not detect WIP for a commit just saying 'draft'" do it "does not detect WIP for a commit just saying 'draft'" do
commit.message = "draft" commit.message = "draft"
expect(commit).not_to be_work_in_progress expect(commit).not_to be_work_in_progress
end end
["FIXUP!", "Draft - ", "Wipeout"].each do |draft_prefix| ["FIXUP!", "Draft - ", "Wipeout", "WIP: ", "[WIP] ", "wip: "].each do |draft_prefix|
it "doesn't detect '#{draft_prefix}' at the start of the title as a draft" do it "doesn't detect '#{draft_prefix}' at the start of the title as a draft" do
commit.message = "#{draft_prefix} #{commit.message}" commit.message = "#{draft_prefix} #{commit.message}"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment