Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
e2d6614d
Commit
e2d6614d
authored
Mar 18, 2021
by
Payton Burdette
Committed by
David O'Regan
Mar 18, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove CI lint button
Remove the CI lint button from the jobs page nav.
parent
19de8358
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
5 additions
and
14 deletions
+5
-14
app/views/projects/jobs/index.html.haml
app/views/projects/jobs/index.html.haml
+0
-6
changelogs/unreleased/pb-remove-jobs-page-ci-lint-button.yml
changelogs/unreleased/pb-remove-jobs-page-ci-lint-button.yml
+5
-0
spec/features/projects/jobs/user_browses_jobs_spec.rb
spec/features/projects/jobs/user_browses_jobs_spec.rb
+0
-8
No files found.
app/views/projects/jobs/index.html.haml
View file @
e2d6614d
...
...
@@ -5,11 +5,5 @@
-
build_path_proc
=
->
(
scope
)
{
project_jobs_path
(
@project
,
scope:
scope
)
}
=
render
"shared/builds/tabs"
,
build_path_proc:
build_path_proc
,
all_builds:
@all_builds
,
scope:
@scope
.nav-controls
-
if
can?
(
current_user
,
:update_build
,
@project
)
=
link_to
project_ci_lint_path
(
@project
),
class:
'btn gl-button btn-default'
do
%span
=
_
(
'CI Lint'
)
.content-list.builds-content-list
=
render
"table"
,
builds:
@builds
,
project:
@project
changelogs/unreleased/pb-remove-jobs-page-ci-lint-button.yml
0 → 100644
View file @
e2d6614d
---
title
:
Remove CI lint button from Jobs page nav
merge_request
:
56854
author
:
type
:
removed
spec/features/projects/jobs/user_browses_jobs_spec.rb
View file @
e2d6614d
...
...
@@ -24,14 +24,6 @@ RSpec.describe 'User browses jobs' do
end
end
it
'shows the "CI Lint" button'
do
page
.
within
(
'.nav-controls'
)
do
ci_lint_tool_link
=
page
.
find_link
(
'CI Lint'
)
expect
(
ci_lint_tool_link
[
:href
]).
to
end_with
(
project_ci_lint_path
(
project
))
end
end
context
'with a failed job'
do
let!
(
:build
)
{
create
(
:ci_build
,
:coverage
,
:failed
,
pipeline:
pipeline
)
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment