Merge branch 'remove-pipeline-editor-section-feature-flag' into 'master'

Remove pipeline editor feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS]

See merge request gitlab-org/gitlab!54971

app/controllers/projects/ci/pipeline_editor_controller.rb

@@ -11,7 +11,6 @@ class Projects::Ci::PipelineEditorController < Projects::ApplicationController
   feature_category :pipeline_authoring
 
   def show
-    render_404 unless ::Gitlab::Ci::Features.ci_pipeline_editor_page_enabled?(@project)
   end
 
   private

app/helpers/ci/pipeline_editor_helper.rb

@@ -5,8 +5,7 @@ module Ci
     include ChecksCollaboration
 
     def can_view_pipeline_editor?(project)
-      can_collaborate_with_project?(project) &&
-        Gitlab::Ci::Features.ci_pipeline_editor_page_enabled?(project)
+      can_collaborate_with_project?(project)
     end
   end
 end

changelogs/unreleased/remove-pipeline-editor-section-feature-flag.yml

+---
+title: Remove pipeline editor feature flag
+merge_request: 54971
+author:
+type: other

config/feature_flags/development/ci_pipeline_editor_page.yml

----
-name: ci_pipeline_editor_page
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/46580
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/270059
-milestone: '13.6'
-type: development
-group: group::pipeline authoring
-default_enabled: true

doc/ci/pipeline_editor/index.md

@@ -8,10 +8,7 @@ type: reference
 # Pipeline Editor **(FREE)**
 
 > - [Introduced](https://gitlab.com/groups/gitlab-org/-/epics/4540) in GitLab 13.8.
-> - It's [deployed behind a feature flag](../../user/feature_flags.md), enabled by default.
-> - It's enabled on GitLab.com.
-> - It's recommended for production use.
-> - To use it in GitLab self-managed instances, ask a GitLab administrator to [enable it](#enable-or-disable-pipeline-editor). **(FREE SELF)**
+> - [Feature flag removed](https://gitlab.com/gitlab-org/gitlab/-/issues/270059) in GitLab 13.10.
 
 WARNING:
 This feature might not be available to you. Check the **version history** note above for details.
@@ -68,7 +65,6 @@ reflected in the CI lint. It displays the same results as the existing [CI Lint
 
 WARNING:
 This feature might not be available to you. Check the **version history** note above for details.
-It is not accessible if the [pipeline editor is disabled](#enable-or-disable-pipeline-editor).
 
 To view a visualization of your `gitlab-ci.yml` configuration, in your project,
 go to **CI/CD > Editor**, and then select the **Visualize** tab. The
@@ -150,22 +146,3 @@ If you enter a new branch name, the **Start a new merge request with these chang
 checkbox appears. Select it to start a new merge request after you commit the changes.
 
 ![The commit form with a new branch](img/pipeline_editor_commit_v13_8.png)
-
-## Enable or disable pipeline editor **(FREE SELF)**
-
-The pipeline editor is under development but ready for production use. It is
-deployed behind a feature flag that is **enabled by default**.
-[GitLab administrators with access to the GitLab Rails console](../../administration/feature_flags.md)
-can disable it.
-
-To disable it:
-
-```ruby
-Feature.disable(:ci_pipeline_editor_page)
-```
-
-To enable it:
-
-```ruby
-Feature.enable(:ci_pipeline_editor_page)
-```

lib/gitlab/ci/features.rb

@@ -55,10 +55,6 @@ module Gitlab
         ::Feature.enabled?(:ci_trace_log_invalid_chunks, project, type: :ops, default_enabled: false)
       end
 
-      def self.ci_pipeline_editor_page_enabled?(project)
-        ::Feature.enabled?(:ci_pipeline_editor_page, project, default_enabled: :yaml)
-      end
-
       def self.validate_build_dependencies?(project)
         ::Feature.enabled?(:ci_validate_build_dependencies, project, default_enabled: :yaml) &&
           ::Feature.disabled?(:ci_validate_build_dependencies_override, project)

spec/controllers/projects/ci/pipeline_editor_controller_spec.rb

@@ -36,18 +36,5 @@ RSpec.describe Projects::Ci::PipelineEditorController do
         expect(response).to have_gitlab_http_status(:not_found)
       end
     end
-
-    context 'when ci_pipeline_editor_page feature flag is disabled' do
-      before do
-        stub_feature_flags(ci_pipeline_editor_page: false)
-        project.add_developer(user)
-
-        get :show, params: { namespace_id: project.namespace, project_id: project }
-      end
-
-      it 'responds with 404' do
-        expect(response).to have_gitlab_http_status(:not_found)
-      end
-    end
   end
 end

spec/helpers/ci/pipeline_editor_helper_spec.rb

@@ -19,12 +19,5 @@ RSpec.describe Ci::PipelineEditorHelper do
 
       expect(subject).to be false
     end
-
-    it 'user can not view editor if feature is disabled' do
-      allow(helper).to receive(:can_collaborate_with_project?).and_return(true)
-      stub_feature_flags(ci_pipeline_editor_page: false)
-
-      expect(subject).to be false
-    end
   end
 end