Merge branch 'mo-remove-unused-feature-flag' into 'master'

Remove ci_synchronous_artifact_parsing feature flag

See merge request gitlab-org/gitlab!72618

app/services/ci/job_artifacts/create_service.rb

@@ -109,10 +109,6 @@ module Ci
       end
 
       def parse_artifact(artifact)
-        unless Feature.enabled?(:ci_synchronous_artifact_parsing, project, default_enabled: true)
-          return success
-        end
-
         case artifact.file_type
         when 'dotenv' then parse_dotenv_artifact(artifact)
         else success

config/feature_flags/development/ci_synchronous_artifact_parsing.yml

----
-name: ci_synchronous_artifact_parsing
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/26247
-rollout_issue_url: 
-milestone: '12.9'
-type: development
-group: group::release
-default_enabled: true

spec/services/ci/job_artifacts/create_service_spec.rb

@@ -175,18 +175,6 @@ RSpec.describe Ci::JobArtifacts::CreateService do
           hash_including('key' => 'KEY1', 'value' => 'VAR1', 'source' => 'dotenv'),
           hash_including('key' => 'KEY2', 'value' => 'VAR2', 'source' => 'dotenv'))
       end
-
-      context 'when ci_synchronous_artifact_parsing feature flag is disabled' do
-        before do
-          stub_feature_flags(ci_synchronous_artifact_parsing: false)
-        end
-
-        it 'does not call parse service' do
-          expect(Ci::ParseDotenvArtifactService).not_to receive(:new)
-
-          expect(subject[:status]).to eq(:success)
-        end
-      end
     end
 
     context 'when artifact_type is metrics' do