Merge branch 'refactoring-entities-file-22' into 'master'

Separate entities into own class files

See merge request gitlab-org/gitlab!24950

changelogs/unreleased/refactoring-entities-file-22.yml

+---
+title: Separate entities into own class files
+merge_request: 24950
+author: Rajendra Kadam
+type: added

lib/api/entities.rb

@@ -128,47 +128,6 @@ module API
         projects_relation + projects_relation.map(&:forked_from_project).compact
       end
     end
-
-    class Trigger < Grape::Entity
-      include ::API::Helpers::Presentable
-
-      expose :id
-      expose :token
-      expose :description
-      expose :created_at, :updated_at, :last_used
-      expose :owner, using: Entities::UserBasic
-    end
-
-    class Variable < Grape::Entity
-      expose :variable_type, :key, :value
-      expose :protected?, as: :protected, if: -> (entity, _) { entity.respond_to?(:protected?) }
-      expose :masked?, as: :masked, if: -> (entity, _) { entity.respond_to?(:masked?) }
-      expose :environment_scope, if: -> (entity, _) { entity.respond_to?(:environment_scope) }
-    end
-
-    class Pipeline < PipelineBasic
-      expose :before_sha, :tag, :yaml_errors
-
-      expose :user, with: Entities::UserBasic
-      expose :created_at, :updated_at, :started_at, :finished_at, :committed_at
-      expose :duration
-      expose :coverage
-      expose :detailed_status, using: DetailedStatusEntity do |pipeline, options|
-        pipeline.detailed_status(options[:current_user])
-      end
-    end
-
-    class PipelineSchedule < Grape::Entity
-      expose :id
-      expose :description, :ref, :cron, :cron_timezone, :next_run_at, :active
-      expose :created_at, :updated_at
-      expose :owner, using: Entities::UserBasic
-    end
-
-    class PipelineScheduleDetails < PipelineSchedule
-      expose :last_pipeline, using: Entities::PipelineBasic
-      expose :variables, using: Entities::Variable
-    end
   end
 end
 

lib/api/entities/pipeline.rb

+# frozen_string_literal: true
+
+module API
+  module Entities
+    class Pipeline < Entities::PipelineBasic
+      expose :before_sha, :tag, :yaml_errors
+
+      expose :user, with: Entities::UserBasic
+      expose :created_at, :updated_at, :started_at, :finished_at, :committed_at
+      expose :duration
+      expose :coverage
+      expose :detailed_status, using: DetailedStatusEntity do |pipeline, options|
+        pipeline.detailed_status(options[:current_user])
+      end
+    end
+  end
+end

lib/api/entities/pipeline_schedule.rb

+# frozen_string_literal: true
+
+module API
+  module Entities
+    class PipelineSchedule < Grape::Entity
+      expose :id
+      expose :description, :ref, :cron, :cron_timezone, :next_run_at, :active
+      expose :created_at, :updated_at
+      expose :owner, using: Entities::UserBasic
+    end
+  end
+end

lib/api/entities/pipeline_schedule_details.rb

+# frozen_string_literal: true
+
+module API
+  module Entities
+    class PipelineScheduleDetails < Entities::PipelineSchedule
+      expose :last_pipeline, using: Entities::PipelineBasic
+      expose :variables, using: Entities::Variable
+    end
+  end
+end

lib/api/entities/trigger.rb

+# frozen_string_literal: true
+
+module API
+  module Entities
+    class Trigger < Grape::Entity
+      include ::API::Helpers::Presentable
+
+      expose :id
+      expose :token
+      expose :description
+      expose :created_at, :updated_at, :last_used
+      expose :owner, using: Entities::UserBasic
+    end
+  end
+end

lib/api/entities/variable.rb

+# frozen_string_literal: true
+
+module API
+  module Entities
+    class Variable < Grape::Entity
+      expose :variable_type, :key, :value
+      expose :protected?, as: :protected, if: -> (entity, _) { entity.respond_to?(:protected?) }
+      expose :masked?, as: :masked, if: -> (entity, _) { entity.respond_to?(:masked?) }
+      expose :environment_scope, if: -> (entity, _) { entity.respond_to?(:environment_scope) }
+    end
+  end
+end