Merge branch 'fj-37254-remove-delete-personal-snippet' into 'master'

Remove destroy_personal_snippet ability

See merge request gitlab-org/gitlab!20717

app/policies/personal_snippet_policy.rb

@@ -13,7 +13,6 @@ class PersonalSnippetPolicy < BasePolicy
   rule { is_author | admin }.policy do
     enable :read_personal_snippet
     enable :update_personal_snippet
-    enable :destroy_personal_snippet
     enable :admin_personal_snippet
     enable :create_note
   end

changelogs/unreleased/fj-37254-remove-delete-personal-snippet.yml

+---
+title: Remove destroy_personal_snippet ability
+merge_request: 20717
+author:
+type: fixed

lib/api/snippets.rb

@@ -131,7 +131,7 @@ module API
         snippet = snippets_for_current_user.find_by_id(params.delete(:id))
         break not_found!('Snippet') unless snippet
 
-        authorize! :destroy_personal_snippet, snippet
+        authorize! :admin_personal_snippet, snippet
 
         destroy_conditionally!(snippet)
       end

spec/policies/personal_snippet_policy_spec.rb

@@ -11,8 +11,7 @@ describe PersonalSnippetPolicy do
   let(:author_permissions) do
     [
       :update_personal_snippet,
-      :admin_personal_snippet,
-      :destroy_personal_snippet
+      :admin_personal_snippet
     ]
   end