Merge branch '5143-fix-epic-create' into 'master'

Fix Epics not getting created in a Group with existing Epics

Closes #5143

See merge request gitlab-org/gitlab-ee!4865

ee/app/assets/javascripts/epics/new_epic/components/new_epic.vue

@@ -40,8 +40,7 @@
       createEpic() {
         this.creating = true;
         this.service.createEpic(this.title)
-          .then(res => res.json())
-          .then((data) => {
+          .then(({ data }) => {
             visitUrl(data.web_url);
           })
           .catch(() => {

ee/app/assets/javascripts/epics/new_epic/services/new_epic_service.js

-import Vue from 'vue';
-import VueResource from 'vue-resource';
-
-Vue.use(VueResource);
+import axios from '~/lib/utils/axios_utils';
 
 export default class NewEpicService {
   constructor(endpoint) {
     this.endpoint = endpoint;
-    this.resource = Vue.resource(this.endpoint, {});
   }
 
   createEpic(title) {
-    return this.resource.save({
+    return axios.post(this.endpoint, {
       title,
     });
   }

ee/changelogs/unreleased/5143-fix-epic-create.yml

+---
+title: Fix Epics not getting created in a Group with existing Epics
+merge_request: 4865
+author:
+type: fixed

spec/javascripts/epics/new_epic/components/new_epic_spec.js

 import Vue from 'vue';
-import _ from 'underscore';
+import MockAdapter from 'axios-mock-adapter';
+import axios from '~/lib/utils/axios_utils';
 import newEpic from 'ee/epics/new_epic/components/new_epic.vue';
 import * as urlUtility from '~/lib/utils/url_utility';
 import mountComponent from 'spec/helpers/vue_mount_component_helper';
 
 describe('newEpic', () => {
   let vm;
-
-  const interceptor = (request, next) => {
-    next(request.respondWith(JSON.stringify({
-      web_url: gl.TEST_HOST,
-    }), {
-      status: 200,
-    }));
-  };
+  let mock;
 
   beforeEach(() => {
-    Vue.http.interceptors.push(interceptor);
-
     const NewEpic = Vue.extend(newEpic);
+
+    mock = new MockAdapter(axios);
+    mock.onPost(gl.TEST_HOST).reply(200, { web_url: gl.TEST_HOST });
     vm = mountComponent(NewEpic, {
       endpoint: gl.TEST_HOST,
     });
   });
 
   afterEach(() => {
-    Vue.http.interceptors = _.without(Vue.http.interceptors, interceptor);
+    mock.restore();
+    vm.$destroy();
   });
 
   describe('alignRight', () => {