Merge branch 'pl-fast-spec-helper' into 'master'

Fix specs which are incompatible with fast_spec_helper

See merge request gitlab-org/gitlab!78543

ee/spec/lib/elastic/latest/config_spec.rb

 # frozen_string_literal: true
 
-require 'fast_spec_helper'
+require 'spec_helper'
 require_relative './config_shared_examples'
 
 RSpec.describe Elastic::Latest::Config do

ee/spec/lib/elastic/latest/custom_language_analyzers_spec.rb

 # frozen_string_literal: true
 
-require 'fast_spec_helper'
-require 'rspec-parameterized'
+require 'spec_helper'
 
 RSpec.describe Elastic::Latest::CustomLanguageAnalyzers do
   describe '.custom_analyzers_mappings' do

ee/spec/lib/elastic/latest/issue_config_spec.rb

 # frozen_string_literal: true
 
-require 'fast_spec_helper'
+require 'spec_helper'
 require_relative './config_shared_examples'
 
 RSpec.describe Elastic::Latest::IssueConfig do

ee/spec/lib/elastic/latest/merge_request_config_spec.rb

 # frozen_string_literal: true
 
-require 'fast_spec_helper'
+require 'spec_helper'
 require_relative './config_shared_examples'
 
 RSpec.describe Elastic::Latest::MergeRequestConfig do

ee/spec/lib/elastic/latest/note_config_spec.rb

 # frozen_string_literal: true
 
-require 'fast_spec_helper'
+require 'spec_helper'
 require_relative './config_shared_examples'
 
 RSpec.describe Elastic::Latest::NoteConfig do

ee/spec/lib/elastic/latest/routing_spec.rb

 # frozen_string_literal: true
 
-require 'fast_spec_helper'
-require 'support/helpers/stub_feature_flags'
+require 'spec_helper'
 
 RSpec.describe Elastic::Latest::Routing do
   let(:proxified_class) { Issue }
   let(:included_class) { Elastic::Latest::ApplicationClassProxy }
-
-  subject { included_class.new(proxified_class) }
-
   let(:project_ids) { [1, 2, 3] }
   let(:project_routing) { 'project_1,project_2,project_3' }
 
+  subject { included_class.new(proxified_class) }
+
   describe '#search' do
     it 'calls routing_options with empty hash' do
       expect(subject).to receive(:routing_options).and_return({})

ee/spec/lib/gitlab/insights/validators/params_validator_spec.rb

 # frozen_string_literal: true
 
 require 'fast_spec_helper'
+require_dependency 'action_controller'
 
 RSpec.describe Gitlab::Insights::Validators::ParamsValidator do
   subject { described_class.new(params).validate! }

ee/spec/lib/gitlab/patch/draw_route_spec.rb

@@ -2,6 +2,8 @@
 
 require 'fast_spec_helper'
 
+require_relative '../../../../lib/ee/gitlab/patch/draw_route'
+
 RSpec.describe Gitlab::Patch::DrawRoute do
   subject do
     Class.new do

ee/spec/workers/concerns/elastic/migration_obsolete_spec.rb

 # frozen_string_literal: true
 
-require 'fast_spec_helper'
+require 'spec_helper'
 
 RSpec.describe Elastic::MigrationObsolete do
   let(:migration_class) do

ee/spec/workers/concerns/elastic/migration_options_spec.rb

 # frozen_string_literal: true
 
-require 'fast_spec_helper'
+require 'spec_helper'
 
 RSpec.describe Elastic::MigrationOptions do
   let(:migration_class) do

spec/initializers/net_http_patch_spec.rb

 # frozen_string_literal: true
+
 require 'fast_spec_helper'
 
+require_relative '../../config/initializers/net_http_patch'
+
 RSpec.describe 'Net::HTTP patch proxy user and password encoding' do
   let(:net_http) { Net::HTTP.new('hostname.example') }
 

spec/lib/gitlab/ci/config/entry/include/rules/rule_spec.rb

 # frozen_string_literal: true
 
 require 'fast_spec_helper'
+require_dependency 'active_model'
 
 RSpec.describe Gitlab::Ci::Config::Entry::Include::Rules::Rule do
   let(:factory) do

spec/lib/gitlab/ci/config/entry/include/rules_spec.rb

 # frozen_string_literal: true
 
 require 'fast_spec_helper'
+require_dependency 'active_model'
 
 RSpec.describe Gitlab::Ci::Config::Entry::Include::Rules do
   let(:factory) do

spec/lib/gitlab/ci/config/entry/include_spec.rb

 # frozen_string_literal: true
 
 require 'fast_spec_helper'
+require_dependency 'active_model'
 
 RSpec.describe ::Gitlab::Ci::Config::Entry::Include do
   subject(:include_entry) { described_class.new(config) }

spec/lib/gitlab/ci/config/entry/policy_spec.rb

 # frozen_string_literal: true
 
-require 'fast_spec_helper'
-require 'support/helpers/stub_feature_flags'
-require_dependency 'active_model'
+require 'spec_helper'
 
 RSpec.describe Gitlab::Ci::Config::Entry::Policy do
   let(:entry) { described_class.new(config) }
@@ -47,6 +45,7 @@ RSpec.describe Gitlab::Ci::Config::Entry::Policy do
         end
 
         context 'when using unsafe regexp' do
+          # When removed we could use `require 'fast_spec_helper'` again.
           include StubFeatureFlags
 
           let(:config) { ['/^(?!master).+/'] }
@@ -107,6 +106,7 @@ RSpec.describe Gitlab::Ci::Config::Entry::Policy do
     end
 
     context 'when using unsafe regexp' do
+      # When removed we could use `require 'fast_spec_helper'` again.
       include StubFeatureFlags
 
       let(:config) { { refs: ['/^(?!master).+/'] } }

spec/lib/gitlab/ci/config/normalizer/matrix_strategy_spec.rb

 # frozen_string_literal: true
 
 require 'fast_spec_helper'
-require 'support/helpers/stubbed_feature'
-require 'support/helpers/stub_feature_flags'
 
 RSpec.describe Gitlab::Ci::Config::Normalizer::MatrixStrategy do
-  include StubFeatureFlags
-
   describe '.applies_to?' do
     subject { described_class.applies_to?(config) }
 

spec/lib/gitlab/cluster/lifecycle_events_spec.rb

 # frozen_string_literal: true
 
-require 'fast_spec_helper'
-require 'rspec-parameterized'
+require 'spec_helper'
 
 RSpec.describe Gitlab::Cluster::LifecycleEvents do
   # we create a new instance to ensure that we do not touch existing hooks

spec/lib/gitlab/database/background_migration/batch_metrics_spec.rb

 # frozen_string_literal: true
 
-require 'fast_spec_helper'
+require 'spec_helper'
 
 RSpec.describe Gitlab::Database::BackgroundMigration::BatchMetrics do
   let(:batch_metrics) { described_class.new }

spec/lib/gitlab/error_tracking/context_payload_generator_spec.rb

 # frozen_string_literal: true
 
-require 'fast_spec_helper'
-require 'rspec-parameterized'
+require 'spec_helper'
 
 RSpec.describe Gitlab::ErrorTracking::ContextPayloadGenerator do
   subject(:generator) { described_class.new }

spec/lib/gitlab/error_tracking/log_formatter_spec.rb

 # frozen_string_literal: true
 
-require 'fast_spec_helper'
+require 'spec_helper'
 
 RSpec.describe Gitlab::ErrorTracking::LogFormatter do
   let(:exception) { StandardError.new('boom') }

spec/lib/gitlab/feature_categories_spec.rb

 # frozen_string_literal: true
 
-require 'fast_spec_helper'
+require 'spec_helper'
 
 RSpec.describe Gitlab::FeatureCategories do
   let(:fake_categories) { %w(foo bar) }

spec/lib/gitlab/graphql/authorize/object_authorization_spec.rb

 # frozen_string_literal: true
 
-require 'fast_spec_helper'
+require 'spec_helper'
 
 RSpec.describe ::Gitlab::Graphql::Authorize::ObjectAuthorization do
   describe '#ok?' do

spec/lib/gitlab/graphql/batch_key_spec.rb

 # frozen_string_literal: true
 
 require 'fast_spec_helper'
-require 'test_prof/recipes/rspec/let_it_be'
 
 RSpec.describe ::Gitlab::Graphql::BatchKey do
-  let_it_be(:rect) { Struct.new(:len, :width) }
-  let_it_be(:circle) { Struct.new(:radius) }
-
+  let(:rect) { Struct.new(:len, :width) }
+  let(:circle) { Struct.new(:radius) }
   let(:lookahead) { nil }
   let(:object) { rect.new(2, 3) }
 

spec/lib/gitlab/graphql/queries_spec.rb

 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'fast_spec_helper'
-require "test_prof/recipes/rspec/let_it_be"
 
 RSpec.describe Gitlab::Graphql::Queries do
   shared_examples 'a valid GraphQL query for the blog schema' do

spec/lib/gitlab/graphql/tracers/application_context_tracer_spec.rb

 # frozen_string_literal: true
-require "fast_spec_helper"
-require "support/graphql/fake_tracer"
-require "support/graphql/fake_query_type"
+
+require 'spec_helper'
 
 RSpec.describe Gitlab::Graphql::Tracers::ApplicationContextTracer do
   let(:tracer_spy) { spy('tracer_spy') }

spec/lib/gitlab/import_export/config_spec.rb

 # frozen_string_literal: true
 
-require 'fast_spec_helper'
-require 'rspec-parameterized'
+require 'spec_helper'
 
 RSpec.describe Gitlab::ImportExport::Config do
   let(:yaml_file) { described_class.new }

spec/lib/gitlab/incident_management/pager_duty/incident_issue_description_spec.rb

 # frozen_string_literal: true
 
-require 'fast_spec_helper'
+require 'spec_helper'
 
 RSpec.describe Gitlab::IncidentManagement::PagerDuty::IncidentIssueDescription do
   describe '#to_s' do

spec/lib/gitlab/kubernetes/kubectl_cmd_spec.rb

@@ -2,6 +2,8 @@
 
 require 'fast_spec_helper'
 
+require_relative '../../../../lib/gitlab/kubernetes/pod_cmd'
+
 RSpec.describe Gitlab::Kubernetes::KubectlCmd do
   describe '.delete' do
     it 'constructs string properly' do

spec/lib/gitlab/regex_spec.rb

 # frozen_string_literal: true
 
-require 'fast_spec_helper'
+require 'spec_helper'
 
 RSpec.describe Gitlab::Regex do
   shared_examples_for 'project/group name chars regex' do

spec/lib/gitlab/request_profiler/profile_spec.rb

 # frozen_string_literal: true
 
-require 'fast_spec_helper'
+require 'spec_helper'
 
 RSpec.describe Gitlab::RequestProfiler::Profile do
   let(:profile) { described_class.new(filename) }

spec/lib/gitlab/untrusted_regexp/ruby_syntax_spec.rb

 # frozen_string_literal: true
 
-require 'fast_spec_helper'
-require 'support/shared_examples/lib/gitlab/malicious_regexp_shared_examples'
-require 'support/helpers/stub_feature_flags'
+require 'spec_helper'
 
 RSpec.describe Gitlab::UntrustedRegexp::RubySyntax do
   describe '.matches_syntax?' do
@@ -77,6 +75,7 @@ RSpec.describe Gitlab::UntrustedRegexp::RubySyntax do
       include StubFeatureFlags
 
       before do
+        # When removed we could use `require 'fast_spec_helper'` again.
         stub_feature_flags(allow_unsafe_ruby_regexp: true)
 
         allow(Gitlab::UntrustedRegexp).to receive(:new).and_raise(RegexpError)

spec/lib/gitlab/webpack/file_loader_spec.rb

 # frozen_string_literal: true
 
-require 'fast_spec_helper'
-require 'support/helpers/file_read_helpers'
-require 'support/webmock'
+require 'spec_helper'
 
 RSpec.describe Gitlab::Webpack::FileLoader do
   include FileReadHelpers

spec/lib/peek/views/detailed_view_spec.rb

 # frozen_string_literal: true
 
-require 'fast_spec_helper'
+require 'spec_helper'
 
 RSpec.describe Peek::Views::DetailedView, :request_store do
   context 'when a class defines thresholds' do

spec/lib/serializers/json_spec.rb

 # frozen_string_literal: true
 
 require 'fast_spec_helper'
+require 'oj'
 
 RSpec.describe Serializers::Json do
   describe '.dump' do

spec/lib/serializers/symbolized_json_spec.rb

 # frozen_string_literal: true
 
 require 'fast_spec_helper'
+require 'oj'
 
 RSpec.describe Serializers::SymbolizedJson do
   describe '.dump' do

spec/lib/system_check/incoming_email/imap_authentication_check_spec.rb

 # frozen_string_literal: true
 
-require 'fast_spec_helper'
+require 'spec_helper'
 
 MAIL_ROOM_CONFIG_ENABLED_SAMPLE =
   ":mailboxes:\n"\

spec/models/instance_metadata_spec.rb

 # frozen_string_literal: true
 
 require 'fast_spec_helper'
+require_relative '../../app/models/instance_metadata'
+require_relative '../../app/models/instance_metadata/kas'
 
 RSpec.describe InstanceMetadata do
   it 'has the correct properties' do

spec/tooling/docs/deprecation_handling_spec.rb

 # frozen_string_literal: true
 
-require_relative '../../fast_spec_helper'
+require 'spec_helper'
+
 require_relative '../../../tooling/docs/deprecation_handling'
-require_relative '../../support/helpers/next_instance_of'
 
 RSpec.describe Docs::DeprecationHandling do
-  include ::NextInstanceOf
-
   let(:type) { 'deprecation' }
 
   subject { described_class.new(type).render }