Commit e616c041 authored by Kamil Trzciński's avatar Kamil Trzciński

Merge branch...

Merge branch '292906-rspec-feature-flags-fail-when-there-is-gitaly_-feature-flag-defined' into 'master'

Ignore `gitaly_*` feature flags in rspec:feature-flags check [RUN ALL RSPEC]

See merge request gitlab-org/gitlab!49799
parents 33c1f4a8 b7bc0ac2
...@@ -39,6 +39,9 @@ flags_paths.each do |flags_path| ...@@ -39,6 +39,9 @@ flags_paths.each do |flags_path|
Dir.glob(flags_path).each do |path| Dir.glob(flags_path).each do |path|
feature_flag_name = File.basename(path, '.yml') feature_flag_name = File.basename(path, '.yml')
# TODO: we need a better way of tracking use of Gitaly FF across Gitaly and GitLab
next if feature_flag_name.start_with?('gitaly_')
all_flags[feature_flag_name] = File.exist?(File.join('tmp', 'feature_flags', feature_flag_name + '.used')) all_flags[feature_flag_name] = File.exist?(File.join('tmp', 'feature_flags', feature_flag_name + '.used'))
end end
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment