Merge branch 'cablett-spam-service-test-refactor' into 'master'

Small spam_check_service test refactor

See merge request gitlab-org/gitlab!28306

spec/services/spam/spam_check_service_spec.rb

@@ -49,6 +49,25 @@ describe Spam::SpamCheckService do
     end
   end
 
+  shared_examples 'akismet spam' do
+    context 'when request is missing' do
+      let(:request) { nil }
+
+      it "doesn't check as spam" do
+        subject
+
+        expect(issue).not_to be_spam
+      end
+    end
+
+    context 'when request exists' do
+      it 'creates a spam log' do
+        expect { subject }
+            .to log_spam(title: issue.title, description: issue.description, noteable_type: 'Issue')
+      end
+    end
+  end
+
   describe '#execute' do
     let(:request) { double(:request, env: env) }
 

spec/support/shared_examples/spam_check_shared_examples.rb

-# frozen_string_literal: true
-
-shared_examples 'akismet spam' do
-  context 'when request is missing' do
-    subject { described_class.new(spammable: issue, request: nil) }
-
-    it "doesn't check as spam" do
-      subject
-
-      expect(issue).not_to be_spam
-    end
-  end
-
-  context 'when request exists' do
-    it 'creates a spam log' do
-      expect { subject }
-          .to log_spam(title: issue.title, description: issue.description, noteable_type: 'Issue')
-    end
-  end
-end