Merge branch 'fix-failing-dashboard-schema-validation-calls' into 'master'

Fix failing dashboard schema validation calls

See merge request gitlab-org/gitlab!37108

app/assets/javascripts/monitoring/stores/actions.js

@@ -360,14 +360,14 @@ export const receiveAnnotationsSuccess = ({ commit }, data) =>
   commit(types.RECEIVE_ANNOTATIONS_SUCCESS, data);
 export const receiveAnnotationsFailure = ({ commit }) => commit(types.RECEIVE_ANNOTATIONS_FAILURE);
 
-export const fetchDashboardValidationWarnings = ({ state, dispatch }) => {
+export const fetchDashboardValidationWarnings = ({ state, dispatch, getters }) => {
   /**
    * Normally, the default dashboard won't throw any validation warnings.
    *
    * However, if a bug sneaks into the default dashboard making it invalid,
    * this might come handy for our clients
    */
-  const dashboardPath = state.currentDashboard || DEFAULT_DASHBOARD_PATH;
+  const dashboardPath = getters.fullDashboardPath || DEFAULT_DASHBOARD_PATH;
   return gqClient
     .mutate({
       mutation: getDashboardValidationWarnings,

changelogs/unreleased/fix-failing-dashboard-schema-validation-calls.yml

+---
+title: Fix failing dashboard schema validation calls
+merge_request: 37108
+author:
+type: fixed

spec/frontend/monitoring/store/actions_spec.js

@@ -872,6 +872,11 @@ describe('Monitoring store actions', () => {
       state.projectPath = 'gitlab-org/gitlab-test';
       state.currentEnvironmentName = 'production';
       state.currentDashboard = '.gitlab/dashboards/dashboard_with_warnings.yml';
+      // testAction doesn't have access to getters. The state is passed in as getters
+      // instead of the actual getters inside the testAction method implementation.
+      // All methods downstream that needs access to getters will throw and error.
+      // For that reason, the result of the getter is set as a state variable.
+      state.fullDashboardPath = store.getters['monitoringDashboard/fullDashboardPath'];
 
       mockMutate = jest.spyOn(gqClient, 'mutate');
       mutationVariables = {
@@ -879,7 +884,7 @@ describe('Monitoring store actions', () => {
         variables: {
           projectPath: state.projectPath,
           environmentName: state.currentEnvironmentName,
-          dashboardPath: state.currentDashboard,
+          dashboardPath: state.fullDashboardPath,
         },
       };
     });