Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
e9d2a2e1
Commit
e9d2a2e1
authored
Apr 08, 2020
by
lauraMon
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Replaces underscore with lodash
And vanilla JS when possible
parent
8d17d7c3
Changes
6
Hide whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
17 additions
and
17 deletions
+17
-17
app/assets/javascripts/alerts_service_settings/components/alerts_service_form.vue
...lerts_service_settings/components/alerts_service_form.vue
+2
-2
app/assets/javascripts/create_item_dropdown.js
app/assets/javascripts/create_item_dropdown.js
+4
-4
ee/app/assets/javascripts/packages/details/components/app.vue
...pp/assets/javascripts/packages/details/components/app.vue
+3
-3
ee/app/assets/javascripts/related_items_tree/components/create_issue_form.vue
...ripts/related_items_tree/components/create_issue_form.vue
+1
-1
ee/app/assets/javascripts/related_items_tree/components/tree_item_body.vue
...ascripts/related_items_tree/components/tree_item_body.vue
+2
-2
ee/app/assets/javascripts/related_items_tree/components/tree_item_remove_modal.vue
.../related_items_tree/components/tree_item_remove_modal.vue
+5
-5
No files found.
app/assets/javascripts/alerts_service_settings/components/alerts_service_form.vue
View file @
e9d2a2e1
...
...
@@ -6,7 +6,7 @@ import {
GlModal
,
GlModalDirective
,
}
from
'
@gitlab/ui
'
;
import
_
from
'
underscore
'
;
import
{
escape
as
esc
}
from
'
lodash
'
;
import
ClipboardButton
from
'
~/vue_shared/components/clipboard_button.vue
'
;
import
ToggleButton
from
'
~/vue_shared/components/toggle_button.vue
'
;
import
axios
from
'
~/lib/utils/axios_utils
'
;
...
...
@@ -65,7 +65,7 @@ export default {
'
AlertService|%{linkStart}Learn more%{linkEnd} about configuring this endpoint to receive alerts.
'
,
),
{
linkStart
:
`<a href="
${
_
.
escape
(
linkStart
:
`<a href="
${
esc
(
this
.
learnMoreUrl
,
)}
" target="_blank" rel="noopener noreferrer">`
,
linkEnd
:
'
</a>
'
,
...
...
app/assets/javascripts/create_item_dropdown.js
View file @
e9d2a2e1
import
_
from
'
underscore
'
;
import
{
escape
as
esc
}
from
'
lodash
'
;
import
'
~/gl_dropdown
'
;
export
default
class
CreateItemDropdown
{
...
...
@@ -37,14 +37,14 @@ export default class CreateItemDropdown {
},
selectable
:
true
,
toggleLabel
(
selected
)
{
return
selected
&&
'
id
'
in
selected
?
_
.
escape
(
selected
.
title
)
:
this
.
defaultToggleLabel
;
return
selected
&&
'
id
'
in
selected
?
esc
(
selected
.
title
)
:
this
.
defaultToggleLabel
;
},
fieldName
:
this
.
fieldName
,
text
(
item
)
{
return
_
.
escape
(
item
.
text
);
return
esc
(
item
.
text
);
},
id
(
item
)
{
return
_
.
escape
(
item
.
id
);
return
esc
(
item
.
id
);
},
onFilter
:
this
.
toggleCreateNewButton
.
bind
(
this
),
clicked
:
options
=>
{
...
...
ee/app/assets/javascripts/packages/details/components/app.vue
View file @
e9d2a2e1
...
...
@@ -9,7 +9,7 @@ import {
GlEmptyState
,
GlTable
,
}
from
'
@gitlab/ui
'
;
import
_
from
'
underscore
'
;
import
{
escape
as
esc
}
from
'
lodash
'
;
import
Tracking
from
'
~/tracking
'
;
import
PackageActivity
from
'
./activity.vue
'
;
import
PackageInformation
from
'
./information.vue
'
;
...
...
@@ -83,8 +83,8 @@ export default {
`PackageRegistry|You are about to delete version %{boldStart}%{version}%{boldEnd} of %{boldStart}%{name}%{boldEnd}. Are you sure?`
,
),
{
version
:
_
.
escape
(
this
.
packageEntity
.
version
),
name
:
_
.
escape
(
this
.
packageEntity
.
name
),
version
:
esc
(
this
.
packageEntity
.
version
),
name
:
esc
(
this
.
packageEntity
.
name
),
boldStart
:
'
<b>
'
,
boldEnd
:
'
</b>
'
,
},
...
...
ee/app/assets/javascripts/related_items_tree/components/create_issue_form.vue
View file @
e9d2a2e1
...
...
@@ -8,7 +8,7 @@ import {
GlSearchBoxByType
,
GlLoadingIcon
,
}
from
'
@gitlab/ui
'
;
import
{
debounce
}
from
'
underscore
'
;
import
{
debounce
}
from
'
lodash
'
;
import
{
__
}
from
'
~/locale
'
;
import
ProjectAvatar
from
'
~/vue_shared/components/project_avatar/default.vue
'
;
...
...
ee/app/assets/javascripts/related_items_tree/components/tree_item_body.vue
View file @
e9d2a2e1
...
...
@@ -8,7 +8,7 @@ import {
GlDeprecatedButton
,
GlTooltip
,
}
from
'
@gitlab/ui
'
;
import
_
from
'
underscore
'
;
import
{
isEmpty
}
from
'
lodash
'
;
import
ItemWeight
from
'
ee/boards/components/issue_card_weight.vue
'
;
import
{
__
}
from
'
~/locale
'
;
...
...
@@ -71,7 +71,7 @@ export default {
return
this
.
item
.
state
===
ChildState
.
Closed
;
},
hasMilestone
()
{
return
!
_
.
isEmpty
(
this
.
item
.
milestone
);
return
!
isEmpty
(
this
.
item
.
milestone
);
},
hasAssignees
()
{
return
this
.
item
.
assignees
&&
this
.
item
.
assignees
.
length
>
0
;
...
...
ee/app/assets/javascripts/related_items_tree/components/tree_item_remove_modal.vue
View file @
e9d2a2e1
<
script
>
import
{
mapState
,
mapActions
}
from
'
vuex
'
;
import
_
from
'
underscore
'
;
import
{
escape
as
esc
}
from
'
lodash
'
;
import
{
GlModal
}
from
'
@gitlab/ui
'
;
...
...
@@ -30,13 +30,13 @@ export default {
if
(
this
.
removeItemType
===
ChildType
.
Epic
)
{
Object
.
assign
(
sprintfParams
,
{
targetEpicTitle
:
_
.
escape
(
this
.
removeItemModalProps
.
item
.
title
),
parentEpicTitle
:
_
.
escape
(
this
.
parentItem
.
title
),
targetEpicTitle
:
esc
(
this
.
removeItemModalProps
.
item
.
title
),
parentEpicTitle
:
esc
(
this
.
parentItem
.
title
),
});
}
else
{
Object
.
assign
(
sprintfParams
,
{
targetIssueTitle
:
_
.
escape
(
this
.
removeItemModalProps
.
item
.
title
),
parentEpicTitle
:
_
.
escape
(
this
.
parentItem
.
title
),
targetIssueTitle
:
esc
(
this
.
removeItemModalProps
.
item
.
title
),
parentEpicTitle
:
esc
(
this
.
parentItem
.
title
),
});
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment