Commit ea72c621 authored by Mark Lapierre's avatar Mark Lapierre

Avoid using non-essential frequently-changing command

The dataloss command has been changed a few time recently, causing
tests to fail that expected the behavior before the change.

The dataloss command is not really required in this test to confirm
when nodes are inconsistent. The rake 'replicas' task is enough for
that. The command was included because it was useful to test that it
performs as expected, but the test loses its value when the
behavior under test changes so frequently.

This also fixes a problem in `PraefectManager.replicated?` that
caused the retry loop to end prematurely.
parent 50192cda
......@@ -39,6 +39,7 @@ module QA
break line if line.start_with?('gitaly_cluster')
break nil if line.include?('Something went wrong when getting replicas')
end
next false unless replicas
# We want to know if the checksums are identical
replicas&.split('|')&.map(&:strip)&.slice(1..3)&.uniq&.one?
......
......@@ -55,7 +55,6 @@ module QA
praefect_manager.wait_for_health_check_current_primary_node
# Confirm dataloss (i.e., inconsistent nodes)
expect(praefect_manager.dataloss?).to be true
expect(praefect_manager.replicated?(project.id)).to be false
# Reconcile nodes to recover from dataloss
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment