Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
ed5ecec1
Commit
ed5ecec1
authored
May 30, 2019
by
Winnie Hellmann
Committed by
Phil Hughes
May 30, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Extract clearDetailIssue() to issue boards store
parent
101733b5
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
16 additions
and
2 deletions
+16
-2
app/assets/javascripts/boards/components/sidebar/remove_issue.vue
...ts/javascripts/boards/components/sidebar/remove_issue.vue
+1
-1
app/assets/javascripts/boards/index.js
app/assets/javascripts/boards/index.js
+1
-1
app/assets/javascripts/boards/stores/boards_store.js
app/assets/javascripts/boards/stores/boards_store.js
+4
-0
spec/javascripts/boards/boards_store_spec.js
spec/javascripts/boards/boards_store_spec.js
+10
-0
No files found.
app/assets/javascripts/boards/components/sidebar/remove_issue.vue
View file @
ed5ecec1
...
@@ -48,7 +48,7 @@ export default Vue.extend({
...
@@ -48,7 +48,7 @@ export default Vue.extend({
list
.
removeIssue
(
issue
);
list
.
removeIssue
(
issue
);
});
});
boardsStore
.
detail
.
issue
=
{}
;
boardsStore
.
clearDetailIssue
()
;
},
},
/**
/**
* Build the default patch request.
* Build the default patch request.
...
...
app/assets/javascripts/boards/index.js
View file @
ed5ecec1
...
@@ -167,7 +167,7 @@ export default () => {
...
@@ -167,7 +167,7 @@ export default () => {
boardsStore
.
detail
.
issue
=
newIssue
;
boardsStore
.
detail
.
issue
=
newIssue
;
},
},
clearDetailIssue
()
{
clearDetailIssue
()
{
boardsStore
.
detail
.
issue
=
{}
;
boardsStore
.
clearDetailIssue
()
;
},
},
toggleSubscription
(
id
)
{
toggleSubscription
(
id
)
{
const
{
issue
}
=
boardsStore
.
detail
;
const
{
issue
}
=
boardsStore
.
detail
;
...
...
app/assets/javascripts/boards/stores/boards_store.js
View file @
ed5ecec1
...
@@ -188,6 +188,10 @@ const boardsStore = {
...
@@ -188,6 +188,10 @@ const boardsStore = {
updateFiltersUrl
()
{
updateFiltersUrl
()
{
window
.
history
.
pushState
(
null
,
null
,
`?
${
this
.
filter
.
path
}
`
);
window
.
history
.
pushState
(
null
,
null
,
`?
${
this
.
filter
.
path
}
`
);
},
},
clearDetailIssue
()
{
this
.
detail
.
issue
=
{};
},
};
};
BoardsStoreEE
.
initEESpecific
(
boardsStore
);
BoardsStoreEE
.
initEESpecific
(
boardsStore
);
...
...
spec/javascripts/boards/boards_store_spec.js
View file @
ed5ecec1
...
@@ -268,4 +268,14 @@ describe('Store', () => {
...
@@ -268,4 +268,14 @@ describe('Store', () => {
});
});
});
});
});
});
describe
(
'
clearDetailIssue
'
,
()
=>
{
it
(
'
resets issue details
'
,
()
=>
{
boardsStore
.
detail
.
issue
=
'
something
'
;
boardsStore
.
clearDetailIssue
();
expect
(
boardsStore
.
detail
.
issue
).
toEqual
({});
});
});
});
});
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment