Merge branch '337167-remove-ci_skip_before_parsing_yaml' into 'master'

Remove `ci_skip_before_parsing_yaml` feature flag

See merge request gitlab-org/gitlab!68287

app/services/ci/create_pipeline_service.rb

@@ -16,7 +16,6 @@ module Ci
                 Gitlab::Ci::Pipeline::Chain::Config::Process,
                 Gitlab::Ci::Pipeline::Chain::Validate::AfterConfig,
                 Gitlab::Ci::Pipeline::Chain::RemoveUnwantedChatJobs,
-                Gitlab::Ci::Pipeline::Chain::LegacySkip,
                 Gitlab::Ci::Pipeline::Chain::SeedBlock,
                 Gitlab::Ci::Pipeline::Chain::EvaluateWorkflowRules,
                 Gitlab::Ci::Pipeline::Chain::Seed,

config/feature_flags/development/ci_skip_before_parsing_yaml.yml

----
-name: ci_skip_before_parsing_yaml
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/66147
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/337167
-milestone: '14.2'
-type: development
-group: group::pipeline execution
-default_enabled: true

lib/gitlab/ci/pipeline/chain/legacy_skip.rb

-# frozen_string_literal: true
-
-module Gitlab
-  module Ci
-    module Pipeline
-      module Chain
-        # This will be removed with https://gitlab.com/gitlab-org/gitlab/-/issues/337167
-        class LegacySkip < Chain::Skip
-          include ::Gitlab::Utils::StrongMemoize
-
-          SKIP_PATTERN = /\[(ci[ _-]skip|skip[ _-]ci)\]/i.freeze
-
-          def perform!
-            return if ::Feature.enabled?(:ci_skip_before_parsing_yaml, project, default_enabled: :yaml)
-
-            if skipped?
-              if @command.save_incompleted
-                # Project iid must be called outside a transaction, so we ensure it is set here
-                # otherwise it may be set within the state transition transaction of the skip call
-                # which it will lock the InternalId row for the whole transaction
-                @pipeline.ensure_project_iid!
-
-                @pipeline.skip
-              end
-            end
-          end
-
-          def break?
-            return if ::Feature.enabled?(:ci_skip_before_parsing_yaml, project, default_enabled: :yaml)
-
-            skipped?
-          end
-
-          private
-
-          def skipped?
-            !@command.ignore_skip_ci && (commit_message_skips_ci? || push_option_skips_ci?)
-          end
-
-          def commit_message_skips_ci?
-            return false unless @pipeline.git_commit_message
-
-            strong_memoize(:commit_message_skips_ci) do
-              !!(@pipeline.git_commit_message =~ SKIP_PATTERN)
-            end
-          end
-
-          def push_option_skips_ci?
-            @command.push_options.present? &&
-              @command.push_options.deep_symbolize_keys.dig(:ci, :skip).present?
-          end
-        end
-      end
-    end
-  end
-end

lib/gitlab/ci/pipeline/chain/skip.rb

@@ -10,8 +10,6 @@ module Gitlab
           SKIP_PATTERN = /\[(ci[ _-]skip|skip[ _-]ci)\]/i.freeze
 
           def perform!
-            return unless ::Feature.enabled?(:ci_skip_before_parsing_yaml, project, default_enabled: :yaml)
-
             if skipped?
               if @command.save_incompleted
                 # Project iid must be called outside a transaction, so we ensure it is set here
@@ -25,8 +23,6 @@ module Gitlab
           end
 
           def break?
-            return unless ::Feature.enabled?(:ci_skip_before_parsing_yaml, project, default_enabled: :yaml)
-
             skipped?
           end
 

spec/services/ci/create_pipeline_service_spec.rb

@@ -708,14 +708,6 @@ RSpec.describe Ci::CreatePipelineService do
           let(:commit_message) { skip_commit_message }
 
           it_behaves_like 'skipping a pipeline'
-
-          context 'when the FF ci_skip_before_parsing_yaml is disabled' do
-            before do
-              stub_feature_flags(ci_skip_before_parsing_yaml: false)
-            end
-
-            it_behaves_like 'skipping a pipeline'
-          end
         end
       end
 
@@ -723,14 +715,6 @@ RSpec.describe Ci::CreatePipelineService do
         let(:commit_message) { 'some message' }
 
         it_behaves_like 'creating a pipeline'
-
-        context 'when the FF ci_skip_before_parsing_yaml is disabled' do
-          before do
-            stub_feature_flags(ci_skip_before_parsing_yaml: false)
-          end
-
-          it_behaves_like 'creating a pipeline'
-        end
       end
 
       context 'when commit message is nil' do
@@ -748,19 +732,6 @@ RSpec.describe Ci::CreatePipelineService do
         end
 
         it_behaves_like 'skipping a pipeline'
-
-        context 'when the FF ci_skip_before_parsing_yaml is disabled' do
-          before do
-            stub_feature_flags(ci_skip_before_parsing_yaml: false)
-          end
-
-          it 'creates the pipeline with error' do
-            pipeline = execute_service.payload
-
-            expect(pipeline).to be_persisted
-            expect(pipeline.status).to eq("failed")
-          end
-        end
       end
     end