Commit f12dba53 authored by GitLab Bot's avatar GitLab Bot

Add latest changes from gitlab-org/gitlab@master

parent 3888bc42
...@@ -204,7 +204,11 @@ class Environment < ApplicationRecord ...@@ -204,7 +204,11 @@ class Environment < ApplicationRecord
end end
def has_metrics? def has_metrics?
available? && prometheus_adapter&.configured? available? && (prometheus_adapter&.configured? || has_sample_metrics?)
end
def has_sample_metrics?
!!ENV['USE_SAMPLE_METRICS']
end end
def metrics def metrics
......
---
title: Show sample metrics for an environment without prometheus configured
merge_request: 22133
author:
type: added
...@@ -25,7 +25,7 @@ are very appreciative of the work done by translators and proofreaders! ...@@ -25,7 +25,7 @@ are very appreciative of the work done by translators and proofreaders!
- Victor Wu - [GitLab](https://gitlab.com/victorwuky), [Crowdin](https://crowdin.com/profile/victorwu) - Victor Wu - [GitLab](https://gitlab.com/victorwuky), [Crowdin](https://crowdin.com/profile/victorwu)
- Ivan Ip - [GitLab](https://gitlab.com/lifehome), [Crowdin](https://crowdin.com/profile/lifehome) - Ivan Ip - [GitLab](https://gitlab.com/lifehome), [Crowdin](https://crowdin.com/profile/lifehome)
- Czech - Czech
- Proofreaders needed. - Jan Urbanec - [GitLab](https://gitlab.com/TatranskyMedved), [Crowdin](https://crowdin.com/profile/Tatranskymedved)
- Danish - Danish
- Saederup92 - [GitLab](https://gitlab.com/Saederup92), [Crowdin](https://crowdin.com/profile/Saederup92) - Saederup92 - [GitLab](https://gitlab.com/Saederup92), [Crowdin](https://crowdin.com/profile/Saederup92)
- Dutch - Dutch
......
...@@ -6,6 +6,7 @@ describe Environment, :use_clean_rails_memory_store_caching do ...@@ -6,6 +6,7 @@ describe Environment, :use_clean_rails_memory_store_caching do
include ReactiveCachingHelpers include ReactiveCachingHelpers
using RSpec::Parameterized::TableSyntax using RSpec::Parameterized::TableSyntax
include RepoHelpers include RepoHelpers
include StubENV
let(:project) { create(:project, :repository) } let(:project) { create(:project, :repository) }
...@@ -851,6 +852,52 @@ describe Environment, :use_clean_rails_memory_store_caching do ...@@ -851,6 +852,52 @@ describe Environment, :use_clean_rails_memory_store_caching do
context 'without a monitoring service' do context 'without a monitoring service' do
it { is_expected.to be_falsy } it { is_expected.to be_falsy }
end end
context 'when sample metrics are enabled' do
before do
stub_env('USE_SAMPLE_METRICS', 'true')
end
context 'with no prometheus adapter configured' do
before do
allow(environment.prometheus_adapter).to receive(:configured?).and_return(false)
end
it { is_expected.to be_truthy }
end
end
end
describe '#has_sample_metrics?' do
subject { environment.has_metrics? }
let(:project) { create(:project) }
context 'when sample metrics are enabled' do
before do
stub_env('USE_SAMPLE_METRICS', 'true')
end
context 'with no prometheus adapter configured' do
before do
allow(environment.prometheus_adapter).to receive(:configured?).and_return(false)
end
it { is_expected.to be_truthy }
end
context 'with the environment stopped' do
before do
environment.stop
end
it { is_expected.to be_falsy }
end
end
context 'when sample metrics are not enabled' do
it { is_expected.to be_falsy }
end
end end
context 'when the environment is unavailable' do context 'when the environment is unavailable' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment