Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
f1a71155
Commit
f1a71155
authored
Mar 10, 2020
by
Nicolò Maria Mezzopera
Committed by
Natalia Tepluhina
Mar 10, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix requestTagsList parameters in details page
- details page - unit tests
parent
b841f858
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
11 additions
and
4 deletions
+11
-4
app/assets/javascripts/registry/explorer/pages/details.vue
app/assets/javascripts/registry/explorer/pages/details.vue
+1
-1
spec/features/projects/container_registry_spec.rb
spec/features/projects/container_registry_spec.rb
+9
-2
spec/frontend/registry/explorer/pages/details_spec.js
spec/frontend/registry/explorer/pages/details_spec.js
+1
-1
No files found.
app/assets/javascripts/registry/explorer/pages/details.vue
View file @
f1a71155
...
...
@@ -102,7 +102,7 @@ export default {
return
this
.
tagsPagination
.
page
;
},
set
(
page
)
{
this
.
requestTagsList
({
pagination
:
{
page
},
id
:
this
.
$route
.
params
.
id
});
this
.
requestTagsList
({
pagination
:
{
page
},
params
:
this
.
$route
.
params
.
id
});
},
},
},
...
...
spec/features/projects/container_registry_spec.rb
View file @
f1a71155
...
...
@@ -126,6 +126,7 @@ describe 'Container Registry', :js do
describe
'image repo details'
do
before
do
stub_container_registry_tags
(
repository:
%r{my/image}
,
tags:
(
'1'
..
'20'
).
to_a
,
with_manifest:
true
)
visit_container_registry_details
'my/image'
end
...
...
@@ -140,12 +141,18 @@ describe 'Container Registry', :js do
it
'user removes a specific tag from container repository'
do
service
=
double
(
'service'
)
expect
(
service
).
to
receive
(
:execute
).
with
(
container_repository
)
{
{
status: :success
}
}
expect
(
Projects
::
ContainerRepository
::
DeleteTagsService
).
to
receive
(
:new
).
with
(
container_repository
.
project
,
user
,
tags:
[
'
latest
'
])
{
service
}
expect
(
Projects
::
ContainerRepository
::
DeleteTagsService
).
to
receive
(
:new
).
with
(
container_repository
.
project
,
user
,
tags:
[
'
1
'
])
{
service
}
click_on
(
class:
'js-delete-registry'
)
first
(
'.js-delete-registry'
).
click
expect
(
find
(
'.modal .modal-title'
)).
to
have_content
_
(
'Remove tag'
)
find
(
'.modal .modal-footer .btn-danger'
).
click
end
it
(
'pagination navigate to the second page'
)
do
pagination
=
find
(
'.gl-pagination'
)
pagination
.
click_link
(
'2'
)
expect
(
page
).
to
have_content
'20'
end
end
end
end
...
...
spec/frontend/registry/explorer/pages/details_spec.js
View file @
f1a71155
...
...
@@ -219,7 +219,7 @@ describe('Details Page', () => {
dispatchSpy
.
mockResolvedValue
();
wrapper
.
setData
({
currentPage
:
2
});
expect
(
store
.
dispatch
).
toHaveBeenCalledWith
(
'
requestTagsList
'
,
{
id
:
wrapper
.
vm
.
$route
.
params
.
id
,
params
:
wrapper
.
vm
.
$route
.
params
.
id
,
pagination
:
{
page
:
2
},
});
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment