Merge branch '244380_improve_the_performance_of_vulnerable_projects_query' into 'master'

Utilize `ProjectSetting#has_vulnerabilities` attribute to get projects

See merge request gitlab-org/gitlab!47259

ee/app/models/ee/project.rb

@@ -149,7 +149,7 @@ module EE
       scope :with_designs, -> { where(id: ::DesignManagement::Design.select(:project_id).distinct) }
       scope :with_deleting_user, -> { includes(:deleting_user) }
       scope :with_compliance_framework_settings, -> { preload(:compliance_framework_setting) }
-      scope :has_vulnerabilities, -> { joins(:vulnerabilities).group(:id) }
+      scope :has_vulnerabilities, -> { joins(:project_setting).merge(::ProjectSetting.has_vulnerabilities) }
       scope :has_vulnerability_statistics, -> { joins(:vulnerability_statistic) }
       scope :with_vulnerability_statistics, -> { includes(:vulnerability_statistic) }
 

ee/app/models/ee/project_setting.rb

@@ -6,6 +6,8 @@ module EE
 
     prepended do
       belongs_to :push_rule
+
+      scope :has_vulnerabilities, -> { where('has_vulnerabilities IS TRUE') }
     end
   end
 end

ee/spec/factories/project_settings.rb

+# frozen_string_literal: true
+
+FactoryBot.modify do
+  factory :project_setting do
+    trait :has_vulnerabilities do
+      has_vulnerabilities { true }
+    end
+  end
+end

ee/spec/graphql/ee/resolvers/namespace_projects_resolver_spec.rb

@@ -15,7 +15,8 @@ RSpec.describe Resolvers::NamespaceProjectsResolver do
     before do
       project_1.add_developer(current_user)
       project_2.add_developer(current_user)
-      create(:vulnerability, project: project_1)
+
+      project_1.project_setting.update!(has_vulnerabilities: true)
     end
 
     describe '#resolve' do

ee/spec/models/ee/project_setting_spec.rb

+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe ProjectSetting do
+  it { is_expected.to belong_to(:push_rule) }
+
+  describe '.has_vulnerabilities' do
+    let_it_be(:setting_1) { create(:project_setting, :has_vulnerabilities) }
+    let_it_be(:setting_2) { create(:project_setting) }
+
+    subject { described_class.has_vulnerabilities }
+
+    it { is_expected.to contain_exactly(setting_1) }
+  end
+end

ee/spec/models/project_spec.rb

@@ -248,9 +248,11 @@ RSpec.describe Project do
     describe '.has_vulnerabilities' do
       let_it_be(:project_1) { create(:project) }
       let_it_be(:project_2) { create(:project) }
+      let_it_be(:project_3) { create(:project) }
 
       before do
-        create(:vulnerability, project: project_1)
+        project_1.project_setting.update!(has_vulnerabilities: true)
+        project_2.project_setting.update!(has_vulnerabilities: false)
       end
 
       subject { described_class.has_vulnerabilities }

ee/spec/workers/vulnerabilities/statistics/schedule_worker_spec.rb

@@ -10,8 +10,8 @@ RSpec.describe Vulnerabilities::Statistics::ScheduleWorker do
     let(:deleted_project) { create(:project, pending_delete: true) }
 
     before do
-      create(:vulnerability, project: project)
-      create(:vulnerability, project: deleted_project)
+      project.project_setting.update!(has_vulnerabilities: true)
+      deleted_project.project_setting.update!(has_vulnerabilities: true)
 
       allow(Vulnerabilities::Statistics::AdjustmentWorker).to receive(:perform_in)
     end

spec/factories/project_settings.rb

+# frozen_string_literal: true
+
+FactoryBot.define do
+  factory :project_setting do
+    project
+  end
+end