Merge branch 'cngo-remove-vue_issuable_sidebar-feature-flag' into 'master'

Remove vue_issuable_sidebar feature flag

See merge request gitlab-org/gitlab!52363

app/assets/javascripts/pages/projects/incidents/show/index.js

@@ -3,7 +3,5 @@ import initRelatedIssues from '~/related_issues';
 import initShow from '../../issues/show';
 
 initShow();
-if (!gon.features?.vueIssuableSidebar) {
-  initSidebarBundle();
-}
+initSidebarBundle();
 initRelatedIssues();

app/assets/javascripts/pages/projects/issues/show/index.js

@@ -3,7 +3,5 @@ import initRelatedIssues from '~/related_issues';
 import initShow from '../show';
 
 initShow();
-if (gon.features && !gon.features.vueIssuableSidebar) {
-  initSidebarBundle();
-}
+initSidebarBundle();
 initRelatedIssues();

app/assets/javascripts/pages/projects/merge_requests/show/index.js

@@ -6,9 +6,7 @@ import initIssuableHeaderWarning from '~/vue_shared/components/issuable/init_iss
 import store from '~/mr_notes/stores';
 
 initShow();
-if (gon.features && !gon.features.vueIssuableSidebar) {
-  initSidebarBundle();
-}
+initSidebarBundle();
 initMrNotes();
 initReviewBar();
 initIssuableHeaderWarning(store);

app/controllers/projects/issues_controller.rb

@@ -41,7 +41,6 @@ class Projects::IssuesController < Projects::ApplicationController
   before_action :create_rate_limit, only: [:create]
 
   before_action do
-    push_frontend_feature_flag(:vue_issuable_sidebar, project.group)
     push_frontend_feature_flag(:tribute_autocomplete, @project)
     push_frontend_feature_flag(:vue_issuables_list, project)
     push_frontend_feature_flag(:usage_data_design_action, project, default_enabled: true)

app/controllers/projects/merge_requests_controller.rb

@@ -48,7 +48,6 @@ class Projects::MergeRequestsController < Projects::MergeRequests::ApplicationCo
   end
 
   before_action do
-    push_frontend_feature_flag(:vue_issuable_sidebar, @project.group)
     push_frontend_feature_flag(:merge_request_reviewers, @project, default_enabled: true)
     push_frontend_feature_flag(:mr_collapsed_approval_rules, @project)
     push_frontend_feature_flag(:reviewer_approval_rules, @project, default_enabled: :yaml)

config/feature_flags/development/vue_issuable_sidebar.yml

----
-name: vue_issuable_sidebar
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/18199
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/292802
-milestone: '12.4'
-type: development
-group: group::project management
-default_enabled: false

ee/app/assets/javascripts/pages/projects/issues/show/index.js

@@ -6,10 +6,7 @@ import initShow from '~/pages/projects/issues/show';
 import UserCallout from '~/user_callout';
 
 initShow();
-
-if (gon.features && !gon.features.vueIssuableSidebar) {
-  initSidebarBundle();
-}
+initSidebarBundle();
 initRelatedIssues();
 
 // eslint-disable-next-line no-new

ee/app/assets/javascripts/pages/projects/merge_requests/show/index.js

@@ -7,9 +7,7 @@ import initIssuableHeaderWarning from '~/vue_shared/components/issuable/init_iss
 import initShow from '~/pages/projects/merge_requests/init_merge_request_show';
 
 initShow();
-if (gon.features && !gon.features.vueIssuableSidebar) {
-  initSidebarBundle();
-}
+initSidebarBundle();
 initMrNotes();
 initReviewBar();
 initIssuableHeaderWarning(store);

spec/spec_helper.rb

@@ -216,12 +216,6 @@ RSpec.configure do |config|
       # (ie. ApplicationSetting#auto_devops_enabled)
       stub_feature_flags(force_autodevops_on_by_default: false)
 
-      # The following can be removed once Vue Issuable Sidebar
-      # is feature-complete and can be made default in place
-      # of older sidebar.
-      # See https://gitlab.com/groups/gitlab-org/-/epics/1863
-      stub_feature_flags(vue_issuable_sidebar: false)
-
       # Merge request widget GraphQL requests are disabled in the tests
       # for now whilst we migrate as much as we can over the GraphQL
       stub_feature_flags(merge_request_widget_graphql: false)