Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
f27e97de
Commit
f27e97de
authored
Sep 22, 2020
by
Imre Farkas
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove periodic_project_authorization_recalculation feature flag
It is enabled by default since 13.2.
parent
6e8d2f10
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
2 additions
and
37 deletions
+2
-37
app/workers/authorized_project_update/periodic_recalculate_worker.rb
.../authorized_project_update/periodic_recalculate_worker.rb
+1
-3
app/workers/authorized_project_update/user_refresh_over_user_range_worker.rb
...zed_project_update/user_refresh_over_user_range_worker.rb
+1
-3
config/feature_flags/development/periodic_project_authorization_recalculation.yml
...elopment/periodic_project_authorization_recalculation.yml
+0
-7
spec/workers/authorized_project_update/periodic_recalculate_worker_spec.rb
...orized_project_update/periodic_recalculate_worker_spec.rb
+0
-12
spec/workers/authorized_project_update/user_refresh_over_user_range_worker_spec.rb
...roject_update/user_refresh_over_user_range_worker_spec.rb
+0
-12
No files found.
app/workers/authorized_project_update/periodic_recalculate_worker.rb
View file @
f27e97de
...
...
@@ -12,9 +12,7 @@ module AuthorizedProjectUpdate
idempotent!
def
perform
if
::
Feature
.
enabled?
(
:periodic_project_authorization_recalculation
,
default_enabled:
true
)
AuthorizedProjectUpdate
::
PeriodicRecalculateService
.
new
.
execute
end
AuthorizedProjectUpdate
::
PeriodicRecalculateService
.
new
.
execute
end
end
end
app/workers/authorized_project_update/user_refresh_over_user_range_worker.rb
View file @
f27e97de
...
...
@@ -12,9 +12,7 @@ module AuthorizedProjectUpdate
idempotent!
def
perform
(
start_user_id
,
end_user_id
)
if
::
Feature
.
enabled?
(
:periodic_project_authorization_recalculation
,
default_enabled:
true
)
AuthorizedProjectUpdate
::
RecalculateForUserRangeService
.
new
(
start_user_id
,
end_user_id
).
execute
end
AuthorizedProjectUpdate
::
RecalculateForUserRangeService
.
new
(
start_user_id
,
end_user_id
).
execute
end
end
end
config/feature_flags/development/periodic_project_authorization_recalculation.yml
deleted
100644 → 0
View file @
6e8d2f10
---
name
:
periodic_project_authorization_recalculation
introduced_by_url
:
rollout_issue_url
:
group
:
type
:
development
default_enabled
:
true
spec/workers/authorized_project_update/periodic_recalculate_worker_spec.rb
View file @
f27e97de
...
...
@@ -11,17 +11,5 @@ RSpec.describe AuthorizedProjectUpdate::PeriodicRecalculateWorker do
subject
.
perform
end
context
'feature flag :periodic_project_authorization_recalculation is disabled'
do
before
do
stub_feature_flags
(
periodic_project_authorization_recalculation:
false
)
end
it
'does not call AuthorizedProjectUpdate::PeriodicRecalculateService'
do
expect
(
AuthorizedProjectUpdate
::
PeriodicRecalculateService
).
not_to
receive
(
:new
)
subject
.
perform
end
end
end
end
spec/workers/authorized_project_update/user_refresh_over_user_range_worker_spec.rb
View file @
f27e97de
...
...
@@ -14,17 +14,5 @@ RSpec.describe AuthorizedProjectUpdate::UserRefreshOverUserRangeWorker do
subject
.
perform
(
start_user_id
,
end_user_id
)
end
context
'feature flag :periodic_project_authorization_recalculation is disabled'
do
before
do
stub_feature_flags
(
periodic_project_authorization_recalculation:
false
)
end
it
'does not call AuthorizedProjectUpdate::RecalculateForUserRangeService'
do
expect
(
AuthorizedProjectUpdate
::
RecalculateForUserRangeService
).
not_to
receive
(
:new
)
subject
.
perform
(
start_user_id
,
end_user_id
)
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment