Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
f308d04c
Commit
f308d04c
authored
Feb 17, 2021
by
Vladimir Shushlin
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove pages_serve_from_deployments FF
It was enabled for a couple of releases already
parent
ed8b8224
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
0 additions
and
18 deletions
+0
-18
app/models/pages/lookup_path.rb
app/models/pages/lookup_path.rb
+0
-2
config/feature_flags/development/pages_serve_from_deployments.yml
...eature_flags/development/pages_serve_from_deployments.yml
+0
-8
spec/models/pages/lookup_path_spec.rb
spec/models/pages/lookup_path_spec.rb
+0
-8
No files found.
app/models/pages/lookup_path.rb
View file @
f308d04c
...
...
@@ -43,8 +43,6 @@ module Pages
def
deployment
strong_memoize
(
:deployment
)
do
next
unless
Feature
.
enabled?
(
:pages_serve_from_deployments
,
project
,
default_enabled:
true
)
project
.
pages_metadatum
.
pages_deployment
end
end
...
...
config/feature_flags/development/pages_serve_from_deployments.yml
deleted
100644 → 0
View file @
ed8b8224
---
name
:
pages_serve_from_deployments
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/46320
rollout_issue_url
:
https://gitlab.com/gitlab-com/gl-infra/production/-/issues/2932
milestone
:
'
13.6'
type
:
development
group
:
group::release
default_enabled
:
true
spec/models/pages/lookup_path_spec.rb
View file @
f308d04c
...
...
@@ -117,14 +117,6 @@ RSpec.describe Pages::LookupPath do
end
end
context
'when pages_serve_from_deployments feature flag is disabled'
do
before
do
stub_feature_flags
(
pages_serve_from_deployments:
false
)
end
include_examples
'uses disk storage'
end
context
'when deployment were created during migration'
do
before
do
allow
(
deployment
).
to
receive
(
:migrated?
).
and_return
(
true
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment