Merge branch '12601-security-dashboard-help-link' into 'master'

Replaces dashboard help link in project helper

Closes #12601

See merge request gitlab-org/gitlab-ee!14669

ee/app/helpers/ee/projects_helper.rb

@@ -157,7 +157,7 @@ module EE
       if pipeline.nil?
         {
           empty_state_illustration_path: image_path('illustrations/security-dashboard_empty.svg'),
-          security_dashboard_help_path: help_page_path("user/project/security_dashboard"),
+          security_dashboard_help_path: help_page_path('user/application_security/security_dashboard'),
           has_pipeline_data: "false"
         }
       else
@@ -169,6 +169,7 @@ module EE
           vulnerability_feedback_help_path: help_page_path("user/application_security/index", anchor: "interacting-with-the-vulnerabilities"),
           empty_state_svg_path: image_path('illustrations/security-dashboard-empty-state.svg'),
           dashboard_documentation: help_page_path('user/application_security/security_dashboard/index'),
+          security_dashboard_help_path: help_page_path('user/application_security/security_dashboard'),
           pipeline_id: pipeline.id,
           user_path: user_url(pipeline.user),
           user_avatar_path: pipeline.user.avatar_url,

ee/changelogs/unreleased/12601-security-dashboard-help-link.yml

+---
+title: Updates the security dashboard documentation link
+merge_request: 14669
+author:
+type: other

ee/spec/helpers/projects_helper_spec.rb

@@ -96,4 +96,36 @@ describe ProjectsHelper do
       end
     end
   end
+
+  describe '#project_security_dashboard_config' do
+    let(:user) { create(:user) }
+    let(:group) { create(:group).tap { |g| g.add_owner(user) } }
+    let(:project) { create(:project, :repository, group: group) }
+    let(:pipeline) do
+      create(:ee_ci_pipeline,
+      :with_sast_report,
+      user: user,
+      project: project,
+      ref: project.default_branch,
+      sha: project.commit.sha)
+    end
+
+    context 'project without pipeline' do
+      subject { helper.project_security_dashboard_config(project, nil) }
+
+      it 'returns simple config' do
+        expect(subject[:security_dashboard_help_path]).to eq '/help/user/application_security/security_dashboard'
+        expect(subject[:has_pipeline_data]).to eq 'false'
+      end
+    end
+
+    context 'project with pipeline' do
+      subject { helper.project_security_dashboard_config(project, pipeline) }
+
+      it 'returns config containing pipeline details' do
+        expect(subject[:security_dashboard_help_path]).to eq '/help/user/application_security/security_dashboard'
+        expect(subject[:has_pipeline_data]).to eq 'true'
+      end
+    end
+  end
 end