Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
f6f1f217
Commit
f6f1f217
authored
Aug 29, 2021
by
Jonston Chan
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix broken foundations link
parent
b040c392
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
1 addition
and
1 deletion
+1
-1
doc/development/code_review.md
doc/development/code_review.md
+1
-1
No files found.
doc/development/code_review.md
View file @
f6f1f217
...
...
@@ -107,7 +107,7 @@ with [domain expertise](#domain-experts).
1.
If your merge request includes adding a new JavaScript library (
*1*
)...
-
If the library significantly increases the
[
bundle size
](
https://gitlab.com/gitlab-org/frontend/playground/webpack-memory-metrics/-/blob/master/doc/report.md
)
, it must
be
**approved by a [frontend foundations member](https://about.gitlab.com/direction/
create/ecosystem/frontend-ux-
foundations/)**
.
be
**approved by a [frontend foundations member](https://about.gitlab.com/direction/
ecosystem/
foundations/)**
.
-
If the license used by the new library hasn't been approved for use in
GitLab, the license must be
**approved by a [legal department member](https://about.gitlab.com/handbook/legal/)**
.
More information about license compatibility can be found in our
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment