Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
f7e873c3
Commit
f7e873c3
authored
Oct 02, 2020
by
Paul Slaughter
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Move merge_conflicts to page specific styles
Also moves color variables to css variables for dark mode support
parent
abc46947
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
13 additions
and
6 deletions
+13
-6
app/assets/stylesheets/_page_specific_files.scss
app/assets/stylesheets/_page_specific_files.scss
+0
-1
app/assets/stylesheets/page_bundles/merge_conflicts.scss
app/assets/stylesheets/page_bundles/merge_conflicts.scss
+6
-5
app/views/projects/merge_requests/conflicts/show.html.haml
app/views/projects/merge_requests/conflicts/show.html.haml
+1
-0
changelogs/unreleased/239852-move-merge-conflicts-to-page-bundle.yml
...unreleased/239852-move-merge-conflicts-to-page-bundle.yml
+5
-0
config/application.rb
config/application.rb
+1
-0
No files found.
app/assets/stylesheets/_page_specific_files.scss
View file @
f7e873c3
...
@@ -31,7 +31,6 @@
...
@@ -31,7 +31,6 @@
@import
'./pages/labels'
;
@import
'./pages/labels'
;
@import
'./pages/login'
;
@import
'./pages/login'
;
@import
'./pages/members'
;
@import
'./pages/members'
;
@import
'./pages/merge_conflicts'
;
@import
'./pages/merge_requests'
;
@import
'./pages/merge_requests'
;
@import
'./pages/monitor'
;
@import
'./pages/monitor'
;
@import
'./pages/note_form'
;
@import
'./pages/note_form'
;
...
...
app/assets/stylesheets/pages/merge_conflicts.scss
→
app/assets/stylesheets/page
_bundle
s/merge_conflicts.scss
View file @
f7e873c3
@import
'mixins_and_variables_and_functions'
;
// Disabled to use the color map for creating color schemes
// Disabled to use the color map for creating color schemes
// scss-lint:disable ColorVariable
// scss-lint:disable ColorVariable
$colors
:
(
$colors
:
(
...
@@ -240,14 +241,14 @@ $colors: (
...
@@ -240,14 +241,14 @@ $colors: (
right
:
10px
;
right
:
10px
;
padding
:
0
;
padding
:
0
;
outline
:
none
;
outline
:
none
;
color
:
$white
;
color
:
var
(
--
white
,
$white
)
;
width
:
75px
;
// static width to make 2 buttons have same width
width
:
75px
;
// static width to make 2 buttons have same width
height
:
19px
;
height
:
19px
;
}
}
}
}
.btn-success
.fa-spinner
{
.btn-success
.fa-spinner
{
color
:
$white
;
color
:
var
(
--
white
,
$white
)
;
}
}
.editor-wrap
{
.editor-wrap
{
...
@@ -263,7 +264,7 @@ $colors: (
...
@@ -263,7 +264,7 @@ $colors: (
&
.saved
{
&
.saved
{
.editor
{
.editor
{
border-top
:
solid
2px
$green-300
;
border-top
:
solid
2px
var
(
--
green-300
,
$green-300
)
;
}
}
}
}
...
@@ -282,10 +283,10 @@ $colors: (
...
@@ -282,10 +283,10 @@ $colors: (
}
}
.discard-changes-alert
{
.discard-changes-alert
{
background-color
:
$gray-light
;
background-color
:
var
(
--
gray-10
,
$gray-10
)
;
text-align
:
right
;
text-align
:
right
;
padding
:
$gl-padding-top
$gl-padding
;
padding
:
$gl-padding-top
$gl-padding
;
color
:
$gl-text-color
;
color
:
var
(
--
gl-text-color
,
$gl-text-color
)
;
.discard-actions
{
.discard-actions
{
display
:
inline-block
;
display
:
inline-block
;
...
...
app/views/projects/merge_requests/conflicts/show.html.haml
View file @
f7e873c3
-
page_title
_
(
"Merge Conflicts"
),
"
#{
@merge_request
.
title
}
(
#{
@merge_request
.
to_reference
}
"
,
_
(
"Merge Requests"
)
-
page_title
_
(
"Merge Conflicts"
),
"
#{
@merge_request
.
title
}
(
#{
@merge_request
.
to_reference
}
"
,
_
(
"Merge Requests"
)
-
add_page_specific_style
'page_bundles/merge_conflicts'
-
content_for
:page_specific_javascripts
do
-
content_for
:page_specific_javascripts
do
=
page_specific_javascript_tag
(
'lib/ace.js'
)
=
page_specific_javascript_tag
(
'lib/ace.js'
)
=
render
"projects/merge_requests/mr_title"
=
render
"projects/merge_requests/mr_title"
...
...
changelogs/unreleased/239852-move-merge-conflicts-to-page-bundle.yml
0 → 100644
View file @
f7e873c3
---
title
:
Add darkmode support for merge conflict page
merge_request
:
44168
author
:
type
:
other
config/application.rb
View file @
f7e873c3
...
@@ -191,6 +191,7 @@ module Gitlab
...
@@ -191,6 +191,7 @@ module Gitlab
config
.
assets
.
precompile
<<
"page_bundles/ide.css"
config
.
assets
.
precompile
<<
"page_bundles/ide.css"
config
.
assets
.
precompile
<<
"page_bundles/issues.css"
config
.
assets
.
precompile
<<
"page_bundles/issues.css"
config
.
assets
.
precompile
<<
"page_bundles/jira_connect.css"
config
.
assets
.
precompile
<<
"page_bundles/jira_connect.css"
config
.
assets
.
precompile
<<
"page_bundles/merge_conflicts.css"
config
.
assets
.
precompile
<<
"page_bundles/milestone.css"
config
.
assets
.
precompile
<<
"page_bundles/milestone.css"
config
.
assets
.
precompile
<<
"page_bundles/todos.css"
config
.
assets
.
precompile
<<
"page_bundles/todos.css"
config
.
assets
.
precompile
<<
"page_bundles/xterm.css"
config
.
assets
.
precompile
<<
"page_bundles/xterm.css"
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment