Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
f9cf1264
Commit
f9cf1264
authored
Dec 21, 2020
by
Albert Salim
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add maintainer engineering_productivity to roulette
parent
15c1a003
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
0 deletions
+9
-0
lib/gitlab/danger/teammate.rb
lib/gitlab/danger/teammate.rb
+1
-0
spec/lib/gitlab/danger/teammate_spec.rb
spec/lib/gitlab/danger/teammate_spec.rb
+8
-0
No files found.
lib/gitlab/danger/teammate.rb
View file @
f9cf1264
...
...
@@ -94,6 +94,7 @@ module Gitlab
when
:engineering_productivity
return
false
unless
role
[
/Engineering Productivity/
]
return
true
if
kind
==
:reviewer
return
true
if
capabilities
(
project
).
include?
(
"
#{
kind
}
engineering_productivity"
)
capabilities
(
project
).
include?
(
"
#{
kind
}
backend"
)
else
...
...
spec/lib/gitlab/danger/teammate_spec.rb
View file @
f9cf1264
...
...
@@ -121,6 +121,14 @@ RSpec.describe Gitlab::Danger::Teammate do
end
end
context
'when capabilities include maintainer engineering productivity'
do
let
(
:capabilities
)
{
[
'maintainer engineering_productivity'
]
}
it
'#maintainer? returns true'
do
expect
(
subject
.
maintainer?
(
project
,
:engineering_productivity
,
labels
)).
to
be_truthy
end
end
context
'when capabilities include trainee_maintainer backend'
do
let
(
:capabilities
)
{
[
'trainee_maintainer backend'
]
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment