Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
fb658f86
Commit
fb658f86
authored
Jun 19, 2020
by
Alex Buijs
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix group path autofill
parent
dad353e4
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
11 additions
and
6 deletions
+11
-6
ee/app/views/registrations/groups/new.html.haml
ee/app/views/registrations/groups/new.html.haml
+3
-2
ee/spec/features/registrations/new_group_spec.rb
ee/spec/features/registrations/new_group_spec.rb
+8
-4
No files found.
ee/app/views/registrations/groups/new.html.haml
View file @
fb658f86
...
...
@@ -14,7 +14,7 @@
.form-group.group-name-holder.col-sm-12
=
f
.
label
:name
,
class:
'label-bold'
do
=
_
(
'Group name (your organization)'
)
=
f
.
text_field
:name
,
class:
'form-control'
,
=
f
.
text_field
:name
,
class:
'form-control
js-autofill-group-name
'
,
required:
true
,
title:
_
(
'Please fill in a descriptive name for your group.'
),
autofocus:
true
...
...
@@ -27,7 +27,8 @@
.group-root-path.input-group-prepend.has-tooltip
{
title:
root_url
,
:'data-placement'
=>
'bottom'
}
.input-group-text
%span
=
root_url
=
f
.
text_field
:path
,
class:
'form-control js-validate-group-path'
,
=
f
.
hidden_field
:parent_id
=
f
.
text_field
:path
,
class:
'form-control js-validate-group-path js-autofill-group-path'
,
required:
true
,
pattern:
Gitlab
::
PathRegex
::
NAMESPACE_FORMAT_REGEX_JS
,
title:
_
(
'Please choose a group URL with no special characters.'
)
...
...
ee/spec/features/registrations/new_group_spec.rb
View file @
fb658f86
...
...
@@ -11,10 +11,14 @@ RSpec.describe 'New group screen', :js do
visit
new_users_sign_up_group_path
end
subject
{
page
}
it
'shows the progress bar with the correct steps'
do
expect
(
subject
).
to
have_content
(
'Create your group'
)
expect
(
subject
).
to
have_content
(
'1. Your profile 2. Your GitLab group 3. Your first project'
)
expect
(
page
).
to
have_content
(
'Create your group'
)
expect
(
page
).
to
have_content
(
'1. Your profile 2. Your GitLab group 3. Your first project'
)
end
it
'autofills the group path'
do
fill_in
'group_name'
,
with:
'test'
expect
(
page
).
to
have_field
(
'group_path'
,
with:
'test'
)
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment