Commit fb79d1e0 authored by Walmyr Lima's avatar Walmyr Lima

Standardize tests' descriptions

This is a change to standardize QA tests' descriptions of the
DevOps Plan stage to make all of them more natural to read together
with the `it` keyword.
parent 93666f4f
...@@ -3,7 +3,7 @@ ...@@ -3,7 +3,7 @@
module QA module QA
context 'Plan', :reliable do context 'Plan', :reliable do
describe 'check xss occurence in @mentions in issues', :requires_admin do describe 'check xss occurence in @mentions in issues', :requires_admin do
it 'user mentions a user in comment' do it 'mentions a user in a comment' do
QA::Runtime::Env.personal_access_token = QA::Runtime::Env.admin_personal_access_token QA::Runtime::Env.personal_access_token = QA::Runtime::Env.admin_personal_access_token
unless QA::Runtime::Env.personal_access_token unless QA::Runtime::Env.personal_access_token
......
...@@ -18,7 +18,7 @@ module QA ...@@ -18,7 +18,7 @@ module QA
push_commit('Initial commit') push_commit('Initial commit')
end end
it 'user closes an issue by pushing commit' do it 'closes an issue by pushing a commit' do
push_commit("Closes ##{issue_id}", false) push_commit("Closes ##{issue_id}", false)
issue.visit! issue.visit!
......
...@@ -17,7 +17,7 @@ module QA ...@@ -17,7 +17,7 @@ module QA
end end
end end
it 'user collapses and expands reply for comments in an issue' do it 'collapses and expands reply for comments in an issue' do
Page::Project::Issue::Show.perform do |show| Page::Project::Issue::Show.perform do |show|
one_reply = "1 reply" one_reply = "1 reply"
......
...@@ -9,7 +9,7 @@ module QA ...@@ -9,7 +9,7 @@ module QA
Resource::Issue.fabricate_via_api!.visit! Resource::Issue.fabricate_via_api!.visit!
end end
it 'user comments on an issue and edits the comment' do it 'comments on an issue and edits the comment' do
Page::Project::Issue::Show.perform do |show| Page::Project::Issue::Show.perform do |show|
first_version_of_comment = 'First version of the comment' first_version_of_comment = 'First version of the comment'
second_version_of_comment = 'Second version of the comment' second_version_of_comment = 'Second version of the comment'
......
...@@ -7,7 +7,7 @@ module QA ...@@ -7,7 +7,7 @@ module QA
Flow::Login.sign_in Flow::Login.sign_in
end end
it 'user creates an issue' do it 'creates an issue' do
issue = Resource::Issue.fabricate_via_browser_ui! issue = Resource::Issue.fabricate_via_browser_ui!
Page::Project::Menu.perform(&:click_issues) Page::Project::Menu.perform(&:click_issues)
...@@ -27,7 +27,7 @@ module QA ...@@ -27,7 +27,7 @@ module QA
Resource::Issue.fabricate_via_api!.visit! Resource::Issue.fabricate_via_api!.visit!
end end
it 'user comments on an issue with an attachment' do it 'comments on an issue with an attachment' do
Page::Project::Issue::Show.perform do |show| Page::Project::Issue::Show.perform do |show|
show.comment('See attached banana for scale', attachment: file_to_attach) show.comment('See attached banana for scale', attachment: file_to_attach)
......
...@@ -9,7 +9,7 @@ module QA ...@@ -9,7 +9,7 @@ module QA
Resource::Issue.fabricate_via_api!.visit! Resource::Issue.fabricate_via_api!.visit!
end end
it 'user filters comments and activities in an issue' do it 'filters comments and activities in an issue' do
Page::Project::Issue::Show.perform do |show| Page::Project::Issue::Show.perform do |show|
my_own_comment = "My own comment" my_own_comment = "My own comment"
made_the_issue_confidential = "made the issue confidential" made_the_issue_confidential = "made the issue confidential"
......
...@@ -13,7 +13,7 @@ module QA ...@@ -13,7 +13,7 @@ module QA
end.project.visit! end.project.visit!
end end
it 'user sees issue suggestions when creating a new issue' do it 'shows issue suggestions when creating a new issue' do
Page::Project::Show.perform(&:go_to_new_issue) Page::Project::Show.perform(&:go_to_new_issue)
Page::Project::Issue::New.perform do |new_page| Page::Project::Issue::New.perform do |new_page|
new_page.add_title("issue") new_page.add_title("issue")
......
...@@ -20,7 +20,7 @@ module QA ...@@ -20,7 +20,7 @@ module QA
end.visit! end.visit!
end end
it 'user mentions another user in an issue' do it 'mentions another user in an issue' do
Page::Project::Issue::Show.perform do |show| Page::Project::Issue::Show.perform do |show|
at_username = "@#{@user.username}" at_username = "@#{@user.username}"
......
...@@ -13,7 +13,7 @@ module QA ...@@ -13,7 +13,7 @@ module QA
@fixed_due_date = (Date.today.to_date + 90).strftime("%Y-%m-%d") @fixed_due_date = (Date.today.to_date + 90).strftime("%Y-%m-%d")
end end
it 'Updating milestones changes epic dates' do it 'changes epic dates when updating milestones' do
epic_iid, milestone_id = create_epic_issue_milestone epic_iid, milestone_id = create_epic_issue_milestone
milestone_start_date = Date.today.to_date.strftime("%Y-%m-%d") milestone_start_date = Date.today.to_date.strftime("%Y-%m-%d")
milestone_due_date = (Date.today.to_date + 30).strftime("%Y-%m-%d") milestone_due_date = (Date.today.to_date + 30).strftime("%Y-%m-%d")
...@@ -34,7 +34,7 @@ module QA ...@@ -34,7 +34,7 @@ module QA
expect_json('due_date', milestone_due_date) expect_json('due_date', milestone_due_date)
end end
it 'Adding another issue updates epic dates' do it 'updates epic dates when adding another issue' do
epic_iid = create_epic_issue_milestone[0] epic_iid = create_epic_issue_milestone[0]
milestone_start_date = Date.today.to_date.strftime("%Y-%m-%d") milestone_start_date = Date.today.to_date.strftime("%Y-%m-%d")
milestone_due_date = (Date.today.to_date + 150).strftime("%Y-%m-%d") milestone_due_date = (Date.today.to_date + 150).strftime("%Y-%m-%d")
...@@ -57,7 +57,7 @@ module QA ...@@ -57,7 +57,7 @@ module QA
expect_json('due_date', milestone_due_date) expect_json('due_date', milestone_due_date)
end end
it 'Removing issue updates epic dates' do it 'updates epic dates when removing issue' do
epic_iid = create_epic_issue_milestone[0] epic_iid = create_epic_issue_milestone[0]
# Get epic_issue_id # Get epic_issue_id
...@@ -82,7 +82,7 @@ module QA ...@@ -82,7 +82,7 @@ module QA
expect_json('due_date', nil) expect_json('due_date', nil)
end end
it 'Deleting milestones updates epic dates' do it 'updates epic dates when deleting milestones' do
epic_iid, milestone_id = create_epic_issue_milestone epic_iid, milestone_id = create_epic_issue_milestone
# Delete Milestone # Delete Milestone
......
...@@ -3,7 +3,7 @@ ...@@ -3,7 +3,7 @@
module QA module QA
context 'Plan', :reliable do context 'Plan', :reliable do
describe 'promote issue to epic' do describe 'promote issue to epic' do
it 'user promotes issue to an epic' do it 'promotes issue to epic' do
Flow::Login.sign_in Flow::Login.sign_in
project = Resource::Project.fabricate_via_api! do |project| project = Resource::Project.fabricate_via_api! do |project|
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment