Update external_link to use GitLab SVG

app/helpers/external_link_helper.rb

@@ -3,7 +3,7 @@
 module ExternalLinkHelper
   def external_link(body, url, options = {})
     link_to url, { target: '_blank', rel: 'noopener noreferrer' }.merge(options) do
-      "#{body} #{icon('external-link')}".html_safe
+      "#{body} #{sprite_icon('external-link')}".html_safe
     end
   end
 end

spec/helpers/external_link_helper_spec.rb

@@ -6,12 +6,15 @@ RSpec.describe ExternalLinkHelper do
   include IconsHelper
 
   it 'returns external link with icon' do
-    expect(external_link('https://gitlab.com', 'https://gitlab.com').to_s)
-      .to eq('<a target="_blank" rel="noopener noreferrer" href="https://gitlab.com">https://gitlab.com <i aria-hidden="true" data-hidden="true" class="fa fa-external-link"></i></a>')
+    link = external_link('https://gitlab.com', 'https://gitlab.com').to_s
+    expect(link).to start_with('<a target="_blank" rel="noopener noreferrer" href="https://gitlab.com">https://gitlab.com')
+    expect(link).to include('data-testid="external-link-icon"')
   end
 
   it 'allows options when creating external link with icon' do
-    expect(external_link('https://gitlab.com', 'https://gitlab.com', { "data-foo": "bar", class: "externalLink" }).to_s)
-      .to eq('<a target="_blank" rel="noopener noreferrer" data-foo="bar" class="externalLink" href="https://gitlab.com">https://gitlab.com <i aria-hidden="true" data-hidden="true" class="fa fa-external-link"></i></a>')
+    link = external_link('https://gitlab.com', 'https://gitlab.com', { "data-foo": "bar", class: "externalLink" }).to_s
+
+    expect(link).to start_with('<a target="_blank" rel="noopener noreferrer" data-foo="bar" class="externalLink" href="https://gitlab.com">https://gitlab.com')
+    expect(link).to include('data-testid="external-link-icon"')
   end
 end