Improve tests for security report page

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

ee/spec/controllers/projects/pipelines_controller_spec.rb

@@ -17,6 +17,7 @@ describe Projects::PipelinesController do
       before do
         create(
           :ci_build,
+          :success,
           :artifacts,
           name: 'sast',
           pipeline: pipeline,
@@ -26,24 +27,56 @@ describe Projects::PipelinesController do
             }
           }
         )
+      end
+
+      context 'with feature enabled' do
+        before do
+          allow(License).to receive(:feature_available?).and_return(true)
 
-        get :security, namespace_id: project.namespace, project_id: project, id: pipeline
+          get :security, namespace_id: project.namespace, project_id: project, id: pipeline
+        end
+
+        it do
+          expect(response).to have_gitlab_http_status(200)
+          expect(response).to render_template :show
+        end
       end
 
-      it do
-        expect(response).to have_gitlab_http_status(200)
-        expect(response).to render_template :show
+      context 'with feature disabled' do
+        before do
+          get :security, namespace_id: project.namespace, project_id: project, id: pipeline
+        end
+
+        it do
+          expect(response).to have_gitlab_http_status(:redirect)
+          expect(response).to redirect_to(pipeline_path(pipeline))
+        end
       end
     end
 
     context 'without sast artifact' do
-      before do
-        get :security, namespace_id: project.namespace, project_id: project, id: pipeline
+      context 'with feature enabled' do
+        before do
+          allow(License).to receive(:feature_available?).and_return(true)
+
+          get :security, namespace_id: project.namespace, project_id: project, id: pipeline
+        end
+
+        it do
+          expect(response).to have_gitlab_http_status(:redirect)
+          expect(response).to redirect_to(pipeline_path(pipeline))
+        end
       end
 
-      it do
-        expect(response).to have_gitlab_http_status(:redirect)
-        expect(response).to redirect_to(pipeline_path(pipeline))
+      context 'with feature disabled' do
+        before do
+          get :security, namespace_id: project.namespace, project_id: project, id: pipeline
+        end
+
+        it do
+          expect(response).to have_gitlab_http_status(:redirect)
+          expect(response).to redirect_to(pipeline_path(pipeline))
+        end
       end
     end
   end

ee/spec/features/projects/pipelines/pipeline_spec.rb

@@ -7,6 +7,8 @@ describe 'Pipeline', :js do
   before do
     sign_in(user)
     project.add_developer(user)
+
+    allow(License).to receive(:feature_available?).and_return(true)
   end
 
   describe 'GET /:project/pipelines/:id/security' do
@@ -16,6 +18,7 @@ describe 'Pipeline', :js do
       before do
         create(
           :ci_build,
+          :success,
           :artifacts,
           name: 'sast',
           pipeline: pipeline,