Use preload instead of includes to avoid joins

feb34497 · Matija Čupić · 8cef1f4c · feb34497 · feb34497
Commit feb34497 authored Jan 15, 2018 by Matija Čupić
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

lib/api/jobs.rb lib/api/jobs.rb +1 -1

lib/api/v3/builds.rb lib/api/v3/builds.rb +1 -1

No files found.
--- a/lib/api/jobs.rb
+++ b/lib/api/jobs.rb
@@ -38,7 +38,7 @@ module API
        builds = user_project.builds.order('id DESC')
        builds = filter_builds(builds, params[:scope])

-        builds = builds.includes(:user, :job_artifacts_archive, :runner, pipeline: :project)
+        builds = builds.preload(:user, :job_artifacts_archive, :runner, pipeline: :project)
        present paginate(builds), with: Entities::Job
      end


--- a/lib/api/v3/builds.rb
+++ b/lib/api/v3/builds.rb
@@ -36,7 +36,7 @@ module API
          builds = user_project.builds.order('id DESC')
          builds = filter_builds(builds, params[:scope])

-          builds = builds.includes(:user, :job_artifacts_archive, :runner, pipeline: :project)
+          builds = builds.preload(:user, :job_artifacts_archive, :runner, pipeline: :project)
          present paginate(builds), with: ::API::V3::Entities::Build
        end