- 06 Aug, 2020 2 commits
-
-
Sean McGivern authored
Fetching all references for a repository uses SMEMBERS, which can be quite slow. We need to fetch all references to resolve ambiguities in certain edge cases. However, most references do not contain a slash, and most repositories do not contain ambiguous references (where a tag is a prefix of a branch or vice versa). In those cases, we can trade two slow-ish Redis calls (SMEMBERS to get all tags and branches) for a maximum of four much faster Redis calls, because they are all GETs: 1. One for the feature flag (which will go away in future hopefully). 2. One to check if the repository has ambiguous refs. 3. One for checking membership of branch names. 4. One for checking membership of tag names (only if we didn't match a branch). In the worst case - when the repository does not contain ambiguous refs - we add those calls to the existing calls, but this should still not be a huge amount of overhead in that case. When the feature flag is disabled (which is the default), we're just adding a single GET.
-
Sean McGivern authored
A branch can't be a prefix (including a slash) of another branch. For instance, you can't have a branch `a` and a branch `a/b`. Same with tags. However, you can have a branch `a` and a tag `a/b`, which is ambiguous. In ExtractsRef, we do some work to handle these cases. That can involve a fairly slow Redis SMEMBERS call. If a repository has no ambiguous refs of this form (which should be the majority), we can perform some optimisations. For the purposes of this method, we only consider refs ambiguous before the first slash. If we have a branch `a/b/c` and a tag `a/b`, this method won't detect that.
-
- 05 Aug, 2020 38 commits
-
-
Markus Koller authored
Upgrade to Git v2.28.0 See merge request gitlab-org/gitlab!38152
-
Robert Speicher authored
Updates security templates to mention edge cases See merge request gitlab-org/gitlab!38708
-
Douglas Barbosa Alexandre authored
Avoid writing empty stage variable See merge request gitlab-org/gitlab!38631
-
Igor Drozdov authored
Add internal api for getting personal access tokens from gitlab-shell See merge request gitlab-org/gitlab!36302
-
Dan Davison authored
Re-add data-qa selector Closes #229724 See merge request gitlab-org/gitlab!38055
-
Sarah Groff Hennigh-Palermo authored
-
Michael Kozono authored
Remove FDW related code for project/wikis Closes #223249 See merge request gitlab-org/gitlab!38417
-
Dan Davison authored
Fix duplicate button issue in monitor core spec See merge request gitlab-org/gitlab!38482
-
Mayra Cabrera authored
* Renames 'Security Release' template to 'Security Release Tracking Issue' * Remove unnecessary section from the Security Release Tracking Issue (such as QA) * Add an item to the 'Security Developer Workflow' to specify issues with less than 4 MR associated need to be notified to Release Managers
-
Robert Speicher authored
Optimise ExtractsRef when there is no slash See merge request gitlab-org/gitlab!38343
-
Jarka Košanová authored
Adds urls to package presenter See merge request gitlab-org/gitlab!38518
-
Enrique Alcántara authored
Add metrics dashboard templates for the standard selector See merge request gitlab-org/gitlab!37519
-
Amy Qualls authored
Revise the Status Page doc for tone and style See merge request gitlab-org/gitlab!37864
-
Amy Qualls authored
Start revising the Status Page documentation for tone, style, and completeness.
-
Craig Norris authored
Add metadata to more Configure pages Closes #233532 See merge request gitlab-org/gitlab!38702
-
Enrique Alcántara authored
Replace deprecated button Closes #219901 See merge request gitlab-org/gitlab!38668
-
-
Amy Qualls authored
The Configure team has taken ownership of a few more pages, so this MR adds metadata to them.
-
Sean McGivern authored
[RUN AS-IF-FOSS] Resolve Style/NumericPredicate Cop exceptions in lib See merge request gitlab-org/gitlab!38333
-
Stan Hu authored
Add relative positioning on designs See merge request gitlab-org/gitlab!37835
-
Jose Vargas authored
This adds the metrics dashboard templates to the file template selector in the standard editor from the repository view
-
Sean McGivern authored
Show only root namespaces for subscriptions See merge request gitlab-org/gitlab!38481
-
Natalia Tepluhina authored
Change query to request incidents by issue type See merge request gitlab-org/gitlab!38503
-
Sean McGivern authored
Enable similarity search feature flags by default Closes #221043 See merge request gitlab-org/gitlab!38675
-
Olena Horal-Koretska authored
Hide health status labels for closed issues on epics tree See merge request gitlab-org/gitlab!37561
-
Eulyeon Ko authored
Show health status only for open issues Update the mock data as well Update the doc Update the spec Replace more utility classes Update the display condition for epics Use parameterized tests in the spec Update the mock data Apply 1 suggestion(s) to 1 file(s)
-
Bob Van Landuyt authored
Add ability to query DAST scanner profiles See merge request gitlab-org/gitlab!38126
-
Marcel Amirault authored
Add when: never details See merge request gitlab-org/gitlab!37761
-
Ben Bodenmiller authored
-
Ezekiel Kigbo authored
Resolve "Take DAG visualization out of beta" See merge request gitlab-org/gitlab!38517
-
Frédéric Caplette authored
We remove the beta tag on the tab, the beta alert message in the view and all documentation that mentioned the dag view as a beta feature.
-
Patrick Steinhardt authored
-
Patrick Steinhardt authored
Gitaly is moving its minimum required version of Git to v2.28.0. Adjust our documentation to match.
-
Patrick Steinhardt authored
The Git version check hasn't been updated in a while and is still at v2.22.0, even though the minimum required version of Git is in fact v2.25.0. Now that Gitaly has bumped its requirements to v2.28.0, let's fix the system check to match.
-
Patrick Steinhardt authored
As Git v2.28.0 has been released and Gitaly has the intention to make it the minimum required version, let's update GitLab's CI to use the new version.
-
Imre Farkas authored
Process panels YAML to JSON See merge request gitlab-org/gitlab!38279
-
Sean McGivern authored
Add support for files in ProjectSnippets REST API See merge request gitlab-org/gitlab!38485
-
Adam Hegyi authored
This change enables the following feature flags by default: - analytics_similarity_search - similarity_search
-