- 21 Jan, 2020 40 commits
-
-
Nick Thomas authored
Prior to this commit, if we wanted to compare changes between two branches in different repositories - for instance, creating an MR from a fork child to a fork parent - the commits for the fork child end up in the fork parent's repository. Even if no MR is created, the commits remain accessible until a garbage collection run is completed. Since GitLab acts as a SHA oracle, these commits can be found by anyone with access to the target project, which has a security impact. Forks are not allowed to be more visible than their parents, but they are allowed to be less visible, so putting their commits into the fork parent is a bad idea. Instead, we can do the comparison in the fork child's repository; the commit for the target branch can be fetched with the same mechanism we use for child -> parent fetches at the moment. This prevents disclosure in the most common case. This should also have a positive performance impact - a fork child will already have the commit from the fork parent far more often than the fork parent, so we'll need to do fetches less often. Even though this is a security fix, I pulled the code for the affected method out into a separate class to make the changes clearer. Roughly the same number of lines are removed or altered; a few more are added, but I think the increased clarity is worthwhile in this case.
-
Andreas Brandl authored
Update timestamp values for software license policies See merge request gitlab-org/gitlab!23197
-
Marcia Ramos authored
Soften warning about spam email to remove mention of service disruption See merge request gitlab-org/gitlab!23404
-
Mark Wood authored
-
Nick Thomas authored
Revert short acme order expiration time See merge request gitlab-org/gitlab!23399
-
Jan Provaznik authored
Refactor `spammable_owner_id` method See merge request gitlab-org/gitlab!23224
-
Imre Farkas authored
Fix POST method in dashboard link for disabling admin mode See merge request gitlab-org/gitlab!23363
-
Diego Louzán authored
The link for bigger screen sizes has incorrectly GET as method
-
Achilleas Pipinellis authored
Fix typo in warning related to Auto DevOps See merge request gitlab-org/gitlab!23354
-
celdem authored
-
Achilleas Pipinellis authored
Update doc/ci/yaml/README.md See merge request gitlab-org/gitlab!20233
-
Seth Berger authored
-
Natalia Tepluhina authored
Cycle Analytics 'Tasks by Type' Chart Filters See merge request gitlab-org/gitlab!22936
-
Ezekiel Kigbo authored
Moves the subject filter into the new charts filter component and also adds a label filter Ensure the menu drops down to the right
-
Nick Thomas authored
Check mergeability of MR asynchronously See merge request gitlab-org/gitlab!21026
-
Patrick Bajao authored
Executing `MergeRequests::MergeabilityCheckService#execute` can be time consuming and can likely cause a request to timeout. Moving its execution asynchronously via `#async_execute` will help in ensuring page and API requests that needs it can load faster.
-
Douglas Barbosa Alexandre authored
Add milestone issues display limit See merge request gitlab-org/gitlab!23102
-
Rémy Coutable authored
Fix broken QA test Closes #197486 See merge request gitlab-org/gitlab!23328
-
Marcia Ramos authored
Docs: review previous blame doc See merge request gitlab-org/gitlab!23357
-
Marcia Ramos authored
-
Peter Leitzen authored
Add Aggregate Failures block See merge request gitlab-org/gitlab!23303
-
Mark Florian authored
Rename whilst to while See merge request gitlab-org/gitlab!23287
-
Nick Thomas authored
Adds calls_gitaly to the commit type in GraphQL See merge request gitlab-org/gitlab!23322
-
Sean McGivern authored
Add seed file for container images See merge request gitlab-org/gitlab!23330
-
Bob Van Landuyt authored
Fix create/delete API calls for approval rules See merge request gitlab-org/gitlab!23107
-
Heinrich Lee Yu authored
Add app validation for any-approver rule uniqueness See merge request gitlab-org/gitlab!23241
-
Natalia Tepluhina authored
Merge branch '118862-change-dashboard_spec-js-queryselector-based-specs-to-use-find-instead' into 'master' Use find instead of querySelector in dashboard_spec.js Closes #118862 See merge request gitlab-org/gitlab!23314
-
David Fernandez authored
-
Vladimir Shushlin authored
This reverts merge request !22878
-
Dmytro Zaporozhets authored
Close related issue after error resolve See merge request gitlab-org/gitlab!22744
-
Igor Drozdov authored
This would save us from 500 error raised by database
-
Evan Read authored
Expand options for e.g. See merge request gitlab-org/gitlab!23207
-
Russell Dickenson authored
Add version text for new error content See merge request gitlab-org/gitlab!23386
-
Evan Read authored
-
Evan Read authored
Add days to completion chart median line to cycle analytics docs See merge request gitlab-org/gitlab!23062
-
Brandon Labuschagne authored
-
Russell Dickenson authored
Edit new content for keys API Closes #197990 See merge request gitlab-org/gitlab!23384
-
Marcel Amirault authored
Add language tags to code blocks See merge request gitlab-org/gitlab!23208
-
Amy Qualls authored
Code blocks should specify the language the code is in, so we can enforce a markdownlint rule.
-
Marcel Amirault authored
Document CI job activity limit See merge request gitlab-org/gitlab!23246
-