An error occurred fetching the project authors.
  1. 16 Aug, 2016 3 commits
  2. 15 Aug, 2016 6 commits
  3. 14 Aug, 2016 1 commit
    • Ahmad Sherif's avatar
      Fix a memory leak caused by Banzai::Filter::SanitizationFilter · 504a3b5e
      Ahmad Sherif authored
      In Banzai::Filter::SanitizationFilter#customize_whitelist, we append
      three lambdas that has reference to the SanitizationFilter instance,
      which in turn (potentially) has a reference to the following chain:
      
      context hash -> Project instance -> Repository instance -> lookup hash
      -> various Rugged instances -> various mmap-ed git pack files.
      
      All of the above is not garbage collected because the array we append
      the lambdas to is the constant
      HTML::Pipeline::SanitizationFilter::WHITELIST.
      504a3b5e
  4. 12 Aug, 2016 3 commits
  5. 11 Aug, 2016 17 commits
    • Stan Hu's avatar
      Fix bug where destroying a namespace would not always destroy projects · cb8a425b
      Stan Hu authored
      There is a race condition in DestroyGroupService now that projects are deleted asynchronously:
      
      1. User attempts to delete group
      2. DestroyGroupService iterates through all projects and schedules a Sidekiq job to delete each Project
      3. DestroyGroupService destroys the Group, leaving all its projects without a namespace
      4. Projects::DestroyService runs later but the can?(current_user,
         :remove_project) is `false` because the user no longer has permission to
         destroy projects with no namespace.
      5. This leaves the project in pending_delete state with no namespace/group.
      
      Projects without a namespace or group also adds another problem: it's not possible to destroy the container
      registry tags, since container_registry_path_with_namespace is the wrong value.
      
      The fix is to destroy the group asynchronously and to run execute directly on Projects::DestroyService.
      
      Closes #17893
      cb8a425b
    • ula budziszewska's avatar
      Update CHANGELOG · c5aca8b2
      ula budziszewska authored
      c5aca8b2
    • ubudzisz's avatar
      render only commit title · 957632b7
      ubudzisz authored
      update CHANGELOG
      
      add auto-completion into pipeline
      
      add auto-completion into pipeline
      
      add auto-completion into pipeline
      
      update changelog
      
      modify tests
      
      remove empty lines
      
      add auto-completion into pipeline
      
      update changelog
      
      modify tests
      
      switch text_field_tag into text_field
      
      add test to new field
      
      switch context into describe
      
      Update CHANGELOG
      
      render only commit title
      
      update CHANGELOG
      
      add auto-completion into pipeline
      
      add auto-completion into pipeline
      
      add auto-completion into pipeline
      
      update changelog
      
      modify tests
      
      remove empty lines
      
      add auto-completion into pipeline
      
      update changelog
      
      modify tests
      
      update changelog
      
      Update CHANGELOG
      
      add indetation
      
      add tests to pipeline ref
      
      change file name for tests
      
      change file name for spec tests
      
      remove empty line
      
      rename test it
      
      rename test name
      
      removing unexpected changes
      
      removing unexpected changes2
      
      update changelog
      957632b7
    • Z.J. van de Weg's avatar
      Incorporate feedback · b497b0ce
      Z.J. van de Weg authored
      b497b0ce
    • Z.J. van de Weg's avatar
      Show deployment status on a MR view · 49f72e70
      Z.J. van de Weg authored
      49f72e70
    • Z.J. van de Weg's avatar
      3b973d18
    • Connor Shea's avatar
      9f9e38ff
    • Scott Le's avatar
      api for generating new merge request · 6109daf4
      Scott Le authored
      DRY code + fix rubocop
      
      Add more test cases
      
      Append to changelog
      
      DRY changes list
      
      find_url service for merge_requests
      
      use GET for getting merge request links
      
      remove files
      
      rename to get_url_service
      
      reduce loop
      
      add test case for cross project
      
      refactor tiny thing
      
      update changelog
      6109daf4
    • Douwe Maan's avatar
      32b579e8
    • Christopher Bartz's avatar
    • Kamil Trzcinski's avatar
      Pre-create all builds for Pipeline when a trigger is received · 39203f1a
      Kamil Trzcinski authored
      This change simplifies a Pipeline processing by introducing a special new status: created.
      This status is used for all builds that are created for a pipeline.
      We are then processing next stages and queueing some of the builds (created -> pending) or skipping them (created -> skipped).
      This makes it possible to simplify and solve a few ordering problems with how previously builds were scheduled.
      This also allows us to visualise a full pipeline (with created builds).
      
      This also removes an after_touch used for updating a pipeline state parameters.
      Right now in various places we explicitly call a reload_status! on pipeline to force it to be updated and saved.
      39203f1a
    • Elliot's avatar
    • Yorick Peterse's avatar
      Remove various redundant indexes · 7d39bc87
      Yorick Peterse authored
      One can see which indexes are used in PostgreSQL by running the
      following query:
      
          SELECT relname as table_name, indexrelname as index_name, idx_scan, idx_tup_read, idx_tup_fetch, pg_size_pretty(pg_relation_size(indexrelname::regclass))
          FROM pg_stat_all_indexes
          WHERE schemaname = 'public'
          AND "idx_scan" = 0
          ORDER BY pg_relation_size(indexrelname::regclass) desc;
      
      Using this query I built a list of indexes that could be potentially
      removed. After checking every single one by hand to make sure they
      really aren't used I only found 1 index that _would_ be used. This was a
      GitLab GEO index (EE) specific that's currently not used simply because
      the table is empty.
      
      Apart from this one index all indexes could be removed. The migration
      also takes care of 6 composite indexes that can be replaced with a
      single column index, which in most cases was already present.
      
      For more information see gitlab-org/gitlab-ce#20767.
      7d39bc87
    • bogdanvlviv's avatar
      Use `File::exist?` instead of `File::exists?` · 96ebc8c4
      bogdanvlviv authored
      Since version ruby-2.2.0, method `File::exists?` is deprecated.
      96ebc8c4
    • James Lopez's avatar
    • Thomas Balthazar's avatar
      fb748daf
    • Keith Pope's avatar
      Update/Improve OAuth2 Client documentation · 9a9f4027
      Keith Pope authored
      9a9f4027
  6. 10 Aug, 2016 8 commits
  7. 09 Aug, 2016 2 commits