- 06 Apr, 2017 8 commits
-
-
Timothy Andrew authored
1. Have `MigrateToGhostUser` be a service rather than a mixed-in module, to keep things explicit. Specs testing the behavior of this class are moved into a separate service spec file. 2. Add a `user.reported_abuse_reports` association to make the `migrate_abuse_reports` method more consistent with the other `migrate_` methods.
-
Timothy Andrew authored
-
Timothy Andrew authored
-
Timothy Andrew authored
... when the user is destroyed. 1. Normally, for a given awardable and award emoji name, a user is only allowed to create a single award emoji. 2. This validation needs to be removed for ghost users, since: - User A and User B have created award emoji - with the same name and against the same awardable - User A is deleted. Their award emoji is moved to the ghost user - User B is deleted. Their award emoji needs to be moved to the ghost user. However, this breaks the uniqueness validation, since the ghost user is only allowed to have one award emoji of a given name for a given awardable
-
Timothy Andrew authored
... when the user is destroyed. To clarify, this regards abuse reports that the to-be-deleted user has _reported_.
-
Timothy Andrew authored
Introduction ------------ 1. The foreign key was not explicitly specified on the association. 2. The `AbuseReport` model contains two references to user - `reporter_id` and `user_id` 3. `user.abuse_report` is supposed to return the single abuse report where `user_id` refers to the given user. Bug Description --------------- 1. `user.abuse_report` would return an abuse report where `reporter_id` referred to the current user, if such an abuse report was present. 2. This implies a slightly more serious bug as well: - Assume User A filed an abuse report against User B - We have an abuse report where `reporter_id` is User A and `user_id` is User B - If User A is updated (`user_a.block`, for example), the abuse report would also be updated, such that both `reporter_id` _and_ `user_id` point to User A. Fix --- Explicitly declare the foreign key `user_id` in the `has_one` declaration
-
Timothy Andrew authored
... when the user is destroyed.
-
Timothy Andrew authored
1. When the user is deleted. 2. Refactor out code relating to "migrating records to the ghost user" into a `MigrateToGhostUser` concern, which is tested using a shared example.
-
- 04 Apr, 2017 3 commits
-
-
Robert Speicher authored
Don't use FFaker in factories, use sequences instead Closes #29643 See merge request !10184
-
Robert Speicher authored
Ensure users have a short username otherwise a click event is triggered outside the search field Closes #29241 See merge request !10411
-
Rémy Coutable authored
Quiet pipeline emails Closes #24845 See merge request !10333
-
- 03 Apr, 2017 29 commits
-
-
Stan Hu authored
Enable the `bullet_logger` setting; enable `raise` in test environment Closes #30129 See merge request !10263
-
Rémy Coutable authored
Log errors in UpdatePagesService See merge request !10335
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Robert Speicher authored
Improve performance of GitHub importer Closes #28183 See merge request !10273
-
Robert Speicher authored
-
Kamil Trzciński authored
Remove deprecated code from pipeline processing service Closes #30052 See merge request !10266
-
Douwe Maan authored
Fix race condition in namespace directory creation See merge request !10268
-
Robert Speicher authored
Add support for Gitaly calls over TCP connection Closes gitaly#166 See merge request !10410
-
Robert Speicher authored
Add feature flags for enabling (Upload|Receive)Pack Closes gitaly#168 See merge request !10341
-
Douglas Barbosa Alexandre authored
-
Douglas Barbosa Alexandre authored
-
Douglas Barbosa Alexandre authored
-
Douglas Barbosa Alexandre authored
-
Douglas Barbosa Alexandre authored
-
Douglas Barbosa Alexandre authored
-
Douglas Barbosa Alexandre authored
-
Douglas Barbosa Alexandre authored
-
Douglas Barbosa Alexandre authored
-
Douglas Barbosa Alexandre authored
-
Alfredo Sumaran authored
Make file templates easy to use and discover Closes #25332 See merge request !9782
-
Bryce Johnson authored
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
FFaker can generate data that randomly break our test suite. This simplifies our factories and use sequences which are more predictive. Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
Enable Style/Proc cop for rubocop See merge request !10382
-
Ahmad Sherif authored
Closes gitaly#166
-