- 30 Apr, 2019 1 commit
-
-
Stan Hu authored
We've seen a significant performance penalty when using `BatchLoader#__replace_with!`. This defines methods on the batch loader that proxy to the 'real' object using send. The alternative is `method_missing`, which is slower. However, we've noticed that `method_missing` can be faster if: 1. The objects being loaded have a large interface. 2. We don't call too many methods on the loaded object. Avatar uploads meet both criteria above, so let's use the newly-released feature in https://github.com/exAspArk/batch-loader/pull/45. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60903
-
- 29 Apr, 2019 39 commits
-
-
Annabel Dunstone Gray authored
Fixed boards card dragging styling Closes #61050 See merge request gitlab-org/gitlab-ce!27802
-
Tim Zallmann authored
Fix base domain help text update Closes #61036 See merge request gitlab-org/gitlab-ce!27746
-
Tim Zallmann authored
Internationalisation of javascript/m* directories See merge request gitlab-org/gitlab-ce!27723
-
Brandon Labuschagne authored
This is one of many MRs opened in order to improve the overall internationalisation of the GitLab codebase. i18n documentation https://docs.gitlab.com/ee/development/i18n/externalization.html
-
Tim Zallmann authored
Internationalisation of vue_shared directory See merge request gitlab-org/gitlab-ce!27751
-
Brandon Labuschagne authored
This is one of many MRs opened in order to improve the overall internationalisation of the GitLab codebase. This commit only targets the Vanilla JS files. i18n documentation https://docs.gitlab.com/ee/development/i18n/externalization.html
-
Clement Ho authored
Update dependency @gitlab/ui to ^3.7.0 See merge request gitlab-org/gitlab-ce!27832
-
Rémy Coutable authored
Resolve "Project is being serialized when enqueueing to sidekiq" Closes #59265 See merge request gitlab-org/gitlab-ce!27825
-
Stan Hu authored
Prevent concurrent execution of PipelineScheduleWorker Closes gitlab-com/gl-infra/production#805 See merge request gitlab-org/gitlab-ce!27781
-
Robert Speicher authored
Change comments to point to the new path of sidekiq-cluster See merge request gitlab-org/gitlab-ce!27707
-
Stan Hu authored
Upgrade letter_opener_web to support Rails 5.1 See merge request gitlab-org/gitlab-ce!27829
-
Peter Leitzen authored
Before this commit using `/rails/letter_opener` in `development` environment failed with: undefined method `before_filter' See https://github.com/fgrehm/letter_opener_web/issues/68 This commit upgrades `letter_opener_web` to 1.3.4 so Rails 5.1 is supported.
-
Sean McGivern authored
Add full backtrace for RSpec output See merge request gitlab-org/gitlab-ce!27686
-
Stan Hu authored
Upgrade Gitaly to v1.36.0 See merge request gitlab-org/gitlab-ce!27831
-
GitalyBot authored
-
Sean McGivern authored
Make `CI_COMMIT_REF_NAME` and `SLUG` variable idempotent Closes #60822 See merge request gitlab-org/gitlab-ce!27663
-
Sanad Liaquat authored
Move test method to the bottom See merge request gitlab-org/gitlab-ce!27816
-
Phil Hughes authored
Internationalisation of cycle_analytics directory See merge request gitlab-org/gitlab-ce!27674
-
Brandon Labuschagne authored
This is one of many MRs opened in order to improve the overall internationalisation of the GitLab codebase. i18n documentation https://docs.gitlab.com/ee/development/i18n/externalization.html
-
Lukas 'Eipi' Eipert authored
-
Annabel Dunstone Gray authored
Format extra help page text like wiki Closes #55948 See merge request gitlab-org/gitlab-ce!26782
-
Fatih Acet authored
CE Backport: Prefer usage of helper `expanded_by_default?` See merge request gitlab-org/gitlab-ce!27729
-
Peter Leitzen authored
Stop using `Rails.env.test?` in views.
-
Phil Hughes authored
CE: Fixes EE differences for app/views/projects/new.html.haml See merge request gitlab-org/gitlab-ce!27617
-
Douglas Barbosa Alexandre authored
Use keyword args for databuilder push See merge request gitlab-org/gitlab-ce!24088
-
Sean McGivern authored
`Todos::Destroy::EntityLeaveService#project_ids` was returning ActiveRecord objects with IDs, not simply IDs. That means we were serialising more than we needed to in Sidekiq. We can simply rename this method to `#projects` as this class doesn't use any of the superclass methods that would use `#project_ids`.
-
John T Skarbek authored
-
Fatih Acet authored
Internationalisation of groups directory See merge request gitlab-org/gitlab-ce!27679
-
Brandon Labuschagne authored
This is one of many MRs opened in order to improve the overall internationalisation of the GitLab codebase. i18n documentation https://docs.gitlab.com/ee/development/i18n/externalization.html
-
Stan Hu authored
Attempt to debug https://gitlab.com/gitlab-org/gitlab-ce/issues/60953
-
Sean McGivern authored
Fix slow performance with compiling HAML templates Closes gitlab-ee#11198 See merge request gitlab-org/gitlab-ce!27782
-
Stan Hu authored
-
GitLab Release Tools Bot authored
Disallow read user scope to read project events See merge request gitlab/gitlabhq!3067
-
Stan Hu authored
In Rails 5, including `ActionView::Context` can have a significant and hidden performance penalty because this module also includes `ActionView::CompiledTemplates`. This means that any module that includes ActionView::Context becomes a descendant of `CompiledTemplates`. When a partial is rendered for the first time, it runs `ActionView::CompiledTemplates#module_eval`, which will evaluate a string that defines a new method for that partial. For example, the source of partial might be this string: ``` def _app_views_project_show_html_haml___12345(local_assigns, output) "hello world" end ``` When this string is evaluated, the Ruby interpreter will define the method and clear the global method cache for all descendants of `ActionView::CompiledTemplates`. Previous to this change, we inadvertently made a number of modules fall into this category: * GroupChildEntity * NoteUserEntity * Notify * MergeRequestUserEntity * AnalyticsCommitEntity * CommitEntity * UserEntity * Kaminari::Helpers::Paginator * CurrentUserEntity * ActionView::Base * ActionDispatch::DebugExceptions::DebugView * MarkupHelper * MergeRequestPresenter After this change: * Kaminari::Helpers::Paginator * ActionView::Base * ActionDispatch::DebugExceptions::DebugView Each time a partial is rendered for the first time, all methods for those modules will have to be redefined. This can exact a significant performance penalty. How bad is this penalty? Using the following benchmark script, we can use DTrace to sample the Ruby interpreter: ``` Benchmark.bm do |x| x.report do 1000.times do ActionView::CompiledTemplates.module_eval("def testme\nend") end end end ``` This revealed a 11x jump in the time spent in `core#define_method` alone. Rails 6 fixes this behavior by moving the `include CompiledTemplates` into ActionView::Base so that including `ActionView::Context` doesn't quietly affect other modules in this way. Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/11198
-
Shinya Maeda authored
With Pipelines for Merge Requests feature, users cannout keep using $CI_COMMIT_REF_NAME and _SLUG predefined variables for dynamic environments. We fix this problem by explicitly looking at the source ref.
-
Marcia Ramos authored
Fix text based on example See merge request gitlab-org/gitlab-ce!27787
-
Evan Read authored
-
Walmyr Lima authored
The reason for the change is that reading the code it should be si- milar to reading a newspaper, where high-level information is at the top, like the title and summary of the news, and low level, or more specific information, are at the bottom. This improves code readability.
-
James Lopez authored
Fix links to wiki pages with subdirectories in search Closes #56234 See merge request gitlab-org/gitlab-ce!27400
-