- 25 Sep, 2020 37 commits
-
-
Dylan Griffith authored
-
Dylan Griffith authored
The previous algorithm was a heuristic approach which looked for a term inside a highlighted fragment. The term in the fragment was then used again to find the matching line in the actual content. This ocassionally gave incorrect results where whatever happened to appear to be highlighted was also found earlier in the document written in a different way which was not intended to be a match. The [Elasticsearch highlighter]( https://www.elastic.co/guide/en/elasticsearch/reference/current/highlighting.html ) supports setting `number_of_fragments` to `0` which means that the highlighted result will actual be the entire content itself rather than small fragments of content. This makes it much easier to figure out the line number since we can just loop through this to begin with and stop as soon as we find the opening highlight tag. This does come at the cost that all docs are returned in the highlight section now which makes the Elasticsearch response payload approximately twice as large but it is the only correct way to do it that I could find. An alternative described in [the docs]( https://www.elastic.co/guide/en/elasticsearch/reference/current/highlighting.html ) is to use `boundary_scanner` but this requires the [Fast vector highlighter]( https://www.elastic.co/guide/en/elasticsearch/reference/current/highlighting.html#fast-vector-highlighter ) which in term requires us to set `offsets` for our [`index_options`]( https://www.elastic.co/guide/en/elasticsearch/reference/current/index-options.html ) but this will use considerably more storage so we would like to avoid this if possible. It's worth noting that this won't fix the fact that highlighting is not behaving properly in the quoted examples. For that I've created https://gitlab.com/gitlab-org/gitlab/-/issues/254941 which is explaining a very similar problem to this.
-
Kushal Pandya authored
Use gl-badge instead of custom styles See merge request gitlab-org/gitlab!43030
-
Heinrich Lee Yu authored
Remove migrate_bio_to_user_details FF See merge request gitlab-org/gitlab!43309
-
Heinrich Lee Yu authored
Move Feature Flag API Entities to Core RUN AS-IF-FOSS See merge request gitlab-org/gitlab!43345
-
Dmytro Zaporozhets (DZ) authored
Update soft email confirmation yaml See merge request gitlab-org/gitlab!43286
-
Dylan Griffith authored
Add test encryption key See merge request gitlab-org/gitlab!42475
-
Vitaly Slobodin authored
Use dataset instead of inline javascript to embed initial issuable data See merge request gitlab-org/gitlab!42667
-
Evan Read authored
Create inclusive-language tests Closes technical-writing#120 See merge request gitlab-org/gitlab!43038
-
Begin testing for words that are ableist in nature.
-
Achilleas Pipinellis authored
Update documentation: doc/push_rules/push_rules.md Closes #254984 See merge request gitlab-org/gitlab!43232
-
Steve Graham authored
-
Dylan Griffith authored
Move job token specs to core See merge request gitlab-org/gitlab!42374
-
Kushal Pandya authored
Reset labels select search text on Enter See merge request gitlab-org/gitlab!43285
-
Kushal Pandya authored
Migrate self monitor form button Closes #219807 See merge request gitlab-org/gitlab!43316
-
Mike Jang authored
-
Sanad Liaquat authored
Stablise e2e spec using wait_for_requests before clicking link Closes #255290 See merge request gitlab-org/gitlab!43260
-
Kushal Pandya authored
Merge branch '235605-convert-group-members-list-view-from-haml-to-vue-member-info-component' into 'master' Group members Vue conversion - avatar component See merge request gitlab-org/gitlab!43010
-
Peter Hegman authored
Adds member avatar related components to group members view
-
Dylan Griffith authored
Fill feature flag yaml file details for container_registry_fast_tag_delete See merge request gitlab-org/gitlab!43130
-
Gabriel Mazetto authored
Add graphql support for tf version replication Closes #237928 See merge request gitlab-org/gitlab!42533
-
Simon Knox authored
Update gldeprecatedbutton to glbutton Closes #219893 See merge request gitlab-org/gitlab!43207
-
Alexander Turinske authored
- in selection_summary_vuex.vue
-
Evan Read authored
Docs: Removed ableist language See merge request gitlab-org/gitlab!43363
-
Mark Chao authored
Geo: Permanently enable package_file_registries field Closes #255280 See merge request gitlab-org/gitlab!43245
-
Thong Kuah authored
Add Spec for Existing Deploy Boards Behavior See merge request gitlab-org/gitlab!43364
-
Mark Chao authored
Update invisible_captcha feature flag yaml See merge request gitlab-org/gitlab!43284
-
Heinrich Lee Yu authored
Add empty dependencies value to ECS Deploy job Closes #228674 See merge request gitlab-org/gitlab!36862
-
Eulyeon Ko authored
To remove HAML lint disablement for suing inline script, utilize dataset attribute to store the initial issuable data. Use sentry in place of console.error when parsing fails.
-
Evan Read authored
Improve Gitaly TLS setup details See merge request gitlab-org/gitlab!43039
-
Thong Kuah authored
Document GitLab.com puma request timeout See merge request gitlab-org/gitlab!43117
-
Mark Lapierre authored
Update outer describe block for internal QA tests 2/2 See merge request gitlab-org/gitlab!43185
-
Ezekiel Kigbo authored
Replace fa-warning icon in VSA limit warning See merge request gitlab-org/gitlab!43262
-
Mark Lapierre authored
Update outer describe block for internal QA tests 1/2 See merge request gitlab-org/gitlab!43184
-
Michael Kozono authored
Add replication for versioned terraform state Closes #237927 and #237926 See merge request gitlab-org/gitlab!42529
-
James Fargher authored
SAST mutation now supports analyzers section See merge request gitlab-org/gitlab!42542
-
rossfuhrman authored
The SAST Config GraphQL mutation now supports writing the analyzers section to .gitlab-ci.yml
-
- 24 Sep, 2020 3 commits
-
-
Jason Goodman authored
Small refactor to existing implementation
-
Suzanne Selhorn authored
Related to: https://gitlab.com/gitlab-org/gitlab/-/issues/255275
-
Paul Slaughter authored
Add JSON support to localStorageSync component Closes #247850 See merge request gitlab-org/gitlab!42938
-